From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-i2c@vger.kernel.org Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/12] i2c: powermac: convert to use i2c_new_client_device() Date: Tue, 7 Jan 2020 18:47:39 +0100 [thread overview] Message-ID: <20200107174748.9616-6-wsa+renesas@sang-engineering.com> (raw) In-Reply-To: <20200107174748.9616-1-wsa+renesas@sang-engineering.com> Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Build tested only. drivers/i2c/busses/i2c-powermac.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c index 504f5bf0e625..973e5339033c 100644 --- a/drivers/i2c/busses/i2c-powermac.c +++ b/drivers/i2c/busses/i2c-powermac.c @@ -240,8 +240,8 @@ static void i2c_powermac_create_one(struct i2c_adapter *adap, strncpy(info.type, type, sizeof(info.type)); info.addr = addr; - newdev = i2c_new_device(adap, &info); - if (!newdev) + newdev = i2c_new_client_device(adap, &info); + if (IS_ERR(newdev)) dev_err(&adap->dev, "i2c-powermac: Failure to register missing %s\n", type); @@ -359,8 +359,8 @@ static void i2c_powermac_register_devices(struct i2c_adapter *adap, info.irq = irq_of_parse_and_map(node, 0); info.of_node = of_node_get(node); - newdev = i2c_new_device(adap, &info); - if (!newdev) { + newdev = i2c_new_client_device(adap, &info); + if (IS_ERR(newdev)) { dev_err(&adap->dev, "i2c-powermac: Failure to register" " %pOF\n", node); of_node_put(node); -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-i2c@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Wolfram Sang <wsa+renesas@sang-engineering.com>, Paul Mackerras <paulus@samba.org>, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 05/12] i2c: powermac: convert to use i2c_new_client_device() Date: Tue, 7 Jan 2020 18:47:39 +0100 [thread overview] Message-ID: <20200107174748.9616-6-wsa+renesas@sang-engineering.com> (raw) In-Reply-To: <20200107174748.9616-1-wsa+renesas@sang-engineering.com> Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Build tested only. drivers/i2c/busses/i2c-powermac.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c index 504f5bf0e625..973e5339033c 100644 --- a/drivers/i2c/busses/i2c-powermac.c +++ b/drivers/i2c/busses/i2c-powermac.c @@ -240,8 +240,8 @@ static void i2c_powermac_create_one(struct i2c_adapter *adap, strncpy(info.type, type, sizeof(info.type)); info.addr = addr; - newdev = i2c_new_device(adap, &info); - if (!newdev) + newdev = i2c_new_client_device(adap, &info); + if (IS_ERR(newdev)) dev_err(&adap->dev, "i2c-powermac: Failure to register missing %s\n", type); @@ -359,8 +359,8 @@ static void i2c_powermac_register_devices(struct i2c_adapter *adap, info.irq = irq_of_parse_and_map(node, 0); info.of_node = of_node_get(node); - newdev = i2c_new_device(adap, &info); - if (!newdev) { + newdev = i2c_new_client_device(adap, &info); + if (IS_ERR(newdev)) { dev_err(&adap->dev, "i2c-powermac: Failure to register" " %pOF\n", node); of_node_put(node); -- 2.20.1
next prev parent reply other threads:[~2020-01-07 17:48 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-07 17:47 [PATCH 00/12] i2c: convert subsystem to use i2c_new_client_device() Wolfram Sang 2020-01-07 17:47 ` Wolfram Sang 2020-01-07 17:47 ` Wolfram Sang 2020-01-07 17:47 ` [PATCH 01/12] i2c: cht-wc: convert " Wolfram Sang 2020-01-09 23:05 ` Hans de Goede 2020-01-07 17:47 ` [PATCH 02/12] i2c: i801: " Wolfram Sang 2020-01-09 8:54 ` Jean Delvare 2020-01-09 8:54 ` Jean Delvare 2020-01-07 17:47 ` [PATCH 03/12] i2c: nvidia-gpu: " Wolfram Sang 2020-01-07 17:47 ` [PATCH 04/12] i2c: ocores: " Wolfram Sang 2020-01-07 18:32 ` Peter Korsgaard 2020-01-07 19:31 ` Wolfram Sang 2020-01-07 19:58 ` Peter Korsgaard 2020-01-07 19:36 ` Andrew Lunn 2020-01-07 17:47 ` Wolfram Sang [this message] 2020-01-07 17:47 ` [PATCH 05/12] i2c: powermac: " Wolfram Sang 2020-01-07 17:47 ` [PATCH 06/12] i2c: taos-evm: " Wolfram Sang 2020-01-08 10:58 ` Jean Delvare 2020-01-08 10:58 ` Jean Delvare 2020-01-09 8:42 ` Jean Delvare 2020-01-09 8:42 ` Jean Delvare 2020-01-15 19:56 ` Wolfram Sang 2020-01-07 17:47 ` [PATCH 07/12] i2c: xiic: " Wolfram Sang 2020-01-07 17:47 ` Wolfram Sang 2020-01-08 11:39 ` Michal Simek 2020-01-08 11:39 ` Michal Simek 2020-01-08 11:39 ` Michal Simek 2020-01-07 17:47 ` [PATCH 08/12] i2c: i2c-core-acpi: " Wolfram Sang 2020-01-08 10:04 ` Mika Westerberg 2020-01-07 17:47 ` [PATCH 09/12] i2c: i2c-core-base: " Wolfram Sang 2020-01-07 17:47 ` [PATCH 10/12] i2c: i2c-core-of: " Wolfram Sang 2020-01-07 17:47 ` [PATCH 11/12] docs: i2c: use the new API in 'instantiating-devices.rst' Wolfram Sang 2020-01-07 17:47 ` [PATCH 12/12] docs: i2c: use the new API in 'writing-clients' Wolfram Sang 2020-01-15 19:57 ` [PATCH 00/12] i2c: convert subsystem to use i2c_new_client_device() Wolfram Sang 2020-01-15 19:57 ` Wolfram Sang 2020-01-15 19:57 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200107174748.9616-6-wsa+renesas@sang-engineering.com \ --to=wsa+renesas@sang-engineering.com \ --cc=benh@kernel.crashing.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.