Re: [PATCH 06/12] i2c: taos-evm: convert to use i2c_new_client_device()

From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/12] i2c: taos-evm: convert to use i2c_new_client_device()
Date: Wed, 8 Jan 2020 11:58:22 +0100	[thread overview]
Message-ID: <20200108115822.20871d77@endymion> (raw)
In-Reply-To: <20200107174748.9616-7-wsa+renesas@sang-engineering.com>

Hi Wolfram,

On Tue, 7 Jan 2020 18:47:40 +0100, Wolfram Sang wrote:
> Move away from the deprecated API and return the shiny new ERRPTR where
> useful.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Build tested only.
> 
>  drivers/i2c/busses/i2c-taos-evm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
> index 0bff3f3a8779..b4050f5b6746 100644
> --- a/drivers/i2c/busses/i2c-taos-evm.c
> +++ b/drivers/i2c/busses/i2c-taos-evm.c
> @@ -49,10 +49,10 @@ static struct i2c_client *taos_instantiate_device(struct i2c_adapter *adapter)
>  	if (!strncmp(adapter->name, "TAOS TSL2550 EVM", 16)) {
>  		dev_info(&adapter->dev, "Instantiating device %s at 0x%02x\n",
>  			tsl2550_info.type, tsl2550_info.addr);
> -		return i2c_new_device(adapter, &tsl2550_info);
> +		return i2c_new_client_device(adapter, &tsl2550_info);
>  	}
>  
> -	return NULL;
> +	return ERR_PTR(-ENODEV);
>  }
>  
>  static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr,

Looks good to me, although ideally the caller should handle the error
instead of ignoring it. But that's out of scope for this conversion
patch, I'll look into submitting an update on top.

So:

Reviewed-by: Jean Delvare <jdelvare@suse.de>

I'll also try to revive my evaluation module to give it some testing.

Thanks,
-- 
Jean Delvare
SUSE L3 Support