From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/12] i2c: i801: convert to use i2c_new_client_device()
Date: Thu, 9 Jan 2020 09:54:58 +0100 [thread overview]
Message-ID: <20200109095458.62499f28@endymion> (raw)
In-Reply-To: <20200107174748.9616-3-wsa+renesas@sang-engineering.com>
On Tue, 7 Jan 2020 18:47:36 +0100, Wolfram Sang wrote:
> Move away from the deprecated API and return the shiny new ERRPTR where
> useful.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Build tested only.
>
> drivers/i2c/busses/i2c-i801.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index f5e69fe56532..44db3a91d32d 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1142,7 +1142,7 @@ static void dmi_check_onboard_device(u8 type, const char *name,
> memset(&info, 0, sizeof(struct i2c_board_info));
> info.addr = dmi_devices[i].i2c_addr;
> strlcpy(info.type, dmi_devices[i].i2c_type, I2C_NAME_SIZE);
> - i2c_new_device(adap, &info);
> + i2c_new_client_device(adap, &info);
> break;
> }
> }
> @@ -1296,7 +1296,7 @@ static void register_dell_lis3lv02d_i2c_device(struct i801_priv *priv)
> memset(&info, 0, sizeof(struct i2c_board_info));
> info.addr = dell_lis3lv02d_devices[i].i2c_addr;
> strlcpy(info.type, "lis3lv02d", I2C_NAME_SIZE);
> - i2c_new_device(&priv->adapter, &info);
> + i2c_new_client_device(&priv->adapter, &info);
> }
>
> /* Register optional slaves */
> @@ -1312,7 +1312,7 @@ static void i801_probe_optional_slaves(struct i801_priv *priv)
> memset(&info, 0, sizeof(struct i2c_board_info));
> info.addr = apanel_addr;
> strlcpy(info.type, "fujitsu_apanel", I2C_NAME_SIZE);
> - i2c_new_device(&priv->adapter, &info);
> + i2c_new_client_device(&priv->adapter, &info);
> }
>
> if (dmi_name_in_vendors("FUJITSU"))
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Thanks,
--
Jean Delvare
SUSE L3 Support
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/12] i2c: i801: convert to use i2c_new_client_device()
Date: Thu, 9 Jan 2020 09:54:58 +0100 [thread overview]
Message-ID: <20200109095458.62499f28@endymion> (raw)
In-Reply-To: <20200107174748.9616-3-wsa+renesas@sang-engineering.com>
On Tue, 7 Jan 2020 18:47:36 +0100, Wolfram Sang wrote:
> Move away from the deprecated API and return the shiny new ERRPTR where
> useful.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Build tested only.
>
> drivers/i2c/busses/i2c-i801.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index f5e69fe56532..44db3a91d32d 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1142,7 +1142,7 @@ static void dmi_check_onboard_device(u8 type, const char *name,
> memset(&info, 0, sizeof(struct i2c_board_info));
> info.addr = dmi_devices[i].i2c_addr;
> strlcpy(info.type, dmi_devices[i].i2c_type, I2C_NAME_SIZE);
> - i2c_new_device(adap, &info);
> + i2c_new_client_device(adap, &info);
> break;
> }
> }
> @@ -1296,7 +1296,7 @@ static void register_dell_lis3lv02d_i2c_device(struct i801_priv *priv)
> memset(&info, 0, sizeof(struct i2c_board_info));
> info.addr = dell_lis3lv02d_devices[i].i2c_addr;
> strlcpy(info.type, "lis3lv02d", I2C_NAME_SIZE);
> - i2c_new_device(&priv->adapter, &info);
> + i2c_new_client_device(&priv->adapter, &info);
> }
>
> /* Register optional slaves */
> @@ -1312,7 +1312,7 @@ static void i801_probe_optional_slaves(struct i801_priv *priv)
> memset(&info, 0, sizeof(struct i2c_board_info));
> info.addr = apanel_addr;
> strlcpy(info.type, "fujitsu_apanel", I2C_NAME_SIZE);
> - i2c_new_device(&priv->adapter, &info);
> + i2c_new_client_device(&priv->adapter, &info);
> }
>
> if (dmi_name_in_vendors("FUJITSU"))
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2020-01-09 9:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 17:47 [PATCH 00/12] i2c: convert subsystem to use i2c_new_client_device() Wolfram Sang
2020-01-07 17:47 ` Wolfram Sang
2020-01-07 17:47 ` Wolfram Sang
2020-01-07 17:47 ` [PATCH 01/12] i2c: cht-wc: convert " Wolfram Sang
2020-01-09 23:05 ` Hans de Goede
2020-01-07 17:47 ` [PATCH 02/12] i2c: i801: " Wolfram Sang
2020-01-09 8:54 ` Jean Delvare [this message]
2020-01-09 8:54 ` Jean Delvare
2020-01-07 17:47 ` [PATCH 03/12] i2c: nvidia-gpu: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 04/12] i2c: ocores: " Wolfram Sang
2020-01-07 18:32 ` Peter Korsgaard
2020-01-07 19:31 ` Wolfram Sang
2020-01-07 19:58 ` Peter Korsgaard
2020-01-07 19:36 ` Andrew Lunn
2020-01-07 17:47 ` [PATCH 05/12] i2c: powermac: " Wolfram Sang
2020-01-07 17:47 ` Wolfram Sang
2020-01-07 17:47 ` [PATCH 06/12] i2c: taos-evm: " Wolfram Sang
2020-01-08 10:58 ` Jean Delvare
2020-01-08 10:58 ` Jean Delvare
2020-01-09 8:42 ` Jean Delvare
2020-01-09 8:42 ` Jean Delvare
2020-01-15 19:56 ` Wolfram Sang
2020-01-07 17:47 ` [PATCH 07/12] i2c: xiic: " Wolfram Sang
2020-01-07 17:47 ` Wolfram Sang
2020-01-08 11:39 ` Michal Simek
2020-01-08 11:39 ` Michal Simek
2020-01-08 11:39 ` Michal Simek
2020-01-07 17:47 ` [PATCH 08/12] i2c: i2c-core-acpi: " Wolfram Sang
2020-01-08 10:04 ` Mika Westerberg
2020-01-07 17:47 ` [PATCH 09/12] i2c: i2c-core-base: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 10/12] i2c: i2c-core-of: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 11/12] docs: i2c: use the new API in 'instantiating-devices.rst' Wolfram Sang
2020-01-07 17:47 ` [PATCH 12/12] docs: i2c: use the new API in 'writing-clients' Wolfram Sang
2020-01-15 19:57 ` [PATCH 00/12] i2c: convert subsystem to use i2c_new_client_device() Wolfram Sang
2020-01-15 19:57 ` Wolfram Sang
2020-01-15 19:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109095458.62499f28@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.