From: Ville Syrjala <ville.syrjala@linux.intel.com> To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Subject: [PATCH 12/12] drm: pahole struct drm_display_mode Date: Wed, 19 Feb 2020 22:35:44 +0200 [thread overview] Message-ID: <20200219203544.31013-13-ville.syrjala@linux.intel.com> (raw) In-Reply-To: <20200219203544.31013-1-ville.syrjala@linux.intel.com> From: Ville Syrjälä <ville.syrjala@linux.intel.com> Reorganize drm_display_mode to eliminate all the holes. We'll put all the actual timings to the start of the struct and all the extra junk to the end. Gets the size down to 136 bytes on 64bit and 120 bytes on 32bit. With a bit more work we should be able to get this below the two cacheline mark even on 64bit. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- include/drm/drm_modes.h | 139 ++++++++++++++++++++-------------------- 1 file changed, 70 insertions(+), 69 deletions(-) diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index dadb0f3e5b0b..fded81306a47 100644 --- a/include/drm/drm_modes.h +++ b/include/drm/drm_modes.h @@ -222,56 +222,6 @@ enum drm_mode_status { * For printing you can use %DRM_MODE_FMT and DRM_MODE_ARG(). */ struct drm_display_mode { - /** - * @head: - * - * struct list_head for mode lists. - */ - struct list_head head; - - /** - * @name: - * - * Human-readable name of the mode, filled out with drm_mode_set_name(). - */ - char name[DRM_DISPLAY_MODE_LEN]; - - /** - * @status: - * - * Status of the mode, used to filter out modes not supported by the - * hardware. See enum &drm_mode_status. - */ - enum drm_mode_status status; - - /** - * @type: - * - * A bitmask of flags, mostly about the source of a mode. Possible flags - * are: - * - * - DRM_MODE_TYPE_PREFERRED: Preferred mode, usually the native - * resolution of an LCD panel. There should only be one preferred - * mode per connector at any given time. - * - DRM_MODE_TYPE_DRIVER: Mode created by the driver, which is all of - * them really. Drivers must set this bit for all modes they create - * and expose to userspace. - * - DRM_MODE_TYPE_USERDEF: Mode defined via kernel command line - * - * Plus a big list of flags which shouldn't be used at all, but are - * still around since these flags are also used in the userspace ABI. - * We no longer accept modes with these types though: - * - * - DRM_MODE_TYPE_BUILTIN: Meant for hard-coded modes, unused. - * Use DRM_MODE_TYPE_DRIVER instead. - * - DRM_MODE_TYPE_DEFAULT: Again a leftover, use - * DRM_MODE_TYPE_PREFERRED instead. - * - DRM_MODE_TYPE_CLOCK_C and DRM_MODE_TYPE_CRTC_C: Define leftovers - * which are stuck around for hysterical raisins only. No one has an - * idea what they were meant for. Don't use. - */ - u8 type; - /** * @clock: * @@ -324,22 +274,6 @@ struct drm_display_mode { */ u32 flags; - /** - * @width_mm: - * - * Addressable size of the output in mm, projectors should set this to - * 0. - */ - u16 width_mm; - - /** - * @height_mm: - * - * Addressable size of the output in mm, projectors should set this to - * 0. - */ - u16 height_mm; - /** * @crtc_clock: * @@ -370,6 +304,50 @@ struct drm_display_mode { u16 crtc_vsync_end; u16 crtc_vtotal; + /** + * @width_mm: + * + * Addressable size of the output in mm, projectors should set this to + * 0. + */ + u16 width_mm; + + /** + * @height_mm: + * + * Addressable size of the output in mm, projectors should set this to + * 0. + */ + u16 height_mm; + + /** + * @type: + * + * A bitmask of flags, mostly about the source of a mode. Possible flags + * are: + * + * - DRM_MODE_TYPE_PREFERRED: Preferred mode, usually the native + * resolution of an LCD panel. There should only be one preferred + * mode per connector at any given time. + * - DRM_MODE_TYPE_DRIVER: Mode created by the driver, which is all of + * them really. Drivers must set this bit for all modes they create + * and expose to userspace. + * - DRM_MODE_TYPE_USERDEF: Mode defined via kernel command line + * + * Plus a big list of flags which shouldn't be used at all, but are + * still around since these flags are also used in the userspace ABI. + * We no longer accept modes with these types though: + * + * - DRM_MODE_TYPE_BUILTIN: Meant for hard-coded modes, unused. + * Use DRM_MODE_TYPE_DRIVER instead. + * - DRM_MODE_TYPE_DEFAULT: Again a leftover, use + * DRM_MODE_TYPE_PREFERRED instead. + * - DRM_MODE_TYPE_CLOCK_C and DRM_MODE_TYPE_CRTC_C: Define leftovers + * which are stuck around for hysterical raisins only. No one has an + * idea what they were meant for. Don't use. + */ + u8 type; + /** * @private_flags: * @@ -381,11 +359,11 @@ struct drm_display_mode { u8 private_flags; /** - * @picture_aspect_ratio: + * @head: * - * Field for setting the HDMI picture aspect ratio of a mode. + * struct list_head for mode lists. */ - enum hdmi_picture_aspect picture_aspect_ratio; + struct list_head head; /** * @export_head: @@ -399,6 +377,29 @@ struct drm_display_mode { * avoid overhead of protecting it by mode_config.mutex. */ struct list_head export_head; + + /** + * @name: + * + * Human-readable name of the mode, filled out with drm_mode_set_name(). + */ + char name[DRM_DISPLAY_MODE_LEN]; + + /** + * @status: + * + * Status of the mode, used to filter out modes not supported by the + * hardware. See enum &drm_mode_status. + */ + enum drm_mode_status status; + + /** + * @picture_aspect_ratio: + * + * Field for setting the HDMI picture aspect ratio of a mode. + */ + enum hdmi_picture_aspect picture_aspect_ratio; + }; /** -- 2.24.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ville Syrjala <ville.syrjala@linux.intel.com> To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 12/12] drm: pahole struct drm_display_mode Date: Wed, 19 Feb 2020 22:35:44 +0200 [thread overview] Message-ID: <20200219203544.31013-13-ville.syrjala@linux.intel.com> (raw) In-Reply-To: <20200219203544.31013-1-ville.syrjala@linux.intel.com> From: Ville Syrjälä <ville.syrjala@linux.intel.com> Reorganize drm_display_mode to eliminate all the holes. We'll put all the actual timings to the start of the struct and all the extra junk to the end. Gets the size down to 136 bytes on 64bit and 120 bytes on 32bit. With a bit more work we should be able to get this below the two cacheline mark even on 64bit. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- include/drm/drm_modes.h | 139 ++++++++++++++++++++-------------------- 1 file changed, 70 insertions(+), 69 deletions(-) diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index dadb0f3e5b0b..fded81306a47 100644 --- a/include/drm/drm_modes.h +++ b/include/drm/drm_modes.h @@ -222,56 +222,6 @@ enum drm_mode_status { * For printing you can use %DRM_MODE_FMT and DRM_MODE_ARG(). */ struct drm_display_mode { - /** - * @head: - * - * struct list_head for mode lists. - */ - struct list_head head; - - /** - * @name: - * - * Human-readable name of the mode, filled out with drm_mode_set_name(). - */ - char name[DRM_DISPLAY_MODE_LEN]; - - /** - * @status: - * - * Status of the mode, used to filter out modes not supported by the - * hardware. See enum &drm_mode_status. - */ - enum drm_mode_status status; - - /** - * @type: - * - * A bitmask of flags, mostly about the source of a mode. Possible flags - * are: - * - * - DRM_MODE_TYPE_PREFERRED: Preferred mode, usually the native - * resolution of an LCD panel. There should only be one preferred - * mode per connector at any given time. - * - DRM_MODE_TYPE_DRIVER: Mode created by the driver, which is all of - * them really. Drivers must set this bit for all modes they create - * and expose to userspace. - * - DRM_MODE_TYPE_USERDEF: Mode defined via kernel command line - * - * Plus a big list of flags which shouldn't be used at all, but are - * still around since these flags are also used in the userspace ABI. - * We no longer accept modes with these types though: - * - * - DRM_MODE_TYPE_BUILTIN: Meant for hard-coded modes, unused. - * Use DRM_MODE_TYPE_DRIVER instead. - * - DRM_MODE_TYPE_DEFAULT: Again a leftover, use - * DRM_MODE_TYPE_PREFERRED instead. - * - DRM_MODE_TYPE_CLOCK_C and DRM_MODE_TYPE_CRTC_C: Define leftovers - * which are stuck around for hysterical raisins only. No one has an - * idea what they were meant for. Don't use. - */ - u8 type; - /** * @clock: * @@ -324,22 +274,6 @@ struct drm_display_mode { */ u32 flags; - /** - * @width_mm: - * - * Addressable size of the output in mm, projectors should set this to - * 0. - */ - u16 width_mm; - - /** - * @height_mm: - * - * Addressable size of the output in mm, projectors should set this to - * 0. - */ - u16 height_mm; - /** * @crtc_clock: * @@ -370,6 +304,50 @@ struct drm_display_mode { u16 crtc_vsync_end; u16 crtc_vtotal; + /** + * @width_mm: + * + * Addressable size of the output in mm, projectors should set this to + * 0. + */ + u16 width_mm; + + /** + * @height_mm: + * + * Addressable size of the output in mm, projectors should set this to + * 0. + */ + u16 height_mm; + + /** + * @type: + * + * A bitmask of flags, mostly about the source of a mode. Possible flags + * are: + * + * - DRM_MODE_TYPE_PREFERRED: Preferred mode, usually the native + * resolution of an LCD panel. There should only be one preferred + * mode per connector at any given time. + * - DRM_MODE_TYPE_DRIVER: Mode created by the driver, which is all of + * them really. Drivers must set this bit for all modes they create + * and expose to userspace. + * - DRM_MODE_TYPE_USERDEF: Mode defined via kernel command line + * + * Plus a big list of flags which shouldn't be used at all, but are + * still around since these flags are also used in the userspace ABI. + * We no longer accept modes with these types though: + * + * - DRM_MODE_TYPE_BUILTIN: Meant for hard-coded modes, unused. + * Use DRM_MODE_TYPE_DRIVER instead. + * - DRM_MODE_TYPE_DEFAULT: Again a leftover, use + * DRM_MODE_TYPE_PREFERRED instead. + * - DRM_MODE_TYPE_CLOCK_C and DRM_MODE_TYPE_CRTC_C: Define leftovers + * which are stuck around for hysterical raisins only. No one has an + * idea what they were meant for. Don't use. + */ + u8 type; + /** * @private_flags: * @@ -381,11 +359,11 @@ struct drm_display_mode { u8 private_flags; /** - * @picture_aspect_ratio: + * @head: * - * Field for setting the HDMI picture aspect ratio of a mode. + * struct list_head for mode lists. */ - enum hdmi_picture_aspect picture_aspect_ratio; + struct list_head head; /** * @export_head: @@ -399,6 +377,29 @@ struct drm_display_mode { * avoid overhead of protecting it by mode_config.mutex. */ struct list_head export_head; + + /** + * @name: + * + * Human-readable name of the mode, filled out with drm_mode_set_name(). + */ + char name[DRM_DISPLAY_MODE_LEN]; + + /** + * @status: + * + * Status of the mode, used to filter out modes not supported by the + * hardware. See enum &drm_mode_status. + */ + enum drm_mode_status status; + + /** + * @picture_aspect_ratio: + * + * Field for setting the HDMI picture aspect ratio of a mode. + */ + enum hdmi_picture_aspect picture_aspect_ratio; + }; /** -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-19 20:36 UTC|newest] Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-19 20:35 [PATCH 00/12] drm: Put drm_display_mode on diet Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` [PATCH 01/12] drm: Nuke mode->hsync Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 10:55 ` Emil Velikov 2020-02-20 10:55 ` Emil Velikov 2020-02-21 16:04 ` Ville Syrjälä 2020-02-21 16:04 ` Ville Syrjälä 2020-02-21 16:55 ` Emil Velikov 2020-02-21 16:55 ` Emil Velikov 2020-02-19 20:35 ` [PATCH 02/12] drm/exynos: Use mode->clock instead of reverse calculating it from the vrefresh Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 10:56 ` Emil Velikov 2020-02-20 10:56 ` [Intel-gfx] " Emil Velikov 2020-02-25 0:49 ` Inki Dae 2020-02-19 20:35 ` [PATCH 03/12] drm/i915: Introduce some local intel_dp variables Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 11:13 ` Emil Velikov 2020-02-20 11:13 ` Emil Velikov 2020-02-19 20:35 ` [PATCH 04/12] drm: Nuke mode->vrefresh Ville Syrjala 2020-02-19 20:35 ` Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` Ville Syrjala 2020-02-20 12:00 ` Emil Velikov 2020-02-20 12:00 ` Emil Velikov 2020-02-20 12:00 ` [Intel-gfx] " Emil Velikov 2020-02-20 12:00 ` Emil Velikov 2020-02-22 12:32 ` Sam Ravnborg 2020-02-22 12:32 ` Sam Ravnborg 2020-02-22 12:32 ` [Intel-gfx] " Sam Ravnborg 2020-02-22 12:32 ` Sam Ravnborg 2020-02-24 13:14 ` Ville Syrjälä 2020-02-24 13:14 ` Ville Syrjälä 2020-02-24 13:14 ` [Intel-gfx] " Ville Syrjälä 2020-02-24 13:14 ` Ville Syrjälä 2020-02-24 14:14 ` Andrzej Hajda 2020-02-24 14:14 ` Andrzej Hajda 2020-02-24 14:14 ` [Intel-gfx] " Andrzej Hajda 2020-02-24 14:14 ` Andrzej Hajda 2020-02-25 11:21 ` Ville Syrjälä 2020-02-25 11:21 ` Ville Syrjälä 2020-02-25 11:21 ` [Intel-gfx] " Ville Syrjälä 2020-02-25 11:21 ` Ville Syrjälä 2020-02-25 15:19 ` Andrzej Hajda 2020-02-25 15:19 ` Andrzej Hajda 2020-02-25 15:19 ` [Intel-gfx] " Andrzej Hajda 2020-02-25 15:19 ` Andrzej Hajda 2020-02-25 15:45 ` Ville Syrjälä 2020-02-25 15:45 ` Ville Syrjälä 2020-02-25 15:45 ` [Intel-gfx] " Ville Syrjälä 2020-02-25 15:45 ` Ville Syrjälä 2020-02-25 19:27 ` Ville Syrjälä 2020-02-25 19:27 ` [Intel-gfx] " Ville Syrjälä 2020-02-25 19:27 ` Ville Syrjälä 2020-02-25 21:52 ` Linus Walleij 2020-02-25 21:52 ` Linus Walleij 2020-02-25 21:52 ` [Intel-gfx] " Linus Walleij 2020-02-25 21:52 ` Linus Walleij 2020-02-19 20:35 ` [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` Ville Syrjala 2020-02-20 11:24 ` Emil Velikov 2020-02-20 11:24 ` [Intel-gfx] " Emil Velikov 2020-02-20 11:24 ` Emil Velikov 2020-02-20 15:33 ` Ville Syrjälä 2020-02-20 15:33 ` [Intel-gfx] " Ville Syrjälä 2020-02-20 15:33 ` Ville Syrjälä 2020-02-20 18:14 ` Daniel Vetter 2020-02-20 18:14 ` [Intel-gfx] " Daniel Vetter 2020-02-20 18:14 ` Daniel Vetter 2020-02-19 20:35 ` [PATCH 06/12] drm: Shrink {width,height}_mm to u16 Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 12:48 ` Emil Velikov 2020-02-20 12:48 ` Emil Velikov 2020-02-19 20:35 ` [PATCH 07/12] drm: Shrink mode->type to u8 Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 18:17 ` Daniel Vetter 2020-02-20 18:17 ` Daniel Vetter 2020-02-19 20:35 ` [PATCH 08/12] drm: Make mode->flags u32 Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` [PATCH 09/12] drm: Shrink drm_display_mode timings Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 18:19 ` Daniel Vetter 2020-02-20 18:19 ` Daniel Vetter 2020-02-20 18:47 ` Ville Syrjälä 2020-02-20 18:47 ` Ville Syrjälä 2020-02-21 16:13 ` Sam Ravnborg 2020-02-21 16:13 ` [Intel-gfx] " Sam Ravnborg 2020-02-21 17:27 ` Sam Ravnborg 2020-02-21 17:27 ` [Intel-gfx] " Sam Ravnborg 2020-02-24 13:06 ` Ville Syrjälä 2020-02-24 13:06 ` [Intel-gfx] " Ville Syrjälä 2020-02-19 20:35 ` [PATCH 10/12] drm: Flatten drm_mode_vrefresh() Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` [PATCH 11/12] drm: Shrink mode->private_flags Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-21 16:15 ` Sam Ravnborg 2020-02-21 16:15 ` [Intel-gfx] " Sam Ravnborg 2020-02-24 13:23 ` Ville Syrjälä 2020-02-24 13:23 ` [Intel-gfx] " Ville Syrjälä 2020-02-19 20:35 ` Ville Syrjala [this message] 2020-02-19 20:35 ` [Intel-gfx] [PATCH 12/12] drm: pahole struct drm_display_mode Ville Syrjala 2020-02-20 12:53 ` Emil Velikov 2020-02-20 12:53 ` [Intel-gfx] " Emil Velikov 2020-02-19 20:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Put drm_display_mode on diet Patchwork 2020-02-19 21:18 ` [PATCH 00/12] " Ville Syrjälä 2020-02-19 21:18 ` [Intel-gfx] " Ville Syrjälä 2020-02-19 21:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-02-20 13:21 ` [PATCH 00/12] " Emil Velikov 2020-02-20 13:21 ` [Intel-gfx] " Emil Velikov 2020-02-20 14:27 ` Ville Syrjälä 2020-02-20 14:27 ` [Intel-gfx] " Ville Syrjälä 2020-02-20 15:34 ` Ville Syrjälä 2020-02-20 15:34 ` Ville Syrjälä 2020-02-21 11:32 ` Jani Nikula 2020-02-21 11:32 ` Jani Nikula 2020-02-21 11:43 ` Ville Syrjälä 2020-02-21 11:43 ` Ville Syrjälä 2020-02-21 14:42 ` Daniel Vetter 2020-02-21 14:42 ` Daniel Vetter 2020-02-21 15:40 ` Ville Syrjälä 2020-02-21 15:40 ` Ville Syrjälä 2020-02-21 16:09 ` Ville Syrjälä 2020-02-21 16:09 ` Ville Syrjälä 2020-02-21 17:16 ` Daniel Vetter 2020-02-21 17:16 ` Daniel Vetter 2020-02-21 17:49 ` Ville Syrjälä 2020-02-21 17:49 ` Ville Syrjälä 2020-02-20 17:01 ` Emil Velikov 2020-02-20 17:01 ` [Intel-gfx] " Emil Velikov 2020-02-21 15:09 ` Linus Walleij 2020-02-21 15:09 ` [Intel-gfx] " Linus Walleij 2020-02-21 18:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200219203544.31013-13-ville.syrjala@linux.intel.com \ --to=ville.syrjala@linux.intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.