From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Emil Velikov <emil.l.velikov@gmail.com>,
Sean Paul <sean@poorly.run>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
freedreno@lists.freedesktop.org,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags
Date: Thu, 20 Feb 2020 19:14:42 +0100 [thread overview]
Message-ID: <20200220181442.GV2363188@phenom.ffwll.local> (raw)
In-Reply-To: <20200220153309.GB13686@intel.com>
On Thu, Feb 20, 2020 at 05:33:09PM +0200, Ville Syrjälä wrote:
> On Thu, Feb 20, 2020 at 11:24:20AM +0000, Emil Velikov wrote:
> > On Wed, 19 Feb 2020 at 20:36, Ville Syrjala
> > <ville.syrjala@linux.intel.com> wrote:
> > >
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > The driver never sets mode->private_flags so copying
> > > it back and forth is entirely pointless. Stop doing it.
> > >
> > > Also drop private_flags from the tracepoint.
> > >
> > > Cc: Rob Clark <robdclark@gmail.com>
> > > Cc: Sean Paul <sean@poorly.run>
> > > Cc: linux-arm-msm@vger.kernel.org
> > > Cc: freedreno@lists.freedesktop.org
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Perhaps the msm team has a WIP which makes use of it ?
>
> Maybe if it's one of them five year projects. But anyways,
> with an atomic driver there are certainly better ways to
> handle this.
Yeah with atomic you have your display mode in drm_crtc_state, which
you're subposed to subclass so that you can have terabytes of private
state. At least in theory :-)
->private_flags was really only useful in pre-atomic drivers.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: freedreno@lists.freedesktop.org,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Emil Velikov <emil.l.velikov@gmail.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags
Date: Thu, 20 Feb 2020 19:14:42 +0100 [thread overview]
Message-ID: <20200220181442.GV2363188@phenom.ffwll.local> (raw)
In-Reply-To: <20200220153309.GB13686@intel.com>
On Thu, Feb 20, 2020 at 05:33:09PM +0200, Ville Syrjälä wrote:
> On Thu, Feb 20, 2020 at 11:24:20AM +0000, Emil Velikov wrote:
> > On Wed, 19 Feb 2020 at 20:36, Ville Syrjala
> > <ville.syrjala@linux.intel.com> wrote:
> > >
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > The driver never sets mode->private_flags so copying
> > > it back and forth is entirely pointless. Stop doing it.
> > >
> > > Also drop private_flags from the tracepoint.
> > >
> > > Cc: Rob Clark <robdclark@gmail.com>
> > > Cc: Sean Paul <sean@poorly.run>
> > > Cc: linux-arm-msm@vger.kernel.org
> > > Cc: freedreno@lists.freedesktop.org
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Perhaps the msm team has a WIP which makes use of it ?
>
> Maybe if it's one of them five year projects. But anyways,
> with an atomic driver there are certainly better ways to
> handle this.
Yeah with atomic you have your display mode in drm_crtc_state, which
you're subposed to subclass so that you can have terabytes of private
state. At least in theory :-)
->private_flags was really only useful in pre-atomic drivers.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: freedreno@lists.freedesktop.org,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags
Date: Thu, 20 Feb 2020 19:14:42 +0100 [thread overview]
Message-ID: <20200220181442.GV2363188@phenom.ffwll.local> (raw)
In-Reply-To: <20200220153309.GB13686@intel.com>
On Thu, Feb 20, 2020 at 05:33:09PM +0200, Ville Syrjälä wrote:
> On Thu, Feb 20, 2020 at 11:24:20AM +0000, Emil Velikov wrote:
> > On Wed, 19 Feb 2020 at 20:36, Ville Syrjala
> > <ville.syrjala@linux.intel.com> wrote:
> > >
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > The driver never sets mode->private_flags so copying
> > > it back and forth is entirely pointless. Stop doing it.
> > >
> > > Also drop private_flags from the tracepoint.
> > >
> > > Cc: Rob Clark <robdclark@gmail.com>
> > > Cc: Sean Paul <sean@poorly.run>
> > > Cc: linux-arm-msm@vger.kernel.org
> > > Cc: freedreno@lists.freedesktop.org
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Perhaps the msm team has a WIP which makes use of it ?
>
> Maybe if it's one of them five year projects. But anyways,
> with an atomic driver there are certainly better ways to
> handle this.
Yeah with atomic you have your display mode in drm_crtc_state, which
you're subposed to subclass so that you can have terabytes of private
state. At least in theory :-)
->private_flags was really only useful in pre-atomic drivers.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-20 18:14 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 20:35 [PATCH 00/12] drm: Put drm_display_mode on diet Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-19 20:35 ` [PATCH 01/12] drm: Nuke mode->hsync Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-20 10:55 ` Emil Velikov
2020-02-20 10:55 ` Emil Velikov
2020-02-21 16:04 ` Ville Syrjälä
2020-02-21 16:04 ` Ville Syrjälä
2020-02-21 16:55 ` Emil Velikov
2020-02-21 16:55 ` Emil Velikov
2020-02-19 20:35 ` [PATCH 02/12] drm/exynos: Use mode->clock instead of reverse calculating it from the vrefresh Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-20 10:56 ` Emil Velikov
2020-02-20 10:56 ` [Intel-gfx] " Emil Velikov
2020-02-25 0:49 ` Inki Dae
2020-02-19 20:35 ` [PATCH 03/12] drm/i915: Introduce some local intel_dp variables Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-20 11:13 ` Emil Velikov
2020-02-20 11:13 ` Emil Velikov
2020-02-19 20:35 ` [PATCH 04/12] drm: Nuke mode->vrefresh Ville Syrjala
2020-02-19 20:35 ` Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-19 20:35 ` Ville Syrjala
2020-02-20 12:00 ` Emil Velikov
2020-02-20 12:00 ` Emil Velikov
2020-02-20 12:00 ` [Intel-gfx] " Emil Velikov
2020-02-20 12:00 ` Emil Velikov
2020-02-22 12:32 ` Sam Ravnborg
2020-02-22 12:32 ` Sam Ravnborg
2020-02-22 12:32 ` [Intel-gfx] " Sam Ravnborg
2020-02-22 12:32 ` Sam Ravnborg
2020-02-24 13:14 ` Ville Syrjälä
2020-02-24 13:14 ` Ville Syrjälä
2020-02-24 13:14 ` [Intel-gfx] " Ville Syrjälä
2020-02-24 13:14 ` Ville Syrjälä
2020-02-24 14:14 ` Andrzej Hajda
2020-02-24 14:14 ` Andrzej Hajda
2020-02-24 14:14 ` [Intel-gfx] " Andrzej Hajda
2020-02-24 14:14 ` Andrzej Hajda
2020-02-25 11:21 ` Ville Syrjälä
2020-02-25 11:21 ` Ville Syrjälä
2020-02-25 11:21 ` [Intel-gfx] " Ville Syrjälä
2020-02-25 11:21 ` Ville Syrjälä
2020-02-25 15:19 ` Andrzej Hajda
2020-02-25 15:19 ` Andrzej Hajda
2020-02-25 15:19 ` [Intel-gfx] " Andrzej Hajda
2020-02-25 15:19 ` Andrzej Hajda
2020-02-25 15:45 ` Ville Syrjälä
2020-02-25 15:45 ` Ville Syrjälä
2020-02-25 15:45 ` [Intel-gfx] " Ville Syrjälä
2020-02-25 15:45 ` Ville Syrjälä
2020-02-25 19:27 ` Ville Syrjälä
2020-02-25 19:27 ` [Intel-gfx] " Ville Syrjälä
2020-02-25 19:27 ` Ville Syrjälä
2020-02-25 21:52 ` Linus Walleij
2020-02-25 21:52 ` Linus Walleij
2020-02-25 21:52 ` [Intel-gfx] " Linus Walleij
2020-02-25 21:52 ` Linus Walleij
2020-02-19 20:35 ` [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-19 20:35 ` Ville Syrjala
2020-02-20 11:24 ` Emil Velikov
2020-02-20 11:24 ` [Intel-gfx] " Emil Velikov
2020-02-20 11:24 ` Emil Velikov
2020-02-20 15:33 ` Ville Syrjälä
2020-02-20 15:33 ` [Intel-gfx] " Ville Syrjälä
2020-02-20 15:33 ` Ville Syrjälä
2020-02-20 18:14 ` Daniel Vetter [this message]
2020-02-20 18:14 ` [Intel-gfx] " Daniel Vetter
2020-02-20 18:14 ` Daniel Vetter
2020-02-19 20:35 ` [PATCH 06/12] drm: Shrink {width,height}_mm to u16 Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-20 12:48 ` Emil Velikov
2020-02-20 12:48 ` Emil Velikov
2020-02-19 20:35 ` [PATCH 07/12] drm: Shrink mode->type to u8 Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-20 18:17 ` Daniel Vetter
2020-02-20 18:17 ` Daniel Vetter
2020-02-19 20:35 ` [PATCH 08/12] drm: Make mode->flags u32 Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-19 20:35 ` [PATCH 09/12] drm: Shrink drm_display_mode timings Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-20 18:19 ` Daniel Vetter
2020-02-20 18:19 ` Daniel Vetter
2020-02-20 18:47 ` Ville Syrjälä
2020-02-20 18:47 ` Ville Syrjälä
2020-02-21 16:13 ` Sam Ravnborg
2020-02-21 16:13 ` [Intel-gfx] " Sam Ravnborg
2020-02-21 17:27 ` Sam Ravnborg
2020-02-21 17:27 ` [Intel-gfx] " Sam Ravnborg
2020-02-24 13:06 ` Ville Syrjälä
2020-02-24 13:06 ` [Intel-gfx] " Ville Syrjälä
2020-02-19 20:35 ` [PATCH 10/12] drm: Flatten drm_mode_vrefresh() Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-19 20:35 ` [PATCH 11/12] drm: Shrink mode->private_flags Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-21 16:15 ` Sam Ravnborg
2020-02-21 16:15 ` [Intel-gfx] " Sam Ravnborg
2020-02-24 13:23 ` Ville Syrjälä
2020-02-24 13:23 ` [Intel-gfx] " Ville Syrjälä
2020-02-19 20:35 ` [PATCH 12/12] drm: pahole struct drm_display_mode Ville Syrjala
2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala
2020-02-20 12:53 ` Emil Velikov
2020-02-20 12:53 ` [Intel-gfx] " Emil Velikov
2020-02-19 20:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Put drm_display_mode on diet Patchwork
2020-02-19 21:18 ` [PATCH 00/12] " Ville Syrjälä
2020-02-19 21:18 ` [Intel-gfx] " Ville Syrjälä
2020-02-19 21:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-20 13:21 ` [PATCH 00/12] " Emil Velikov
2020-02-20 13:21 ` [Intel-gfx] " Emil Velikov
2020-02-20 14:27 ` Ville Syrjälä
2020-02-20 14:27 ` [Intel-gfx] " Ville Syrjälä
2020-02-20 15:34 ` Ville Syrjälä
2020-02-20 15:34 ` Ville Syrjälä
2020-02-21 11:32 ` Jani Nikula
2020-02-21 11:32 ` Jani Nikula
2020-02-21 11:43 ` Ville Syrjälä
2020-02-21 11:43 ` Ville Syrjälä
2020-02-21 14:42 ` Daniel Vetter
2020-02-21 14:42 ` Daniel Vetter
2020-02-21 15:40 ` Ville Syrjälä
2020-02-21 15:40 ` Ville Syrjälä
2020-02-21 16:09 ` Ville Syrjälä
2020-02-21 16:09 ` Ville Syrjälä
2020-02-21 17:16 ` Daniel Vetter
2020-02-21 17:16 ` Daniel Vetter
2020-02-21 17:49 ` Ville Syrjälä
2020-02-21 17:49 ` Ville Syrjälä
2020-02-20 17:01 ` Emil Velikov
2020-02-20 17:01 ` [Intel-gfx] " Emil Velikov
2020-02-21 15:09 ` Linus Walleij
2020-02-21 15:09 ` [Intel-gfx] " Linus Walleij
2020-02-21 18:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220181442.GV2363188@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=sean@poorly.run \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.