From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 09/12] drm: Shrink drm_display_mode timings Date: Thu, 20 Feb 2020 20:47:02 +0200 [thread overview] Message-ID: <20200220184702.GJ13686@intel.com> (raw) In-Reply-To: <20200220181908.GX2363188@phenom.ffwll.local> On Thu, Feb 20, 2020 at 07:19:08PM +0100, Daniel Vetter wrote: > On Wed, Feb 19, 2020 at 10:35:41PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Store the timings (apart from the clock) as u16. The uapi mode > > struct already uses u16 for everything so using something bigger > > internally doesn't really help us. > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Makes sense I guess. This could mean some implicit pointer math is now no > longer auto-upgraded to big enough integers though ... u16 promotes to int. So can't really see how this would go wrong. Well, unless someone is using these to store some larger intermediate values. > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > > --- > > drivers/gpu/drm/drm_modes.c | 7 ------ > > include/drm/drm_modes.h | 46 ++++++++++++++++++------------------- > > 2 files changed, 23 insertions(+), 30 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index 0e7c9ba241c4..cc9fc52f9f7c 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -1917,13 +1917,6 @@ EXPORT_SYMBOL(drm_mode_create_from_cmdline_mode); > > void drm_mode_convert_to_umode(struct drm_mode_modeinfo *out, > > const struct drm_display_mode *in) > > { > > - WARN(in->hdisplay > USHRT_MAX || in->hsync_start > USHRT_MAX || > > - in->hsync_end > USHRT_MAX || in->htotal > USHRT_MAX || > > - in->hskew > USHRT_MAX || in->vdisplay > USHRT_MAX || > > - in->vsync_start > USHRT_MAX || in->vsync_end > USHRT_MAX || > > - in->vtotal > USHRT_MAX || in->vscan > USHRT_MAX, > > - "timing values too large for mode info\n"); > > - > > out->clock = in->clock; > > out->hdisplay = in->hdisplay; > > out->hsync_start = in->hsync_start; > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > > index b28c0234fcd7..b585074945b5 100644 > > --- a/include/drm/drm_modes.h > > +++ b/include/drm/drm_modes.h > > @@ -278,16 +278,16 @@ struct drm_display_mode { > > * Pixel clock in kHz. > > */ > > int clock; /* in kHz */ > > - int hdisplay; > > - int hsync_start; > > - int hsync_end; > > - int htotal; > > - int hskew; > > - int vdisplay; > > - int vsync_start; > > - int vsync_end; > > - int vtotal; > > - int vscan; > > + u16 hdisplay; > > + u16 hsync_start; > > + u16 hsync_end; > > + u16 htotal; > > + u16 hskew; > > + u16 vdisplay; > > + u16 vsync_start; > > + u16 vsync_end; > > + u16 vtotal; > > + u16 vscan; > > /** > > * @flags: > > * > > @@ -356,19 +356,19 @@ struct drm_display_mode { > > * difference is exactly a factor of 10. > > */ > > int crtc_clock; > > - int crtc_hdisplay; > > - int crtc_hblank_start; > > - int crtc_hblank_end; > > - int crtc_hsync_start; > > - int crtc_hsync_end; > > - int crtc_htotal; > > - int crtc_hskew; > > - int crtc_vdisplay; > > - int crtc_vblank_start; > > - int crtc_vblank_end; > > - int crtc_vsync_start; > > - int crtc_vsync_end; > > - int crtc_vtotal; > > + u16 crtc_hdisplay; > > + u16 crtc_hblank_start; > > + u16 crtc_hblank_end; > > + u16 crtc_hsync_start; > > + u16 crtc_hsync_end; > > + u16 crtc_htotal; > > + u16 crtc_hskew; > > + u16 crtc_vdisplay; > > + u16 crtc_vblank_start; > > + u16 crtc_vblank_end; > > + u16 crtc_vsync_start; > > + u16 crtc_vsync_end; > > + u16 crtc_vtotal; > > > > /** > > * @private_flags: > > -- > > 2.24.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 09/12] drm: Shrink drm_display_mode timings Date: Thu, 20 Feb 2020 20:47:02 +0200 [thread overview] Message-ID: <20200220184702.GJ13686@intel.com> (raw) In-Reply-To: <20200220181908.GX2363188@phenom.ffwll.local> On Thu, Feb 20, 2020 at 07:19:08PM +0100, Daniel Vetter wrote: > On Wed, Feb 19, 2020 at 10:35:41PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Store the timings (apart from the clock) as u16. The uapi mode > > struct already uses u16 for everything so using something bigger > > internally doesn't really help us. > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Makes sense I guess. This could mean some implicit pointer math is now no > longer auto-upgraded to big enough integers though ... u16 promotes to int. So can't really see how this would go wrong. Well, unless someone is using these to store some larger intermediate values. > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > > --- > > drivers/gpu/drm/drm_modes.c | 7 ------ > > include/drm/drm_modes.h | 46 ++++++++++++++++++------------------- > > 2 files changed, 23 insertions(+), 30 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index 0e7c9ba241c4..cc9fc52f9f7c 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -1917,13 +1917,6 @@ EXPORT_SYMBOL(drm_mode_create_from_cmdline_mode); > > void drm_mode_convert_to_umode(struct drm_mode_modeinfo *out, > > const struct drm_display_mode *in) > > { > > - WARN(in->hdisplay > USHRT_MAX || in->hsync_start > USHRT_MAX || > > - in->hsync_end > USHRT_MAX || in->htotal > USHRT_MAX || > > - in->hskew > USHRT_MAX || in->vdisplay > USHRT_MAX || > > - in->vsync_start > USHRT_MAX || in->vsync_end > USHRT_MAX || > > - in->vtotal > USHRT_MAX || in->vscan > USHRT_MAX, > > - "timing values too large for mode info\n"); > > - > > out->clock = in->clock; > > out->hdisplay = in->hdisplay; > > out->hsync_start = in->hsync_start; > > diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h > > index b28c0234fcd7..b585074945b5 100644 > > --- a/include/drm/drm_modes.h > > +++ b/include/drm/drm_modes.h > > @@ -278,16 +278,16 @@ struct drm_display_mode { > > * Pixel clock in kHz. > > */ > > int clock; /* in kHz */ > > - int hdisplay; > > - int hsync_start; > > - int hsync_end; > > - int htotal; > > - int hskew; > > - int vdisplay; > > - int vsync_start; > > - int vsync_end; > > - int vtotal; > > - int vscan; > > + u16 hdisplay; > > + u16 hsync_start; > > + u16 hsync_end; > > + u16 htotal; > > + u16 hskew; > > + u16 vdisplay; > > + u16 vsync_start; > > + u16 vsync_end; > > + u16 vtotal; > > + u16 vscan; > > /** > > * @flags: > > * > > @@ -356,19 +356,19 @@ struct drm_display_mode { > > * difference is exactly a factor of 10. > > */ > > int crtc_clock; > > - int crtc_hdisplay; > > - int crtc_hblank_start; > > - int crtc_hblank_end; > > - int crtc_hsync_start; > > - int crtc_hsync_end; > > - int crtc_htotal; > > - int crtc_hskew; > > - int crtc_vdisplay; > > - int crtc_vblank_start; > > - int crtc_vblank_end; > > - int crtc_vsync_start; > > - int crtc_vsync_end; > > - int crtc_vtotal; > > + u16 crtc_hdisplay; > > + u16 crtc_hblank_start; > > + u16 crtc_hblank_end; > > + u16 crtc_hsync_start; > > + u16 crtc_hsync_end; > > + u16 crtc_htotal; > > + u16 crtc_hskew; > > + u16 crtc_vdisplay; > > + u16 crtc_vblank_start; > > + u16 crtc_vblank_end; > > + u16 crtc_vsync_start; > > + u16 crtc_vsync_end; > > + u16 crtc_vtotal; > > > > /** > > * @private_flags: > > -- > > 2.24.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-20 18:47 UTC|newest] Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-19 20:35 [PATCH 00/12] drm: Put drm_display_mode on diet Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` [PATCH 01/12] drm: Nuke mode->hsync Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 10:55 ` Emil Velikov 2020-02-20 10:55 ` Emil Velikov 2020-02-21 16:04 ` Ville Syrjälä 2020-02-21 16:04 ` Ville Syrjälä 2020-02-21 16:55 ` Emil Velikov 2020-02-21 16:55 ` Emil Velikov 2020-02-19 20:35 ` [PATCH 02/12] drm/exynos: Use mode->clock instead of reverse calculating it from the vrefresh Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 10:56 ` Emil Velikov 2020-02-20 10:56 ` [Intel-gfx] " Emil Velikov 2020-02-25 0:49 ` Inki Dae 2020-02-19 20:35 ` [PATCH 03/12] drm/i915: Introduce some local intel_dp variables Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 11:13 ` Emil Velikov 2020-02-20 11:13 ` Emil Velikov 2020-02-19 20:35 ` [PATCH 04/12] drm: Nuke mode->vrefresh Ville Syrjala 2020-02-19 20:35 ` Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` Ville Syrjala 2020-02-20 12:00 ` Emil Velikov 2020-02-20 12:00 ` Emil Velikov 2020-02-20 12:00 ` [Intel-gfx] " Emil Velikov 2020-02-20 12:00 ` Emil Velikov 2020-02-22 12:32 ` Sam Ravnborg 2020-02-22 12:32 ` Sam Ravnborg 2020-02-22 12:32 ` [Intel-gfx] " Sam Ravnborg 2020-02-22 12:32 ` Sam Ravnborg 2020-02-24 13:14 ` Ville Syrjälä 2020-02-24 13:14 ` Ville Syrjälä 2020-02-24 13:14 ` [Intel-gfx] " Ville Syrjälä 2020-02-24 13:14 ` Ville Syrjälä 2020-02-24 14:14 ` Andrzej Hajda 2020-02-24 14:14 ` Andrzej Hajda 2020-02-24 14:14 ` [Intel-gfx] " Andrzej Hajda 2020-02-24 14:14 ` Andrzej Hajda 2020-02-25 11:21 ` Ville Syrjälä 2020-02-25 11:21 ` Ville Syrjälä 2020-02-25 11:21 ` [Intel-gfx] " Ville Syrjälä 2020-02-25 11:21 ` Ville Syrjälä 2020-02-25 15:19 ` Andrzej Hajda 2020-02-25 15:19 ` Andrzej Hajda 2020-02-25 15:19 ` [Intel-gfx] " Andrzej Hajda 2020-02-25 15:19 ` Andrzej Hajda 2020-02-25 15:45 ` Ville Syrjälä 2020-02-25 15:45 ` Ville Syrjälä 2020-02-25 15:45 ` [Intel-gfx] " Ville Syrjälä 2020-02-25 15:45 ` Ville Syrjälä 2020-02-25 19:27 ` Ville Syrjälä 2020-02-25 19:27 ` [Intel-gfx] " Ville Syrjälä 2020-02-25 19:27 ` Ville Syrjälä 2020-02-25 21:52 ` Linus Walleij 2020-02-25 21:52 ` Linus Walleij 2020-02-25 21:52 ` [Intel-gfx] " Linus Walleij 2020-02-25 21:52 ` Linus Walleij 2020-02-19 20:35 ` [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` Ville Syrjala 2020-02-20 11:24 ` Emil Velikov 2020-02-20 11:24 ` [Intel-gfx] " Emil Velikov 2020-02-20 11:24 ` Emil Velikov 2020-02-20 15:33 ` Ville Syrjälä 2020-02-20 15:33 ` [Intel-gfx] " Ville Syrjälä 2020-02-20 15:33 ` Ville Syrjälä 2020-02-20 18:14 ` Daniel Vetter 2020-02-20 18:14 ` [Intel-gfx] " Daniel Vetter 2020-02-20 18:14 ` Daniel Vetter 2020-02-19 20:35 ` [PATCH 06/12] drm: Shrink {width,height}_mm to u16 Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 12:48 ` Emil Velikov 2020-02-20 12:48 ` Emil Velikov 2020-02-19 20:35 ` [PATCH 07/12] drm: Shrink mode->type to u8 Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 18:17 ` Daniel Vetter 2020-02-20 18:17 ` Daniel Vetter 2020-02-19 20:35 ` [PATCH 08/12] drm: Make mode->flags u32 Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` [PATCH 09/12] drm: Shrink drm_display_mode timings Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 18:19 ` Daniel Vetter 2020-02-20 18:19 ` Daniel Vetter 2020-02-20 18:47 ` Ville Syrjälä [this message] 2020-02-20 18:47 ` Ville Syrjälä 2020-02-21 16:13 ` Sam Ravnborg 2020-02-21 16:13 ` [Intel-gfx] " Sam Ravnborg 2020-02-21 17:27 ` Sam Ravnborg 2020-02-21 17:27 ` [Intel-gfx] " Sam Ravnborg 2020-02-24 13:06 ` Ville Syrjälä 2020-02-24 13:06 ` [Intel-gfx] " Ville Syrjälä 2020-02-19 20:35 ` [PATCH 10/12] drm: Flatten drm_mode_vrefresh() Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-19 20:35 ` [PATCH 11/12] drm: Shrink mode->private_flags Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-21 16:15 ` Sam Ravnborg 2020-02-21 16:15 ` [Intel-gfx] " Sam Ravnborg 2020-02-24 13:23 ` Ville Syrjälä 2020-02-24 13:23 ` [Intel-gfx] " Ville Syrjälä 2020-02-19 20:35 ` [PATCH 12/12] drm: pahole struct drm_display_mode Ville Syrjala 2020-02-19 20:35 ` [Intel-gfx] " Ville Syrjala 2020-02-20 12:53 ` Emil Velikov 2020-02-20 12:53 ` [Intel-gfx] " Emil Velikov 2020-02-19 20:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Put drm_display_mode on diet Patchwork 2020-02-19 21:18 ` [PATCH 00/12] " Ville Syrjälä 2020-02-19 21:18 ` [Intel-gfx] " Ville Syrjälä 2020-02-19 21:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-02-20 13:21 ` [PATCH 00/12] " Emil Velikov 2020-02-20 13:21 ` [Intel-gfx] " Emil Velikov 2020-02-20 14:27 ` Ville Syrjälä 2020-02-20 14:27 ` [Intel-gfx] " Ville Syrjälä 2020-02-20 15:34 ` Ville Syrjälä 2020-02-20 15:34 ` Ville Syrjälä 2020-02-21 11:32 ` Jani Nikula 2020-02-21 11:32 ` Jani Nikula 2020-02-21 11:43 ` Ville Syrjälä 2020-02-21 11:43 ` Ville Syrjälä 2020-02-21 14:42 ` Daniel Vetter 2020-02-21 14:42 ` Daniel Vetter 2020-02-21 15:40 ` Ville Syrjälä 2020-02-21 15:40 ` Ville Syrjälä 2020-02-21 16:09 ` Ville Syrjälä 2020-02-21 16:09 ` Ville Syrjälä 2020-02-21 17:16 ` Daniel Vetter 2020-02-21 17:16 ` Daniel Vetter 2020-02-21 17:49 ` Ville Syrjälä 2020-02-21 17:49 ` Ville Syrjälä 2020-02-20 17:01 ` Emil Velikov 2020-02-20 17:01 ` [Intel-gfx] " Emil Velikov 2020-02-21 15:09 ` Linus Walleij 2020-02-21 15:09 ` [Intel-gfx] " Linus Walleij 2020-02-21 18:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200220184702.GJ13686@intel.com \ --to=ville.syrjala@linux.intel.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.