From: afzal mohammed <afzal.mohd.ma@gmail.com> To: Viresh Kumar <viresh.kumar@linaro.org>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Gregory Clement <gregory.clement@bootlin.com>, Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: afzal mohammed <afzal.mohd.ma@gmail.com> Subject: [PATCH v3] ARM: orion: replace setup_irq() by request_irq() Date: Sun, 1 Mar 2020 17:53:30 +0530 [thread overview] Message-ID: <20200301122330.4296-1-afzal.mohd.ma@gmail.com> (raw) request_irq() is preferred over setup_irq(). Invocations of setup_irq() occur after memory allocators are ready. Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized. Hence replace setup_irq() by request_irq(). [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com> --- Hi sub-arch maintainers, If the patch is okay, please take it thr' your tree. Regards afzal v3: * Split out from series, also split out from ARM patch to subarch level as Thomas suggested to take it thr' respective maintainers * Modify string displayed in case of error as suggested by Thomas * Re-arrange code as required to improve readability * Remove irrelevant parts from commit message & improve v2: * Replace pr_err("request_irq() on %s failed" by pr_err("%s: request_irq() failed" * Commit message massage arch/arm/plat-orion/time.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/arm/plat-orion/time.c b/arch/arm/plat-orion/time.c index ffb93db68e9c..509d4824dc1c 100644 --- a/arch/arm/plat-orion/time.c +++ b/arch/arm/plat-orion/time.c @@ -177,12 +177,6 @@ static irqreturn_t orion_timer_interrupt(int irq, void *dev_id) return IRQ_HANDLED; } -static struct irqaction orion_timer_irq = { - .name = "orion_tick", - .flags = IRQF_TIMER, - .handler = orion_timer_interrupt -}; - void __init orion_time_set_base(void __iomem *_timer_base) { @@ -236,7 +230,9 @@ orion_time_init(void __iomem *_bridge_base, u32 _bridge_timer1_clr_mask, /* * Setup clockevent timer (interrupt-driven). */ - setup_irq(irq, &orion_timer_irq); + if (request_irq(irq, orion_timer_interrupt, IRQF_TIMER, "orion_tick", + NULL)) + pr_err("Failed to request irq %u (orion_tick)\n", irq); orion_clkevt.cpumask = cpumask_of(0); clockevents_config_and_register(&orion_clkevt, tclk, 1, 0xfffffffe); } -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: afzal mohammed <afzal.mohd.ma@gmail.com> To: Viresh Kumar <viresh.kumar@linaro.org>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Gregory Clement <gregory.clement@bootlin.com>, Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: afzal mohammed <afzal.mohd.ma@gmail.com> Subject: [PATCH v3] ARM: orion: replace setup_irq() by request_irq() Date: Sun, 1 Mar 2020 17:53:30 +0530 [thread overview] Message-ID: <20200301122330.4296-1-afzal.mohd.ma@gmail.com> (raw) request_irq() is preferred over setup_irq(). Invocations of setup_irq() occur after memory allocators are ready. Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized. Hence replace setup_irq() by request_irq(). [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com> --- Hi sub-arch maintainers, If the patch is okay, please take it thr' your tree. Regards afzal v3: * Split out from series, also split out from ARM patch to subarch level as Thomas suggested to take it thr' respective maintainers * Modify string displayed in case of error as suggested by Thomas * Re-arrange code as required to improve readability * Remove irrelevant parts from commit message & improve v2: * Replace pr_err("request_irq() on %s failed" by pr_err("%s: request_irq() failed" * Commit message massage arch/arm/plat-orion/time.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/arm/plat-orion/time.c b/arch/arm/plat-orion/time.c index ffb93db68e9c..509d4824dc1c 100644 --- a/arch/arm/plat-orion/time.c +++ b/arch/arm/plat-orion/time.c @@ -177,12 +177,6 @@ static irqreturn_t orion_timer_interrupt(int irq, void *dev_id) return IRQ_HANDLED; } -static struct irqaction orion_timer_irq = { - .name = "orion_tick", - .flags = IRQF_TIMER, - .handler = orion_timer_interrupt -}; - void __init orion_time_set_base(void __iomem *_timer_base) { @@ -236,7 +230,9 @@ orion_time_init(void __iomem *_bridge_base, u32 _bridge_timer1_clr_mask, /* * Setup clockevent timer (interrupt-driven). */ - setup_irq(irq, &orion_timer_irq); + if (request_irq(irq, orion_timer_interrupt, IRQF_TIMER, "orion_tick", + NULL)) + pr_err("Failed to request irq %u (orion_tick)\n", irq); orion_clkevt.cpumask = cpumask_of(0); clockevents_config_and_register(&orion_clkevt, tclk, 1, 0xfffffffe); } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-03-01 12:23 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-01 12:23 afzal mohammed [this message] 2020-03-01 12:23 ` [PATCH v3] ARM: orion: replace setup_irq() by request_irq() afzal mohammed 2020-03-01 15:44 ` Andrew Lunn 2020-03-01 15:44 ` Andrew Lunn 2020-03-08 14:37 ` afzal mohammed 2020-03-08 14:37 ` afzal mohammed 2020-03-09 16:17 ` Gregory CLEMENT 2020-03-09 16:17 ` Gregory CLEMENT 2020-03-13 20:39 ` Gregory CLEMENT 2020-03-13 20:39 ` Gregory CLEMENT -- strict thread matches above, loose matches on Subject: below -- 2020-03-01 12:23 [PATCH v3] ARM: spear: " afzal mohammed 2020-03-01 12:23 ` afzal mohammed 2020-03-02 3:17 ` Viresh Kumar 2020-03-02 3:17 ` Viresh Kumar 2020-03-01 12:22 [PATCH v3] ARM: mmp: " afzal mohammed 2020-03-01 12:22 ` afzal mohammed 2020-03-08 14:53 ` afzal mohammed 2020-03-08 14:53 ` afzal mohammed 2020-03-08 16:19 ` Lubomir Rintel 2020-03-01 12:22 ` [PATCH v3] ARM: iop32x: " afzal mohammed 2020-03-01 12:22 ` afzal mohammed 2020-03-09 12:19 ` [PATCH v3] ARM: mmp: " afzal mohammed 2020-03-09 12:19 ` afzal mohammed 2020-03-01 12:21 [PATCH v3] ARM: ep93xx: Replace " afzal mohammed 2020-03-01 12:21 ` afzal mohammed 2020-03-01 16:21 ` Alexander Sverdlin 2020-03-01 16:21 ` Alexander Sverdlin 2020-03-01 12:19 [PATCH v3] ARM: OMAP: replace " afzal mohammed 2020-03-01 12:19 ` afzal mohammed 2020-03-04 16:34 ` Tony Lindgren 2020-03-04 16:34 ` Tony Lindgren 2020-03-13 15:45 ` [PATCH v3] ARM: " afzal mohammed 2020-03-13 15:45 ` afzal mohammed 2020-03-17 4:37 ` afzal mohammed 2020-03-17 4:37 ` afzal mohammed 2020-03-25 11:43 ` afzal mohammed 2020-03-25 11:43 ` afzal mohammed 2020-03-27 10:46 ` afzal mohammed 2020-03-27 10:46 ` afzal mohammed 2020-03-27 10:55 ` Arnd Bergmann 2020-03-27 10:55 ` Arnd Bergmann 2020-03-27 11:10 ` afzal mohammed 2020-03-27 11:10 ` afzal mohammed 2020-03-27 11:29 ` afzal mohammed 2020-03-27 11:29 ` afzal mohammed 2020-03-27 11:58 ` Arnd Bergmann 2020-03-27 11:58 ` Arnd Bergmann 2020-03-27 12:41 ` [PATCH v4 1/5] ARM: ep93xx: Replace " afzal mohammed 2020-03-27 12:41 ` afzal mohammed 2020-03-27 12:44 ` [PATCH v4 2/5] ARM: spear: replace " afzal mohammed 2020-03-27 12:44 ` afzal mohammed 2020-03-27 12:44 ` [PATCH v4 3/5] ARM: cns3xxx: " afzal mohammed 2020-03-27 12:44 ` afzal mohammed 2020-03-27 12:44 ` [PATCH v4 4/5] ARM: mmp: " afzal mohammed 2020-03-27 12:44 ` afzal mohammed 2020-03-27 12:44 ` [PATCH v4 5/5] ARM: iop32x: " afzal mohammed 2020-03-27 12:44 ` afzal mohammed 2020-03-27 12:53 ` [PATCH v3] ARM: " afzal mohammed 2020-03-27 12:53 ` afzal mohammed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200301122330.4296-1-afzal.mohd.ma@gmail.com \ --to=afzal.mohd.ma@gmail.com \ --cc=andrew@lunn.ch \ --cc=gregory.clement@bootlin.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=sebastian.hesselbarth@gmail.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.