From: Krzysztof Kozlowski <krzk@kernel.org> To: Anand Moon <linux.amoon@gmail.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Felipe Balbi <balbi@kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 0/3] Add support for suspend clk for Exynos5422 SoC Date: Wed, 4 Mar 2020 09:11:51 +0100 [thread overview] Message-ID: <20200304081151.GA17560@pi3> (raw) In-Reply-To: <20200301212019.2248-1-linux.amoon@gmail.com> On Sun, Mar 01, 2020 at 09:20:15PM +0000, Anand Moon wrote: > Seried build and tested on linux next-20200228. > > This patch series tries to enable suspend clk using > exynos dwc3 driver, for this I have added new > compatible string "samsung,exynos5420-dwusb3" > so that we could add new suspend clk in addition > to the core clk. exynos dwc3 driver will help > enable/disable these clk. That's not entirely correct. You enable there SCLK which is a "special clock", not a "suspend clock". You use word "suspend: in multiple places in commits making an impression that it is about some suspend clock... no, there is no suspend clock. There is however a clock which driver calls suspend_clk (but it is just some name) and it is being enabled for entire lifetime of device (so also during suspend). AFAIU, this is not needed for Exynos5422 but I am not sure. So please convince me... However I have still the same questions: 1. What problem are you trying to solve here? 2. Why this is needed? 3. What is fixed with this patch? Best regards, Krzysztof > > This series PatchV2. > --Added the clk names for exynos5420 compatible. > --Added missing support for Exyno5410 SoC suspend clock. > --Update the commit message to support suspend clk usages. > > --- > Long time ago I tried to add suspend clk for dwc3 phy > which was wrong appoch, see below. > > [0] https://lore.kernel.org/patchwork/patch/837635/ > [1] https://lore.kernel.org/patchwork/patch/837636/ > > Previous changes V3 (It was send with wrong Patch version) > [2] https://patchwork.kernel.org/cover/11373043/ > > -Anand > > Anand Moon (3): > devicetree: bindings: exynos: Add new compatible for Exynos5420 dwc3 > clocks support > ARM: dts: exynos: Add missing usbdrd3 suspend clk > usb: dwc3: exynos: Add support for Exynos5422 suspend clk > > Documentation/devicetree/bindings/usb/exynos-usb.txt | 5 ++++- > arch/arm/boot/dts/exynos5410.dtsi | 8 ++++---- > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++---- > arch/arm/boot/dts/exynos54xx.dtsi | 4 ++-- > drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++ > 5 files changed, 23 insertions(+), 11 deletions(-) > > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: Anand Moon <linux.amoon@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Felipe Balbi <balbi@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Rob Herring <robh+dt@kernel.org>, linux-arm-kernel@lists.infradead.org, Marek Szyprowski <m.szyprowski@samsung.com> Subject: Re: [PATCHv2 0/3] Add support for suspend clk for Exynos5422 SoC Date: Wed, 4 Mar 2020 09:11:51 +0100 [thread overview] Message-ID: <20200304081151.GA17560@pi3> (raw) In-Reply-To: <20200301212019.2248-1-linux.amoon@gmail.com> On Sun, Mar 01, 2020 at 09:20:15PM +0000, Anand Moon wrote: > Seried build and tested on linux next-20200228. > > This patch series tries to enable suspend clk using > exynos dwc3 driver, for this I have added new > compatible string "samsung,exynos5420-dwusb3" > so that we could add new suspend clk in addition > to the core clk. exynos dwc3 driver will help > enable/disable these clk. That's not entirely correct. You enable there SCLK which is a "special clock", not a "suspend clock". You use word "suspend: in multiple places in commits making an impression that it is about some suspend clock... no, there is no suspend clock. There is however a clock which driver calls suspend_clk (but it is just some name) and it is being enabled for entire lifetime of device (so also during suspend). AFAIU, this is not needed for Exynos5422 but I am not sure. So please convince me... However I have still the same questions: 1. What problem are you trying to solve here? 2. Why this is needed? 3. What is fixed with this patch? Best regards, Krzysztof > > This series PatchV2. > --Added the clk names for exynos5420 compatible. > --Added missing support for Exyno5410 SoC suspend clock. > --Update the commit message to support suspend clk usages. > > --- > Long time ago I tried to add suspend clk for dwc3 phy > which was wrong appoch, see below. > > [0] https://lore.kernel.org/patchwork/patch/837635/ > [1] https://lore.kernel.org/patchwork/patch/837636/ > > Previous changes V3 (It was send with wrong Patch version) > [2] https://patchwork.kernel.org/cover/11373043/ > > -Anand > > Anand Moon (3): > devicetree: bindings: exynos: Add new compatible for Exynos5420 dwc3 > clocks support > ARM: dts: exynos: Add missing usbdrd3 suspend clk > usb: dwc3: exynos: Add support for Exynos5422 suspend clk > > Documentation/devicetree/bindings/usb/exynos-usb.txt | 5 ++++- > arch/arm/boot/dts/exynos5410.dtsi | 8 ++++---- > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++---- > arch/arm/boot/dts/exynos54xx.dtsi | 4 ++-- > drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++ > 5 files changed, 23 insertions(+), 11 deletions(-) > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-04 8:11 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-01 21:20 [PATCHv2 0/3] Add support for suspend clk for Exynos5422 SoC Anand Moon 2020-03-01 21:20 ` Anand Moon 2020-03-01 21:20 ` [PATCHv2 1/3] devicetree: bindings: exynos: Add new compatible for Exynos5420 dwc3 clocks support Anand Moon 2020-03-01 21:20 ` Anand Moon 2020-03-03 9:46 ` Krzysztof Kozlowski 2020-03-03 9:46 ` Krzysztof Kozlowski 2020-03-05 4:07 ` Anand Moon 2020-03-05 4:07 ` Anand Moon 2020-03-04 17:00 ` Rob Herring 2020-03-04 17:00 ` Rob Herring 2020-03-15 9:28 ` Felipe Balbi 2020-03-15 9:28 ` Felipe Balbi 2020-03-01 21:20 ` [PATCHv2 2/3] ARM: dts: exynos: Add missing usbdrd3 suspend clk Anand Moon 2020-03-01 21:20 ` Anand Moon 2020-03-01 21:20 ` [PATCHv2 3/3] usb: dwc3: exynos: Add support for Exynos5422 " Anand Moon 2020-03-01 21:20 ` Anand Moon 2020-03-04 8:11 ` Krzysztof Kozlowski [this message] 2020-03-04 8:11 ` [PATCHv2 0/3] Add support for suspend clk for Exynos5422 SoC Krzysztof Kozlowski 2020-03-04 17:53 ` Anand Moon 2020-03-04 17:53 ` Anand Moon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200304081151.GA17560@pi3 \ --to=krzk@kernel.org \ --cc=b.zolnierkie@samsung.com \ --cc=balbi@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux.amoon@gmail.com \ --cc=m.szyprowski@samsung.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.