From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-i2c@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-i3c@lists.infradead.org, "Kieran Bingham" <kieran@ksquared.org.uk>, "Niklas Söderlund" <niklas.soderlund@ragnatech.se>, "Luca Ceresoli" <luca@lucaceresoli.net>, "Jacopo Mondi" <jacopo@jmondi.org>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, "Vladimir Zapolskiy" <vz@mleia.com>, linux-kernel@vger.kernel.org, "Wolfram Sang" <wsa+renesas@sang-engineering.com>, "Geert Uytterhoeven" <geert+renesas@glider.be> Subject: [RFC PATCH v2 1/6] i2c: use DEFINE for the dummy driver name Date: Wed, 18 Mar 2020 16:00:54 +0100 [thread overview] Message-ID: <20200318150059.21714-2-wsa+renesas@sang-engineering.com> (raw) In-Reply-To: <20200318150059.21714-1-wsa+renesas@sang-engineering.com> We use it in multiple places, so make sure it is consistent whenever we need to change it. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/i2c/i2c-core-base.c | 8 ++++---- drivers/i2c/i2c-core.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index cefad0881942..3d7b8a00a7d9 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -853,7 +853,7 @@ EXPORT_SYMBOL_GPL(i2c_unregister_device); static const struct i2c_device_id dummy_id[] = { - { "dummy", 0 }, + { I2C_DUMMY_DRV_NAME, 0 }, { }, }; @@ -869,7 +869,7 @@ static int dummy_remove(struct i2c_client *client) } static struct i2c_driver dummy_driver = { - .driver.name = "dummy", + .driver.name = I2C_DUMMY_DRV_NAME, .probe = dummy_probe, .remove = dummy_remove, .id_table = dummy_id, @@ -896,7 +896,7 @@ static struct i2c_driver dummy_driver = { struct i2c_client *i2c_new_dummy_device(struct i2c_adapter *adapter, u16 address) { struct i2c_board_info info = { - I2C_BOARD_INFO("dummy", address), + I2C_BOARD_INFO(I2C_DUMMY_DRV_NAME, address), }; return i2c_new_client_device(adapter, &info); @@ -1487,7 +1487,7 @@ static void i2c_do_del_adapter(struct i2c_driver *driver, static int __unregister_client(struct device *dev, void *dummy) { struct i2c_client *client = i2c_verify_client(dev); - if (client && strcmp(client->name, "dummy")) + if (client && strcmp(client->name, I2C_DUMMY_DRV_NAME)) i2c_unregister_device(client); return 0; } diff --git a/drivers/i2c/i2c-core.h b/drivers/i2c/i2c-core.h index 517d98be68d2..fb89fabf84d3 100644 --- a/drivers/i2c/i2c-core.h +++ b/drivers/i2c/i2c-core.h @@ -22,6 +22,8 @@ int i2c_check_7bit_addr_validity_strict(unsigned short addr); int i2c_dev_irq_from_resources(const struct resource *resources, unsigned int num_resources); +#define I2C_DUMMY_DRV_NAME "dummy" + /* * We only allow atomic transfers for very late communication, e.g. to send * the powerdown command to a PMIC. Atomic transfers are a corner case and not -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-i2c@vger.kernel.org Cc: "Jacopo Mondi" <jacopo@jmondi.org>, "Niklas Söderlund" <niklas.soderlund@ragnatech.se>, "Geert Uytterhoeven" <geert+renesas@glider.be>, "Wolfram Sang" <wsa+renesas@sang-engineering.com>, linux-kernel@vger.kernel.org, "Vladimir Zapolskiy" <vz@mleia.com>, linux-renesas-soc@vger.kernel.org, "Kieran Bingham" <kieran@bingham.xyz>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, "Luca Ceresoli" <luca@lucaceresoli.net>, linux-i3c@lists.infradead.org Subject: [RFC PATCH v2 1/6] i2c: use DEFINE for the dummy driver name Date: Wed, 18 Mar 2020 16:00:54 +0100 [thread overview] Message-ID: <20200318150059.21714-2-wsa+renesas@sang-engineering.com> (raw) In-Reply-To: <20200318150059.21714-1-wsa+renesas@sang-engineering.com> We use it in multiple places, so make sure it is consistent whenever we need to change it. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/i2c/i2c-core-base.c | 8 ++++---- drivers/i2c/i2c-core.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index cefad0881942..3d7b8a00a7d9 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -853,7 +853,7 @@ EXPORT_SYMBOL_GPL(i2c_unregister_device); static const struct i2c_device_id dummy_id[] = { - { "dummy", 0 }, + { I2C_DUMMY_DRV_NAME, 0 }, { }, }; @@ -869,7 +869,7 @@ static int dummy_remove(struct i2c_client *client) } static struct i2c_driver dummy_driver = { - .driver.name = "dummy", + .driver.name = I2C_DUMMY_DRV_NAME, .probe = dummy_probe, .remove = dummy_remove, .id_table = dummy_id, @@ -896,7 +896,7 @@ static struct i2c_driver dummy_driver = { struct i2c_client *i2c_new_dummy_device(struct i2c_adapter *adapter, u16 address) { struct i2c_board_info info = { - I2C_BOARD_INFO("dummy", address), + I2C_BOARD_INFO(I2C_DUMMY_DRV_NAME, address), }; return i2c_new_client_device(adapter, &info); @@ -1487,7 +1487,7 @@ static void i2c_do_del_adapter(struct i2c_driver *driver, static int __unregister_client(struct device *dev, void *dummy) { struct i2c_client *client = i2c_verify_client(dev); - if (client && strcmp(client->name, "dummy")) + if (client && strcmp(client->name, I2C_DUMMY_DRV_NAME)) i2c_unregister_device(client); return 0; } diff --git a/drivers/i2c/i2c-core.h b/drivers/i2c/i2c-core.h index 517d98be68d2..fb89fabf84d3 100644 --- a/drivers/i2c/i2c-core.h +++ b/drivers/i2c/i2c-core.h @@ -22,6 +22,8 @@ int i2c_check_7bit_addr_validity_strict(unsigned short addr); int i2c_dev_irq_from_resources(const struct resource *resources, unsigned int num_resources); +#define I2C_DUMMY_DRV_NAME "dummy" + /* * We only allow atomic transfers for very late communication, e.g. to send * the powerdown command to a PMIC. Atomic transfers are a corner case and not -- 2.20.1 _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-03-18 15:01 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-18 15:00 [RFC PATCH v2 0/6] i2c: of: reserve unknown and ancillary addresses Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang [this message] 2020-03-18 15:00 ` [RFC PATCH v2 1/6] i2c: use DEFINE for the dummy driver name Wolfram Sang 2020-04-15 8:09 ` Kieran Bingham 2020-04-15 8:09 ` Kieran Bingham 2020-03-18 15:00 ` [RFC PATCH v2 2/6] i2c: allow DT nodes without 'compatible' Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-04-10 13:49 ` Luca Ceresoli 2020-04-10 13:49 ` Luca Ceresoli 2020-04-15 7:59 ` Wolfram Sang 2020-04-15 7:59 ` Wolfram Sang 2020-04-15 8:07 ` Kieran Bingham 2020-04-15 8:07 ` Kieran Bingham 2020-04-15 8:16 ` Wolfram Sang 2020-04-15 8:16 ` Wolfram Sang 2020-04-15 8:38 ` Kieran Bingham 2020-04-15 8:38 ` Kieran Bingham 2020-04-16 14:53 ` Luca Ceresoli 2020-04-16 14:53 ` Luca Ceresoli 2020-04-15 8:48 ` Kieran Bingham 2020-04-15 8:48 ` Kieran Bingham 2020-04-15 9:46 ` Wolfram Sang 2020-04-15 9:46 ` Wolfram Sang 2020-03-18 15:00 ` [RFC PATCH v2 3/6] i2c: of: remove superfluous parameter from exported function Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-03-19 12:41 ` Boris Brezillon 2020-03-19 12:41 ` Boris Brezillon 2020-04-15 8:13 ` Kieran Bingham 2020-04-15 8:13 ` Kieran Bingham 2020-03-18 15:00 ` [RFC PATCH v2 4/6] i2c: of: error message unification Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-04-10 17:02 ` Luca Ceresoli 2020-04-10 17:02 ` Luca Ceresoli 2020-04-15 8:17 ` Kieran Bingham 2020-04-15 8:17 ` Kieran Bingham 2020-04-15 8:50 ` Kieran Bingham 2020-04-15 8:50 ` Kieran Bingham 2020-03-18 15:00 ` [RFC PATCH v2 5/6] i2c: of: mark a whole array of regs as reserved Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-04-10 17:05 ` Luca Ceresoli 2020-04-10 17:05 ` Luca Ceresoli 2020-04-13 9:55 ` Luca Ceresoli 2020-04-13 9:55 ` Luca Ceresoli 2020-04-15 8:10 ` Wolfram Sang 2020-04-15 8:10 ` Wolfram Sang 2020-04-15 10:07 ` Luca Ceresoli 2020-04-15 10:07 ` Luca Ceresoli 2020-03-18 15:00 ` [RFC PATCH v2 6/6] i2c: core: hand over reserved devices when requesting ancillary addresses Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-04-15 10:07 ` Luca Ceresoli 2020-04-15 10:07 ` Luca Ceresoli 2020-03-28 3:50 ` [RFC PATCH v2 0/6] i2c: of: reserve unknown and " Wolfram Sang 2020-03-28 3:50 ` Wolfram Sang 2020-04-15 8:27 ` Wolfram Sang 2020-04-15 8:27 ` Wolfram Sang 2020-04-15 8:35 ` Kieran Bingham 2020-04-15 8:35 ` Kieran Bingham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200318150059.21714-2-wsa+renesas@sang-engineering.com \ --to=wsa+renesas@sang-engineering.com \ --cc=geert+renesas@glider.be \ --cc=jacopo@jmondi.org \ --cc=kieran@ksquared.org.uk \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=luca@lucaceresoli.net \ --cc=niklas.soderlund@ragnatech.se \ --cc=vz@mleia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.