From: Kieran Bingham <kieran@ksquared.org.uk> To: Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-i2c@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-i3c@lists.infradead.org, "Niklas Söderlund" <niklas.soderlund@ragnatech.se>, "Luca Ceresoli" <luca@lucaceresoli.net>, "Jacopo Mondi" <jacopo@jmondi.org>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, "Vladimir Zapolskiy" <vz@mleia.com>, linux-kernel@vger.kernel.org, "Geert Uytterhoeven" <geert+renesas@glider.be> Subject: Re: [RFC PATCH v2 3/6] i2c: of: remove superfluous parameter from exported function Date: Wed, 15 Apr 2020 09:13:16 +0100 [thread overview] Message-ID: <24725e14-232c-49be-3b11-dc8afe685c43@bingham.xyz> (raw) In-Reply-To: <20200318150059.21714-4-wsa+renesas@sang-engineering.com> Hi Wolfram, On 18/03/2020 15:00, Wolfram Sang wrote: > 'dev' is only used for printing an error message. However, that > information is not needed because '%pOF' fully describes the location of > the error. Drop the 'dev' and remove the superfluous parameter. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/i2c/i2c-core-of.c | 7 +++---- > drivers/i3c/master.c | 2 +- > include/linux/i2c.h | 6 ++---- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c > index d8d111ad6c85..710704cd583e 100644 > --- a/drivers/i2c/i2c-core-of.c > +++ b/drivers/i2c/i2c-core-of.c > @@ -19,8 +19,7 @@ > > #include "i2c-core.h" > > -int of_i2c_get_board_info(struct device *dev, struct device_node *node, > - struct i2c_board_info *info) > +int of_i2c_get_board_info(struct device_node *node, struct i2c_board_info *info) > { > u32 addr; > int ret; > @@ -29,7 +28,7 @@ int of_i2c_get_board_info(struct device *dev, struct device_node *node, > > ret = of_property_read_u32(node, "reg", &addr); > if (ret) { > - dev_err(dev, "of_i2c: invalid reg on %pOF\n", node); > + pr_err("of_i2c: invalid reg on %pOF\n", node); > return ret; > } > > @@ -69,7 +68,7 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap, > > dev_dbg(&adap->dev, "of_i2c: register %pOF\n", node); > > - ret = of_i2c_get_board_info(&adap->dev, node, &info); > + ret = of_i2c_get_board_info(node, &info); > if (ret) > return ERR_PTR(ret); > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index 7f8f896fa0c3..cc0549a9fc64 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c > @@ -1943,7 +1943,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, > if (!boardinfo) > return -ENOMEM; > > - ret = of_i2c_get_board_info(dev, node, &boardinfo->base); > + ret = of_i2c_get_board_info(node, &boardinfo->base); > if (ret) > return ret; > > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index f834687989f7..d84aaf0d83d5 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -942,8 +942,7 @@ const struct of_device_id > *i2c_of_match_device(const struct of_device_id *matches, > struct i2c_client *client); > > -int of_i2c_get_board_info(struct device *dev, struct device_node *node, > - struct i2c_board_info *info); > +int of_i2c_get_board_info(struct device_node *node, struct i2c_board_info *info); > > #else > > @@ -969,8 +968,7 @@ static inline const struct of_device_id > return NULL; > } > > -static inline int of_i2c_get_board_info(struct device *dev, > - struct device_node *node, > +static inline int of_i2c_get_board_info(struct device_node *node, > struct i2c_board_info *info) > { > return -ENOTSUPP; >
WARNING: multiple messages have this Message-ID (diff)
From: Kieran Bingham <kieran@bingham.xyz> To: Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-i2c@vger.kernel.org Cc: "Jacopo Mondi" <jacopo@jmondi.org>, "Geert Uytterhoeven" <geert+renesas@glider.be>, linux-kernel@vger.kernel.org, "Vladimir Zapolskiy" <vz@mleia.com>, linux-renesas-soc@vger.kernel.org, "Luca Ceresoli" <luca@lucaceresoli.net>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, "Niklas Söderlund" <niklas.soderlund@ragnatech.se>, linux-i3c@lists.infradead.org Subject: Re: [RFC PATCH v2 3/6] i2c: of: remove superfluous parameter from exported function Date: Wed, 15 Apr 2020 09:13:16 +0100 [thread overview] Message-ID: <24725e14-232c-49be-3b11-dc8afe685c43@bingham.xyz> (raw) In-Reply-To: <20200318150059.21714-4-wsa+renesas@sang-engineering.com> Hi Wolfram, On 18/03/2020 15:00, Wolfram Sang wrote: > 'dev' is only used for printing an error message. However, that > information is not needed because '%pOF' fully describes the location of > the error. Drop the 'dev' and remove the superfluous parameter. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/i2c/i2c-core-of.c | 7 +++---- > drivers/i3c/master.c | 2 +- > include/linux/i2c.h | 6 ++---- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c > index d8d111ad6c85..710704cd583e 100644 > --- a/drivers/i2c/i2c-core-of.c > +++ b/drivers/i2c/i2c-core-of.c > @@ -19,8 +19,7 @@ > > #include "i2c-core.h" > > -int of_i2c_get_board_info(struct device *dev, struct device_node *node, > - struct i2c_board_info *info) > +int of_i2c_get_board_info(struct device_node *node, struct i2c_board_info *info) > { > u32 addr; > int ret; > @@ -29,7 +28,7 @@ int of_i2c_get_board_info(struct device *dev, struct device_node *node, > > ret = of_property_read_u32(node, "reg", &addr); > if (ret) { > - dev_err(dev, "of_i2c: invalid reg on %pOF\n", node); > + pr_err("of_i2c: invalid reg on %pOF\n", node); > return ret; > } > > @@ -69,7 +68,7 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap, > > dev_dbg(&adap->dev, "of_i2c: register %pOF\n", node); > > - ret = of_i2c_get_board_info(&adap->dev, node, &info); > + ret = of_i2c_get_board_info(node, &info); > if (ret) > return ERR_PTR(ret); > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index 7f8f896fa0c3..cc0549a9fc64 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c > @@ -1943,7 +1943,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, > if (!boardinfo) > return -ENOMEM; > > - ret = of_i2c_get_board_info(dev, node, &boardinfo->base); > + ret = of_i2c_get_board_info(node, &boardinfo->base); > if (ret) > return ret; > > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index f834687989f7..d84aaf0d83d5 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -942,8 +942,7 @@ const struct of_device_id > *i2c_of_match_device(const struct of_device_id *matches, > struct i2c_client *client); > > -int of_i2c_get_board_info(struct device *dev, struct device_node *node, > - struct i2c_board_info *info); > +int of_i2c_get_board_info(struct device_node *node, struct i2c_board_info *info); > > #else > > @@ -969,8 +968,7 @@ static inline const struct of_device_id > return NULL; > } > > -static inline int of_i2c_get_board_info(struct device *dev, > - struct device_node *node, > +static inline int of_i2c_get_board_info(struct device_node *node, > struct i2c_board_info *info) > { > return -ENOTSUPP; > _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-04-15 8:13 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-18 15:00 [RFC PATCH v2 0/6] i2c: of: reserve unknown and ancillary addresses Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-03-18 15:00 ` [RFC PATCH v2 1/6] i2c: use DEFINE for the dummy driver name Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-04-15 8:09 ` Kieran Bingham 2020-04-15 8:09 ` Kieran Bingham 2020-03-18 15:00 ` [RFC PATCH v2 2/6] i2c: allow DT nodes without 'compatible' Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-04-10 13:49 ` Luca Ceresoli 2020-04-10 13:49 ` Luca Ceresoli 2020-04-15 7:59 ` Wolfram Sang 2020-04-15 7:59 ` Wolfram Sang 2020-04-15 8:07 ` Kieran Bingham 2020-04-15 8:07 ` Kieran Bingham 2020-04-15 8:16 ` Wolfram Sang 2020-04-15 8:16 ` Wolfram Sang 2020-04-15 8:38 ` Kieran Bingham 2020-04-15 8:38 ` Kieran Bingham 2020-04-16 14:53 ` Luca Ceresoli 2020-04-16 14:53 ` Luca Ceresoli 2020-04-15 8:48 ` Kieran Bingham 2020-04-15 8:48 ` Kieran Bingham 2020-04-15 9:46 ` Wolfram Sang 2020-04-15 9:46 ` Wolfram Sang 2020-03-18 15:00 ` [RFC PATCH v2 3/6] i2c: of: remove superfluous parameter from exported function Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-03-19 12:41 ` Boris Brezillon 2020-03-19 12:41 ` Boris Brezillon 2020-04-15 8:13 ` Kieran Bingham [this message] 2020-04-15 8:13 ` Kieran Bingham 2020-03-18 15:00 ` [RFC PATCH v2 4/6] i2c: of: error message unification Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-04-10 17:02 ` Luca Ceresoli 2020-04-10 17:02 ` Luca Ceresoli 2020-04-15 8:17 ` Kieran Bingham 2020-04-15 8:17 ` Kieran Bingham 2020-04-15 8:50 ` Kieran Bingham 2020-04-15 8:50 ` Kieran Bingham 2020-03-18 15:00 ` [RFC PATCH v2 5/6] i2c: of: mark a whole array of regs as reserved Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-04-10 17:05 ` Luca Ceresoli 2020-04-10 17:05 ` Luca Ceresoli 2020-04-13 9:55 ` Luca Ceresoli 2020-04-13 9:55 ` Luca Ceresoli 2020-04-15 8:10 ` Wolfram Sang 2020-04-15 8:10 ` Wolfram Sang 2020-04-15 10:07 ` Luca Ceresoli 2020-04-15 10:07 ` Luca Ceresoli 2020-03-18 15:00 ` [RFC PATCH v2 6/6] i2c: core: hand over reserved devices when requesting ancillary addresses Wolfram Sang 2020-03-18 15:00 ` Wolfram Sang 2020-04-15 10:07 ` Luca Ceresoli 2020-04-15 10:07 ` Luca Ceresoli 2020-03-28 3:50 ` [RFC PATCH v2 0/6] i2c: of: reserve unknown and " Wolfram Sang 2020-03-28 3:50 ` Wolfram Sang 2020-04-15 8:27 ` Wolfram Sang 2020-04-15 8:27 ` Wolfram Sang 2020-04-15 8:35 ` Kieran Bingham 2020-04-15 8:35 ` Kieran Bingham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=24725e14-232c-49be-3b11-dc8afe685c43@bingham.xyz \ --to=kieran@ksquared.org.uk \ --cc=geert+renesas@glider.be \ --cc=jacopo@jmondi.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=luca@lucaceresoli.net \ --cc=niklas.soderlund@ragnatech.se \ --cc=vz@mleia.com \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.