From: Luca Ceresoli <luca@lucaceresoli.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org, linux-i3c@lists.infradead.org,
"Kieran Bingham" <kieran@ksquared.org.uk>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Jacopo Mondi" <jacopo@jmondi.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
linux-kernel@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>
Subject: Re: [RFC PATCH v2 4/6] i2c: of: error message unification
Date: Fri, 10 Apr 2020 19:02:04 +0200 [thread overview]
Message-ID: <d8f9b77f-9530-bbd6-3323-a0170bba5e6c@lucaceresoli.net> (raw)
In-Reply-To: <20200318150059.21714-5-wsa+renesas@sang-engineering.com>
Hi,
On 18/03/20 16:00, Wolfram Sang wrote:
> - don't prefix the device if %pOF is provided. That information is
> enough.
> - move the prefix to pr_fmt
> - change prefix from "of_i2c" to "i2c_of" because the code was moved
> out of the of-domain long ago
> - drop error string for callers of of_i2c_register_device because it
> already reports enough (thanks to Tang Bin for the report!)
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca@lucaceresoli.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org
Cc: "Jacopo Mondi" <jacopo@jmondi.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org, "Vladimir Zapolskiy" <vz@mleia.com>,
linux-renesas-soc@vger.kernel.org,
"Kieran Bingham" <kieran@bingham.xyz>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
linux-i3c@lists.infradead.org
Subject: Re: [RFC PATCH v2 4/6] i2c: of: error message unification
Date: Fri, 10 Apr 2020 19:02:04 +0200 [thread overview]
Message-ID: <d8f9b77f-9530-bbd6-3323-a0170bba5e6c@lucaceresoli.net> (raw)
In-Reply-To: <20200318150059.21714-5-wsa+renesas@sang-engineering.com>
Hi,
On 18/03/20 16:00, Wolfram Sang wrote:
> - don't prefix the device if %pOF is provided. That information is
> enough.
> - move the prefix to pr_fmt
> - change prefix from "of_i2c" to "i2c_of" because the code was moved
> out of the of-domain long ago
> - drop error string for callers of of_i2c_register_device because it
> already reports enough (thanks to Tang Bin for the report!)
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-04-10 17:02 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 15:00 [RFC PATCH v2 0/6] i2c: of: reserve unknown and ancillary addresses Wolfram Sang
2020-03-18 15:00 ` Wolfram Sang
2020-03-18 15:00 ` [RFC PATCH v2 1/6] i2c: use DEFINE for the dummy driver name Wolfram Sang
2020-03-18 15:00 ` Wolfram Sang
2020-04-15 8:09 ` Kieran Bingham
2020-04-15 8:09 ` Kieran Bingham
2020-03-18 15:00 ` [RFC PATCH v2 2/6] i2c: allow DT nodes without 'compatible' Wolfram Sang
2020-03-18 15:00 ` Wolfram Sang
2020-04-10 13:49 ` Luca Ceresoli
2020-04-10 13:49 ` Luca Ceresoli
2020-04-15 7:59 ` Wolfram Sang
2020-04-15 7:59 ` Wolfram Sang
2020-04-15 8:07 ` Kieran Bingham
2020-04-15 8:07 ` Kieran Bingham
2020-04-15 8:16 ` Wolfram Sang
2020-04-15 8:16 ` Wolfram Sang
2020-04-15 8:38 ` Kieran Bingham
2020-04-15 8:38 ` Kieran Bingham
2020-04-16 14:53 ` Luca Ceresoli
2020-04-16 14:53 ` Luca Ceresoli
2020-04-15 8:48 ` Kieran Bingham
2020-04-15 8:48 ` Kieran Bingham
2020-04-15 9:46 ` Wolfram Sang
2020-04-15 9:46 ` Wolfram Sang
2020-03-18 15:00 ` [RFC PATCH v2 3/6] i2c: of: remove superfluous parameter from exported function Wolfram Sang
2020-03-18 15:00 ` Wolfram Sang
2020-03-19 12:41 ` Boris Brezillon
2020-03-19 12:41 ` Boris Brezillon
2020-04-15 8:13 ` Kieran Bingham
2020-04-15 8:13 ` Kieran Bingham
2020-03-18 15:00 ` [RFC PATCH v2 4/6] i2c: of: error message unification Wolfram Sang
2020-03-18 15:00 ` Wolfram Sang
2020-04-10 17:02 ` Luca Ceresoli [this message]
2020-04-10 17:02 ` Luca Ceresoli
2020-04-15 8:17 ` Kieran Bingham
2020-04-15 8:17 ` Kieran Bingham
2020-04-15 8:50 ` Kieran Bingham
2020-04-15 8:50 ` Kieran Bingham
2020-03-18 15:00 ` [RFC PATCH v2 5/6] i2c: of: mark a whole array of regs as reserved Wolfram Sang
2020-03-18 15:00 ` Wolfram Sang
2020-04-10 17:05 ` Luca Ceresoli
2020-04-10 17:05 ` Luca Ceresoli
2020-04-13 9:55 ` Luca Ceresoli
2020-04-13 9:55 ` Luca Ceresoli
2020-04-15 8:10 ` Wolfram Sang
2020-04-15 8:10 ` Wolfram Sang
2020-04-15 10:07 ` Luca Ceresoli
2020-04-15 10:07 ` Luca Ceresoli
2020-03-18 15:00 ` [RFC PATCH v2 6/6] i2c: core: hand over reserved devices when requesting ancillary addresses Wolfram Sang
2020-03-18 15:00 ` Wolfram Sang
2020-04-15 10:07 ` Luca Ceresoli
2020-04-15 10:07 ` Luca Ceresoli
2020-03-28 3:50 ` [RFC PATCH v2 0/6] i2c: of: reserve unknown and " Wolfram Sang
2020-03-28 3:50 ` Wolfram Sang
2020-04-15 8:27 ` Wolfram Sang
2020-04-15 8:27 ` Wolfram Sang
2020-04-15 8:35 ` Kieran Bingham
2020-04-15 8:35 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8f9b77f-9530-bbd6-3323-a0170bba5e6c@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=geert+renesas@glider.be \
--cc=jacopo@jmondi.org \
--cc=kieran@ksquared.org.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=vz@mleia.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.