From: Nathan Chancellor <natechancellor@gmail.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 3/9] staging: media: atomisp: annotate an unused function Date: Fri, 29 May 2020 19:56:49 -0700 [thread overview] Message-ID: <20200530025649.GB1367069@ubuntu-s3-xlarge-x86> (raw) In-Reply-To: <20200529200031.4117841-3-arnd@arndb.de> On Fri, May 29, 2020 at 10:00:25PM +0200, Arnd Bergmann wrote: > atomisp_mrfld_power() has no more callers and produces > a warning: > > drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: error: unused function 'atomisp_mrfld_power' [-Werror,-Wunused-function] > > Mark the function as unused while the PM code is being > debugged, expecting that it will be used again in the > future and should not just be removed. > > Fixes: 95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Mauro fixed this in his experimental branch: https://git.linuxtv.org/mchehab/experimental.git/commit/?id=dbcee8118fc9283401df9dbe8ba03ab9d17433ff > --- > drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > index 694268d133c0..10abb35ba0e0 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > @@ -761,7 +761,8 @@ static void punit_ddr_dvfs_enable(bool enable) > pr_info("DDR DVFS, door bell is not cleared within 3ms\n"); > } > > -static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) > +static __attribute__((unused)) int > +atomisp_mrfld_power(struct atomisp_device *isp, bool enable) > { > unsigned long timeout; > u32 val = enable ? MRFLD_ISPSSPM0_IUNIT_POWER_ON : > -- > 2.26.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com> To: Arnd Bergmann <arnd@arndb.de> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Sakari Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org Subject: Re: [PATCH 3/9] staging: media: atomisp: annotate an unused function Date: Fri, 29 May 2020 19:56:49 -0700 [thread overview] Message-ID: <20200530025649.GB1367069@ubuntu-s3-xlarge-x86> (raw) In-Reply-To: <20200529200031.4117841-3-arnd@arndb.de> On Fri, May 29, 2020 at 10:00:25PM +0200, Arnd Bergmann wrote: > atomisp_mrfld_power() has no more callers and produces > a warning: > > drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: error: unused function 'atomisp_mrfld_power' [-Werror,-Wunused-function] > > Mark the function as unused while the PM code is being > debugged, expecting that it will be used again in the > future and should not just be removed. > > Fixes: 95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Mauro fixed this in his experimental branch: https://git.linuxtv.org/mchehab/experimental.git/commit/?id=dbcee8118fc9283401df9dbe8ba03ab9d17433ff > --- > drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > index 694268d133c0..10abb35ba0e0 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > @@ -761,7 +761,8 @@ static void punit_ddr_dvfs_enable(bool enable) > pr_info("DDR DVFS, door bell is not cleared within 3ms\n"); > } > > -static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) > +static __attribute__((unused)) int > +atomisp_mrfld_power(struct atomisp_device *isp, bool enable) > { > unsigned long timeout; > u32 val = enable ? MRFLD_ISPSSPM0_IUNIT_POWER_ON : > -- > 2.26.2 > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-30 2:56 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-29 20:00 [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-29 20:00 ` [PATCH 2/9] staging: media: atomisp: declare 'struct device' before using it Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 2:55 ` Nathan Chancellor 2020-05-30 2:55 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 3/9] staging: media: atomisp: annotate an unused function Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 2:56 ` Nathan Chancellor [this message] 2020-05-30 2:56 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 4/9] staging: media: atomisp: fix a type conversion warning Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-29 20:00 ` [PATCH 5/9] staging: media: atomisp: fix stack overflow in init_pipe_defaults() Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 2:57 ` Nathan Chancellor 2020-05-30 2:57 ` Nathan Chancellor 2020-05-31 20:41 ` kbuild test robot 2020-05-29 20:00 ` [PATCH 6/9] staging: media: atomisp: fix type mismatch Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-29 20:00 ` [PATCH 7/9] staging: media: atomisp: fix enum type mixups Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 3:00 ` Nathan Chancellor 2020-05-30 3:00 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 8/9] staging: media: atomisp: disable all custom formats Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 3:03 ` Nathan Chancellor 2020-05-30 3:03 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 9/9] staging: media: atomisp: add PMIC_OPREGION dependency Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 3:11 ` Nathan Chancellor 2020-05-30 3:11 ` Nathan Chancellor 2020-05-30 5:25 ` Mauro Carvalho Chehab 2020-05-30 5:25 ` Mauro Carvalho Chehab 2020-05-29 20:04 ` [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check Nick Desaulniers 2020-05-29 20:04 ` Nick Desaulniers 2020-05-29 20:23 ` Arnd Bergmann 2020-05-29 20:23 ` Arnd Bergmann 2020-05-29 20:31 ` Arnd Bergmann 2020-05-29 20:31 ` Arnd Bergmann 2020-05-30 2:49 ` Nathan Chancellor 2020-05-30 2:49 ` Nathan Chancellor 2020-05-30 9:22 ` Mauro Carvalho Chehab 2020-05-30 9:22 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200530025649.GB1367069@ubuntu-s3-xlarge-x86 \ --to=natechancellor@gmail.com \ --cc=arnd@arndb.de \ --cc=clang-built-linux@googlegroups.com \ --cc=devel@driverdev.osuosl.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.