From: Nathan Chancellor <natechancellor@gmail.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 7/9] staging: media: atomisp: fix enum type mixups Date: Fri, 29 May 2020 20:00:33 -0700 [thread overview] Message-ID: <20200530030033.GD1367069@ubuntu-s3-xlarge-x86> (raw) In-Reply-To: <20200529200031.4117841-7-arnd@arndb.de> On Fri, May 29, 2020 at 10:00:29PM +0200, Arnd Bergmann wrote: > Some function calls pass an incorrect enum type: > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:858:16: error: implicit conversion from enumeration type 'input_system_ID_t' to different enumeration type 'gp_device_ID_t' [-Werror,-Wenum-conversion] > gp_device_rst(INPUT_SYSTEM0_ID); > ~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:860:19: error: implicit conversion from enumeration type 'input_system_ID_t' to different enumeration type 'gp_device_ID_t' [-Werror,-Wenum-conversion] > input_switch_rst(INPUT_SYSTEM0_ID); > ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:876:27: error: implicit conversion from enumeration type 'input_system_cfg_flag_t' to different enumeration type 'input_system_connection_t' [-Werror,-Wenum-conversion] > config.multicast[i] = INPUT_SYSTEM_CFG_FLAG_RESET; > ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1326:32: error: implicit conversion from enumeration type 'input_system_ID_t' to different enumeration type 'gp_device_ID_t' [-Werror,-Wenum-conversion] > input_selector_cfg_for_sensor(INPUT_SYSTEM0_ID); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1329:19: error: implicit conversion from enumeration type 'input_system_ID_t' to different enumeration type 'gp_device_ID_t' [-Werror,-Wenum-conversion] > input_switch_cfg(INPUT_SYSTEM0_ID, &config.input_switch_cfg); > ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ > > INPUT_SYSTEM0_ID is zero, so use the corresponding zero-value > of the expected types instead. > > Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Huh weird that I did not see this warning but you do randconfigs so that's expected. Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> > --- > .../pci/hive_isp_css_common/host/input_system.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c > index 2114cf4f3fda..aa0f0fca9346 100644 > --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c > +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c > @@ -855,9 +855,9 @@ input_system_error_t input_system_configuration_reset(void) > > input_system_network_rst(INPUT_SYSTEM0_ID); > > - gp_device_rst(INPUT_SYSTEM0_ID); > + gp_device_rst(GP_DEVICE0_ID); > > - input_switch_rst(INPUT_SYSTEM0_ID); > + input_switch_rst(GP_DEVICE0_ID); > > //target_rst(); > > @@ -873,7 +873,7 @@ input_system_error_t input_system_configuration_reset(void) > > for (i = 0; i < N_CSI_PORTS; i++) { > config.csi_buffer_flags[i] = INPUT_SYSTEM_CFG_FLAG_RESET; > - config.multicast[i] = INPUT_SYSTEM_CFG_FLAG_RESET; > + config.multicast[i] = INPUT_SYSTEM_DISCARD_ALL; > } > > config.source_type_flags = INPUT_SYSTEM_CFG_FLAG_RESET; > @@ -1323,10 +1323,10 @@ static input_system_error_t configuration_to_registers(void) > } // end of switch (source_type) > > // Set input selector. > - input_selector_cfg_for_sensor(INPUT_SYSTEM0_ID); > + input_selector_cfg_for_sensor(GP_DEVICE0_ID); > > // Set input switch. > - input_switch_cfg(INPUT_SYSTEM0_ID, &config.input_switch_cfg); > + input_switch_cfg(GP_DEVICE0_ID, &config.input_switch_cfg); > > // Set input formatters. > // AM: IF are set dynamically. > -- > 2.26.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com> To: Arnd Bergmann <arnd@arndb.de> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Sakari Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org Subject: Re: [PATCH 7/9] staging: media: atomisp: fix enum type mixups Date: Fri, 29 May 2020 20:00:33 -0700 [thread overview] Message-ID: <20200530030033.GD1367069@ubuntu-s3-xlarge-x86> (raw) In-Reply-To: <20200529200031.4117841-7-arnd@arndb.de> On Fri, May 29, 2020 at 10:00:29PM +0200, Arnd Bergmann wrote: > Some function calls pass an incorrect enum type: > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:858:16: error: implicit conversion from enumeration type 'input_system_ID_t' to different enumeration type 'gp_device_ID_t' [-Werror,-Wenum-conversion] > gp_device_rst(INPUT_SYSTEM0_ID); > ~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:860:19: error: implicit conversion from enumeration type 'input_system_ID_t' to different enumeration type 'gp_device_ID_t' [-Werror,-Wenum-conversion] > input_switch_rst(INPUT_SYSTEM0_ID); > ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:876:27: error: implicit conversion from enumeration type 'input_system_cfg_flag_t' to different enumeration type 'input_system_connection_t' [-Werror,-Wenum-conversion] > config.multicast[i] = INPUT_SYSTEM_CFG_FLAG_RESET; > ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1326:32: error: implicit conversion from enumeration type 'input_system_ID_t' to different enumeration type 'gp_device_ID_t' [-Werror,-Wenum-conversion] > input_selector_cfg_for_sensor(INPUT_SYSTEM0_ID); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1329:19: error: implicit conversion from enumeration type 'input_system_ID_t' to different enumeration type 'gp_device_ID_t' [-Werror,-Wenum-conversion] > input_switch_cfg(INPUT_SYSTEM0_ID, &config.input_switch_cfg); > ~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ > > INPUT_SYSTEM0_ID is zero, so use the corresponding zero-value > of the expected types instead. > > Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Huh weird that I did not see this warning but you do randconfigs so that's expected. Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> > --- > .../pci/hive_isp_css_common/host/input_system.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c > index 2114cf4f3fda..aa0f0fca9346 100644 > --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c > +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c > @@ -855,9 +855,9 @@ input_system_error_t input_system_configuration_reset(void) > > input_system_network_rst(INPUT_SYSTEM0_ID); > > - gp_device_rst(INPUT_SYSTEM0_ID); > + gp_device_rst(GP_DEVICE0_ID); > > - input_switch_rst(INPUT_SYSTEM0_ID); > + input_switch_rst(GP_DEVICE0_ID); > > //target_rst(); > > @@ -873,7 +873,7 @@ input_system_error_t input_system_configuration_reset(void) > > for (i = 0; i < N_CSI_PORTS; i++) { > config.csi_buffer_flags[i] = INPUT_SYSTEM_CFG_FLAG_RESET; > - config.multicast[i] = INPUT_SYSTEM_CFG_FLAG_RESET; > + config.multicast[i] = INPUT_SYSTEM_DISCARD_ALL; > } > > config.source_type_flags = INPUT_SYSTEM_CFG_FLAG_RESET; > @@ -1323,10 +1323,10 @@ static input_system_error_t configuration_to_registers(void) > } // end of switch (source_type) > > // Set input selector. > - input_selector_cfg_for_sensor(INPUT_SYSTEM0_ID); > + input_selector_cfg_for_sensor(GP_DEVICE0_ID); > > // Set input switch. > - input_switch_cfg(INPUT_SYSTEM0_ID, &config.input_switch_cfg); > + input_switch_cfg(GP_DEVICE0_ID, &config.input_switch_cfg); > > // Set input formatters. > // AM: IF are set dynamically. > -- > 2.26.2 > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-30 3:00 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-29 20:00 [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-29 20:00 ` [PATCH 2/9] staging: media: atomisp: declare 'struct device' before using it Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 2:55 ` Nathan Chancellor 2020-05-30 2:55 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 3/9] staging: media: atomisp: annotate an unused function Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 2:56 ` Nathan Chancellor 2020-05-30 2:56 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 4/9] staging: media: atomisp: fix a type conversion warning Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-29 20:00 ` [PATCH 5/9] staging: media: atomisp: fix stack overflow in init_pipe_defaults() Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 2:57 ` Nathan Chancellor 2020-05-30 2:57 ` Nathan Chancellor 2020-05-31 20:41 ` kbuild test robot 2020-05-29 20:00 ` [PATCH 6/9] staging: media: atomisp: fix type mismatch Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-29 20:00 ` [PATCH 7/9] staging: media: atomisp: fix enum type mixups Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 3:00 ` Nathan Chancellor [this message] 2020-05-30 3:00 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 8/9] staging: media: atomisp: disable all custom formats Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 3:03 ` Nathan Chancellor 2020-05-30 3:03 ` Nathan Chancellor 2020-05-29 20:00 ` [PATCH 9/9] staging: media: atomisp: add PMIC_OPREGION dependency Arnd Bergmann 2020-05-29 20:00 ` Arnd Bergmann 2020-05-30 3:11 ` Nathan Chancellor 2020-05-30 3:11 ` Nathan Chancellor 2020-05-30 5:25 ` Mauro Carvalho Chehab 2020-05-30 5:25 ` Mauro Carvalho Chehab 2020-05-29 20:04 ` [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check Nick Desaulniers 2020-05-29 20:04 ` Nick Desaulniers 2020-05-29 20:23 ` Arnd Bergmann 2020-05-29 20:23 ` Arnd Bergmann 2020-05-29 20:31 ` Arnd Bergmann 2020-05-29 20:31 ` Arnd Bergmann 2020-05-30 2:49 ` Nathan Chancellor 2020-05-30 2:49 ` Nathan Chancellor 2020-05-30 9:22 ` Mauro Carvalho Chehab 2020-05-30 9:22 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200530030033.GD1367069@ubuntu-s3-xlarge-x86 \ --to=natechancellor@gmail.com \ --cc=arnd@arndb.de \ --cc=clang-built-linux@googlegroups.com \ --cc=devel@driverdev.osuosl.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.