From: Daniel Vetter <daniel@ffwll.ch>
To: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org,
edmund.j.dea@intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 00/59] Add support for KeemBay DRM driver
Date: Wed, 15 Jul 2020 17:14:05 +0200 [thread overview]
Message-ID: <20200715151405.GM3278063@phenom.ffwll.local> (raw)
In-Reply-To: <20200715150549.GL3278063@phenom.ffwll.local>
On Wed, Jul 15, 2020 at 05:05:49PM +0200, Daniel Vetter wrote:
> Hi Anitha
>
> On Tue, Jul 14, 2020 at 01:56:46PM -0700, Anitha Chrisanthus wrote:
> > This is a new DRM driver for Intel's KeemBay SOC.
> > The SoC couples an ARM Cortex A53 CPU with an Intel
> > Movidius VPU.
> >
> > This driver is tested with the KMB EVM board which is the refernce baord
> > for Keem Bay SOC. The SOC's display pipeline is as follows
> >
> > +--------------+ +---------+ +-----------------------+
> > |LCD controller| -> |Mipi DSI | -> |Mipi to HDMI Converter |
> > +--------------+ +---------+ +-----------------------+
> >
> > LCD controller and Mipi DSI transmitter are part of the SOC and
> > mipi to HDMI converter is ADV7535 for KMB EVM board.
> >
> > The DRM driver is a basic KMS atomic modesetting display driver and
> > has no 2D or 3D graphics.It calls into the ADV bridge driver at
> > the connector level.
> >
> > Only 1080p resolution and single plane is supported at this time.
> > The usecase is for debugging video and camera outputs.
> >
> > Device tree patches are under review here
> > https://lore.kernel.org/linux-arm-kernel/20200708175020.194436-1-daniele.alessandrelli@linux.intel.com/T/
>
> Cool, new driver, thanks a lot for submitting.
>
> > Changes since v1:
> > - Removed redundant license text, updated license
> > - Rearranged include blocks
> > - renamed global vars and removed extern in c
> > - Used upclassing for dev_private
> > - Used drm_dev_init in drm device create (will be updated to use
> > devm_drm_dev_alloc() in a separate patch later as kmb driver is currently
> > developed on 5.4 kernel)
>
> drm moves fairly quickly, please develop the upstream submission on top of
> linux-next or similar. We constantly add new helpers to simplify drivers,
> and we expect new driver submissions to be up to date with all that.
>
> Another thing: From your description it sounds like it's a very simple
> driver, just a single plane/crtc, nothing fancy, plus adv bridge output.
> Is the driver already using simple display pipeline helpers? I think that
> would be an ideal fit and probably greatly simplifies the code.
>
> > - minor cleanups
>
> The patch series looks like it contains the entire development history, or
> at least large chunks of it. That's useful for you, but for upstreaming
> the main focues (especially for smaller drivers) is whether your driver
> uses all the available helpers and integrations correctly. And for that
> it's much easier if the history is cleaned up, and all intermediate steps
> removed.
>
> I think once that's done I can do a quick pass and drop suggestions for
> cleanup and stuff like that, and then we should (usually at least) be able
> to pull in the driver fairly quickly.
>
> Another thing to consider is where/how this driver will be maintained.
> Preferred option is as part of drm-misc so that we have redudancy and all
> that in a fairly big group. Works with commit rights, so maybe check out
> some of our docs about that too.
>
> https://drm.pages.freedesktop.org/maintainer-tools/drm-misc.html
>
> The committer model comes with a full set of scripts and docs to avoid
> oopsies in maintainership. Generally works really well.
Oh if you have a git branch of this all somewhere I could do a quick
high-level pass and see whether there's anything big.
-Daniel
>
> Cheers, Daniel
>
>
> >
> > Anitha Chrisanthus (52):
> > drm/kmb: Add support for KeemBay Display
> > drm/kmb: Added id to kmb_plane
> > drm/kmb: Set correct values in the LAYERn_CFG register
> > drm/kmb: Use biwise operators for register definitions
> > drm/kmb: Updated kmb_plane_atomic_check
> > drm/kmb: Initial check-in for Mipi DSI
> > drm/kmb: Set OUT_FORMAT_CFG register
> > drm/kmb: Added mipi_dsi_host initialization
> > drm/kmb: Part 1 of Mipi Tx Initialization
> > drm/kmb: Part 2 of Mipi Tx Initialization
> > drm/kmb: Use correct mmio offset from data book
> > drm/kmb: Part3 of Mipi Tx initialization
> > drm/kmb: Part4 of Mipi Tx Initialization
> > drm/kmb: Correct address offsets for mipi registers
> > drm/kmb: Part5 of Mipi Tx Intitialization
> > drm/kmb: Part6 of Mipi Tx Initialization
> > drm/kmb: Part7 of Mipi Tx Initialization
> > drm/kmb: Part8 of Mipi Tx Initialization
> > drm/kmb: Added ioremap/iounmap for register access
> > drm/kmb: Register IRQ for LCD
> > drm/kmb: IRQ handlers for LCD and mipi dsi
> > drm/kmb: Set hardcoded values to LCD_VSYNC_START
> > drm/kmb: Additional register programming to update_plane
> > drm/kmb: Add ADV7535 bridge
> > drm/kmb: Display clock enable/disable
> > drm/kmb: rebase to newer kernel version
> > drm/kmb: minor name change to match device tree
> > drm/kmb: Changed MMIO size
> > drm/kmb: Defer Probe
> > drm/kmb: call bridge init in the very beginning
> > drm/kmb: Enable MSS_CAM_CLK_CTRL for LCD and MIPI
> > drm/kmb: Set MSS_CAM_RSTN_CTRL along with enable
> > drm/kmb: Mipi DPHY initialization changes
> > drm/kmb: Fixed driver unload
> > drm/kmb: Added LCD_TEST config
> > drm/kmb: Changes for LCD to Mipi
> > drm/kmb: Update LCD programming to match MIPI
> > drm/kmb: Changed name of driver to kmb-drm
> > drm/kmb: Mipi settings from input timings
> > drm/kmb: Enable LCD interrupts
> > drm/kmb: Enable LCD interrupts during modeset
> > drm/kmb: Don’t inadvertantly disable LCD controller
> > drm/kmb: SWAP R and B LCD Layer order
> > drm/kmb: Disable ping pong mode
> > drm/kmb: Do the layer initializations only once
> > drm/kmb: disable the LCD layer in EOF irq handler
> > drm/kmb: Initialize uninitialized variables
> > drm/kmb: Added useful messages in LCD ISR
> > kmb/drm: Prune unsupported modes
> > drm/kmb: workaround for dma undeflow issue
> > drm/kmb: Get System Clock from SCMI
> > drm/kmb: work around for planar formats
> >
> > Edmund Dea (7):
> > drm/kmb: Cleanup probe functions
> > drm/kmb: Revert dsi_host back to a static variable
> > drm/kmb: Initialize clocks for clk_msscam, clk_mipi_ecfg, &
> > clk_mipi_cfg.
> > drm/kmb: Remove declaration of irq_lcd/irq_mipi
> > drm/kmb: Enable MIPI TX HS Test Pattern Generation
> > drm/kmb: Write to LCD_LAYERn_CFG only once
> > drm/kmb: Cleaned up code
> >
> > drivers/gpu/drm/Kconfig | 2 +
> > drivers/gpu/drm/Makefile | 1 +
> > drivers/gpu/drm/kmb/Kconfig | 12 +
> > drivers/gpu/drm/kmb/Makefile | 2 +
> > drivers/gpu/drm/kmb/kmb_crtc.c | 226 +++++
> > drivers/gpu/drm/kmb/kmb_crtc.h | 41 +
> > drivers/gpu/drm/kmb/kmb_drv.c | 809 ++++++++++++++++
> > drivers/gpu/drm/kmb/kmb_drv.h | 176 ++++
> > drivers/gpu/drm/kmb/kmb_dsi.c | 1927 +++++++++++++++++++++++++++++++++++++++
> > drivers/gpu/drm/kmb/kmb_dsi.h | 370 ++++++++
> > drivers/gpu/drm/kmb/kmb_plane.c | 518 +++++++++++
> > drivers/gpu/drm/kmb/kmb_plane.h | 124 +++
> > drivers/gpu/drm/kmb/kmb_regs.h | 738 +++++++++++++++
> > 13 files changed, 4946 insertions(+)
> > create mode 100644 drivers/gpu/drm/kmb/Kconfig
> > create mode 100644 drivers/gpu/drm/kmb/Makefile
> > create mode 100644 drivers/gpu/drm/kmb/kmb_crtc.c
> > create mode 100644 drivers/gpu/drm/kmb/kmb_crtc.h
> > create mode 100644 drivers/gpu/drm/kmb/kmb_drv.c
> > create mode 100644 drivers/gpu/drm/kmb/kmb_drv.h
> > create mode 100644 drivers/gpu/drm/kmb/kmb_dsi.c
> > create mode 100644 drivers/gpu/drm/kmb/kmb_dsi.h
> > create mode 100644 drivers/gpu/drm/kmb/kmb_plane.c
> > create mode 100644 drivers/gpu/drm/kmb/kmb_plane.h
> > create mode 100644 drivers/gpu/drm/kmb/kmb_regs.h
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org,
edmund.j.dea@intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 00/59] Add support for KeemBay DRM driver
Date: Wed, 15 Jul 2020 17:14:05 +0200 [thread overview]
Message-ID: <20200715151405.GM3278063@phenom.ffwll.local> (raw)
In-Reply-To: <20200715150549.GL3278063@phenom.ffwll.local>
On Wed, Jul 15, 2020 at 05:05:49PM +0200, Daniel Vetter wrote:
> Hi Anitha
>
> On Tue, Jul 14, 2020 at 01:56:46PM -0700, Anitha Chrisanthus wrote:
> > This is a new DRM driver for Intel's KeemBay SOC.
> > The SoC couples an ARM Cortex A53 CPU with an Intel
> > Movidius VPU.
> >
> > This driver is tested with the KMB EVM board which is the refernce baord
> > for Keem Bay SOC. The SOC's display pipeline is as follows
> >
> > +--------------+ +---------+ +-----------------------+
> > |LCD controller| -> |Mipi DSI | -> |Mipi to HDMI Converter |
> > +--------------+ +---------+ +-----------------------+
> >
> > LCD controller and Mipi DSI transmitter are part of the SOC and
> > mipi to HDMI converter is ADV7535 for KMB EVM board.
> >
> > The DRM driver is a basic KMS atomic modesetting display driver and
> > has no 2D or 3D graphics.It calls into the ADV bridge driver at
> > the connector level.
> >
> > Only 1080p resolution and single plane is supported at this time.
> > The usecase is for debugging video and camera outputs.
> >
> > Device tree patches are under review here
> > https://lore.kernel.org/linux-arm-kernel/20200708175020.194436-1-daniele.alessandrelli@linux.intel.com/T/
>
> Cool, new driver, thanks a lot for submitting.
>
> > Changes since v1:
> > - Removed redundant license text, updated license
> > - Rearranged include blocks
> > - renamed global vars and removed extern in c
> > - Used upclassing for dev_private
> > - Used drm_dev_init in drm device create (will be updated to use
> > devm_drm_dev_alloc() in a separate patch later as kmb driver is currently
> > developed on 5.4 kernel)
>
> drm moves fairly quickly, please develop the upstream submission on top of
> linux-next or similar. We constantly add new helpers to simplify drivers,
> and we expect new driver submissions to be up to date with all that.
>
> Another thing: From your description it sounds like it's a very simple
> driver, just a single plane/crtc, nothing fancy, plus adv bridge output.
> Is the driver already using simple display pipeline helpers? I think that
> would be an ideal fit and probably greatly simplifies the code.
>
> > - minor cleanups
>
> The patch series looks like it contains the entire development history, or
> at least large chunks of it. That's useful for you, but for upstreaming
> the main focues (especially for smaller drivers) is whether your driver
> uses all the available helpers and integrations correctly. And for that
> it's much easier if the history is cleaned up, and all intermediate steps
> removed.
>
> I think once that's done I can do a quick pass and drop suggestions for
> cleanup and stuff like that, and then we should (usually at least) be able
> to pull in the driver fairly quickly.
>
> Another thing to consider is where/how this driver will be maintained.
> Preferred option is as part of drm-misc so that we have redudancy and all
> that in a fairly big group. Works with commit rights, so maybe check out
> some of our docs about that too.
>
> https://drm.pages.freedesktop.org/maintainer-tools/drm-misc.html
>
> The committer model comes with a full set of scripts and docs to avoid
> oopsies in maintainership. Generally works really well.
Oh if you have a git branch of this all somewhere I could do a quick
high-level pass and see whether there's anything big.
-Daniel
>
> Cheers, Daniel
>
>
> >
> > Anitha Chrisanthus (52):
> > drm/kmb: Add support for KeemBay Display
> > drm/kmb: Added id to kmb_plane
> > drm/kmb: Set correct values in the LAYERn_CFG register
> > drm/kmb: Use biwise operators for register definitions
> > drm/kmb: Updated kmb_plane_atomic_check
> > drm/kmb: Initial check-in for Mipi DSI
> > drm/kmb: Set OUT_FORMAT_CFG register
> > drm/kmb: Added mipi_dsi_host initialization
> > drm/kmb: Part 1 of Mipi Tx Initialization
> > drm/kmb: Part 2 of Mipi Tx Initialization
> > drm/kmb: Use correct mmio offset from data book
> > drm/kmb: Part3 of Mipi Tx initialization
> > drm/kmb: Part4 of Mipi Tx Initialization
> > drm/kmb: Correct address offsets for mipi registers
> > drm/kmb: Part5 of Mipi Tx Intitialization
> > drm/kmb: Part6 of Mipi Tx Initialization
> > drm/kmb: Part7 of Mipi Tx Initialization
> > drm/kmb: Part8 of Mipi Tx Initialization
> > drm/kmb: Added ioremap/iounmap for register access
> > drm/kmb: Register IRQ for LCD
> > drm/kmb: IRQ handlers for LCD and mipi dsi
> > drm/kmb: Set hardcoded values to LCD_VSYNC_START
> > drm/kmb: Additional register programming to update_plane
> > drm/kmb: Add ADV7535 bridge
> > drm/kmb: Display clock enable/disable
> > drm/kmb: rebase to newer kernel version
> > drm/kmb: minor name change to match device tree
> > drm/kmb: Changed MMIO size
> > drm/kmb: Defer Probe
> > drm/kmb: call bridge init in the very beginning
> > drm/kmb: Enable MSS_CAM_CLK_CTRL for LCD and MIPI
> > drm/kmb: Set MSS_CAM_RSTN_CTRL along with enable
> > drm/kmb: Mipi DPHY initialization changes
> > drm/kmb: Fixed driver unload
> > drm/kmb: Added LCD_TEST config
> > drm/kmb: Changes for LCD to Mipi
> > drm/kmb: Update LCD programming to match MIPI
> > drm/kmb: Changed name of driver to kmb-drm
> > drm/kmb: Mipi settings from input timings
> > drm/kmb: Enable LCD interrupts
> > drm/kmb: Enable LCD interrupts during modeset
> > drm/kmb: Don’t inadvertantly disable LCD controller
> > drm/kmb: SWAP R and B LCD Layer order
> > drm/kmb: Disable ping pong mode
> > drm/kmb: Do the layer initializations only once
> > drm/kmb: disable the LCD layer in EOF irq handler
> > drm/kmb: Initialize uninitialized variables
> > drm/kmb: Added useful messages in LCD ISR
> > kmb/drm: Prune unsupported modes
> > drm/kmb: workaround for dma undeflow issue
> > drm/kmb: Get System Clock from SCMI
> > drm/kmb: work around for planar formats
> >
> > Edmund Dea (7):
> > drm/kmb: Cleanup probe functions
> > drm/kmb: Revert dsi_host back to a static variable
> > drm/kmb: Initialize clocks for clk_msscam, clk_mipi_ecfg, &
> > clk_mipi_cfg.
> > drm/kmb: Remove declaration of irq_lcd/irq_mipi
> > drm/kmb: Enable MIPI TX HS Test Pattern Generation
> > drm/kmb: Write to LCD_LAYERn_CFG only once
> > drm/kmb: Cleaned up code
> >
> > drivers/gpu/drm/Kconfig | 2 +
> > drivers/gpu/drm/Makefile | 1 +
> > drivers/gpu/drm/kmb/Kconfig | 12 +
> > drivers/gpu/drm/kmb/Makefile | 2 +
> > drivers/gpu/drm/kmb/kmb_crtc.c | 226 +++++
> > drivers/gpu/drm/kmb/kmb_crtc.h | 41 +
> > drivers/gpu/drm/kmb/kmb_drv.c | 809 ++++++++++++++++
> > drivers/gpu/drm/kmb/kmb_drv.h | 176 ++++
> > drivers/gpu/drm/kmb/kmb_dsi.c | 1927 +++++++++++++++++++++++++++++++++++++++
> > drivers/gpu/drm/kmb/kmb_dsi.h | 370 ++++++++
> > drivers/gpu/drm/kmb/kmb_plane.c | 518 +++++++++++
> > drivers/gpu/drm/kmb/kmb_plane.h | 124 +++
> > drivers/gpu/drm/kmb/kmb_regs.h | 738 +++++++++++++++
> > 13 files changed, 4946 insertions(+)
> > create mode 100644 drivers/gpu/drm/kmb/Kconfig
> > create mode 100644 drivers/gpu/drm/kmb/Makefile
> > create mode 100644 drivers/gpu/drm/kmb/kmb_crtc.c
> > create mode 100644 drivers/gpu/drm/kmb/kmb_crtc.h
> > create mode 100644 drivers/gpu/drm/kmb/kmb_drv.c
> > create mode 100644 drivers/gpu/drm/kmb/kmb_drv.h
> > create mode 100644 drivers/gpu/drm/kmb/kmb_dsi.c
> > create mode 100644 drivers/gpu/drm/kmb/kmb_dsi.h
> > create mode 100644 drivers/gpu/drm/kmb/kmb_plane.c
> > create mode 100644 drivers/gpu/drm/kmb/kmb_plane.h
> > create mode 100644 drivers/gpu/drm/kmb/kmb_regs.h
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-15 15:14 UTC|newest]
Thread overview: 133+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 20:56 [PATCH v2 00/59] Add support for KeemBay DRM driver Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 01/59] drm/kmb: Add support for KeemBay Display Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 02/59] drm/kmb: Added id to kmb_plane Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 03/59] drm/kmb: Set correct values in the LAYERn_CFG register Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 04/59] drm/kmb: Use biwise operators for register definitions Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 05/59] drm/kmb: Updated kmb_plane_atomic_check Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 06/59] drm/kmb: Initial check-in for Mipi DSI Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 07/59] drm/kmb: Set OUT_FORMAT_CFG register Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 08/59] drm/kmb: Added mipi_dsi_host initialization Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 09/59] drm/kmb: Part 1 of Mipi Tx Initialization Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 10/59] drm/kmb: Part 2 " Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 11/59] drm/kmb: Use correct mmio offset from data book Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 12/59] drm/kmb: Part3 of Mipi Tx initialization Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:56 ` [PATCH v2 13/59] drm/kmb: Part4 of Mipi Tx Initialization Anitha Chrisanthus
2020-07-14 20:56 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 14/59] drm/kmb: Correct address offsets for mipi registers Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 15/59] drm/kmb: Part5 of Mipi Tx Intitialization Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 16/59] drm/kmb: Part6 of Mipi Tx Initialization Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 17/59] drm/kmb: Part7 " Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 18/59] drm/kmb: Part8 " Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 19/59] drm/kmb: Added ioremap/iounmap for register access Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 20/59] drm/kmb: Register IRQ for LCD Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 21/59] drm/kmb: IRQ handlers for LCD and mipi dsi Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 22/59] drm/kmb: Set hardcoded values to LCD_VSYNC_START Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 23/59] drm/kmb: Additional register programming to update_plane Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 24/59] drm/kmb: Add ADV7535 bridge Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 25/59] drm/kmb: Display clock enable/disable Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 26/59] drm/kmb: rebase to newer kernel version Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 27/59] drm/kmb: minor name change to match device tree Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 28/59] drm/kmb: Changed MMIO size Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 29/59] drm/kmb: Defer Probe Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 30/59] drm/kmb: call bridge init in the very beginning Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 31/59] drm/kmb: Cleanup probe functions Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 32/59] drm/kmb: Revert dsi_host back to a static variable Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 33/59] drm/kmb: Initialize clocks for clk_msscam, clk_mipi_ecfg, & clk_mipi_cfg Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 34/59] drm/kmb: Enable MSS_CAM_CLK_CTRL for LCD and MIPI Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 35/59] drm/kmb: Remove declaration of irq_lcd/irq_mipi Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 36/59] drm/kmb: Enable MIPI TX HS Test Pattern Generation Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 37/59] drm/kmb: Set MSS_CAM_RSTN_CTRL along with enable Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 38/59] drm/kmb: Mipi DPHY initialization changes Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 39/59] drm/kmb: Fixed driver unload Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 40/59] drm/kmb: Added LCD_TEST config Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 41/59] drm/kmb: Changes for LCD to Mipi Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 42/59] drm/kmb: Update LCD programming to match MIPI Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 43/59] drm/kmb: Changed name of driver to kmb-drm Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 44/59] drm/kmb: Mipi settings from input timings Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 45/59] drm/kmb: Enable LCD interrupts Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 46/59] drm/kmb: Enable LCD interrupts during modeset Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 47/59] drm/kmb: Don’t inadvertantly disable LCD controller Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 48/59] drm/kmb: SWAP R and B LCD Layer order Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 49/59] drm/kmb: Disable ping pong mode Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 50/59] drm/kmb: Do the layer initializations only once Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 51/59] drm/kmb: Write to LCD_LAYERn_CFG " Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 52/59] drm/kmb: Cleaned up code Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 53/59] drm/kmb: disable the LCD layer in EOF irq handler Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 54/59] drm/kmb: Initialize uninitialized variables Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 55/59] drm/kmb: Added useful messages in LCD ISR Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 56/59] kmb/drm: Prune unsupported modes Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 57/59] drm/kmb: workaround for dma undeflow issue Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 58/59] drm/kmb: Get System Clock from SCMI Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 20:57 ` [PATCH v2 59/59] drm/kmb: work around for planar formats Anitha Chrisanthus
2020-07-14 20:57 ` [Intel-gfx] " Anitha Chrisanthus
2020-07-14 21:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for KeemBay DRM driver Patchwork
2020-07-14 22:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-15 1:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-07-15 15:05 ` [Intel-gfx] [PATCH v2 00/59] " Daniel Vetter
2020-07-15 15:05 ` Daniel Vetter
2020-07-15 15:14 ` Daniel Vetter [this message]
2020-07-15 15:14 ` Daniel Vetter
2020-07-15 17:06 ` Sam Ravnborg
2020-07-15 17:06 ` Sam Ravnborg
2020-07-15 18:38 ` Chrisanthus, Anitha
2020-07-15 18:38 ` Chrisanthus, Anitha
2020-07-15 17:01 ` Sam Ravnborg
2020-07-15 17:01 ` [Intel-gfx] " Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715151405.GM3278063@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=anitha.chrisanthus@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edmund.j.dea@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.