From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH rfc 2/3] virtio-net: support receive timestamp
Date: Mon, 28 Dec 2020 14:59:53 -0800 [thread overview]
Message-ID: <20201228145953.08673c8c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201228162233.2032571-3-willemdebruijn.kernel@gmail.com>
On Mon, 28 Dec 2020 11:22:32 -0500 Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> Add optional PTP hardware timestamp offload for virtio-net.
>
> Accurate RTT measurement requires timestamps close to the wire.
> Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the
> virtio-net header is expanded with room for a timestamp. A host may
> pass receive timestamps for all or some packets. A timestamp is valid
> if non-zero.
>
> The timestamp straddles (virtual) hardware domains. Like PTP, use
> international atomic time (CLOCK_TAI) as global clock base. It is
> guest responsibility to sync with host, e.g., through kvm-clock.
Would this not be confusing to some user space SW to have a NIC with
no PHC deliver HW stamps?
I'd CC Richard on this, unless you already discussed with him offline.
next prev parent reply other threads:[~2020-12-28 23:01 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 16:22 [PATCH rfc 0/3] virtio-net: add tx-hash, rx-tstamp and tx-tstamp Willem de Bruijn
2020-12-28 16:22 ` Willem de Bruijn
2020-12-28 16:22 ` [PATCH rfc 1/3] virtio-net: support transmit hash report Willem de Bruijn
2020-12-28 16:22 ` Willem de Bruijn
2020-12-28 16:28 ` Michael S. Tsirkin
2020-12-28 16:28 ` Michael S. Tsirkin
2020-12-28 16:47 ` Willem de Bruijn
2020-12-28 16:47 ` Willem de Bruijn
2020-12-28 17:22 ` Michael S. Tsirkin
2020-12-28 17:22 ` Michael S. Tsirkin
2020-12-29 1:19 ` Willem de Bruijn
2020-12-29 1:19 ` Willem de Bruijn
2020-12-28 21:36 ` Michael S. Tsirkin
2020-12-28 21:36 ` Michael S. Tsirkin
2020-12-29 1:23 ` Willem de Bruijn
2020-12-29 1:23 ` Willem de Bruijn
2020-12-28 16:22 ` [PATCH rfc 2/3] virtio-net: support receive timestamp Willem de Bruijn
2020-12-28 16:22 ` Willem de Bruijn
2020-12-28 17:28 ` Michael S. Tsirkin
2020-12-28 17:28 ` Michael S. Tsirkin
2020-12-28 19:30 ` Willem de Bruijn
2020-12-28 19:30 ` Willem de Bruijn
2020-12-28 21:32 ` Michael S. Tsirkin
2020-12-28 21:32 ` Michael S. Tsirkin
2020-12-29 1:05 ` Willem de Bruijn
2020-12-29 1:05 ` Willem de Bruijn
2020-12-29 9:17 ` Jason Wang
2020-12-29 9:17 ` Jason Wang
2020-12-29 14:20 ` Willem de Bruijn
2020-12-29 14:20 ` Willem de Bruijn
2020-12-30 8:38 ` Jason Wang
2020-12-30 8:38 ` Jason Wang
2020-12-28 22:59 ` Jakub Kicinski [this message]
2020-12-29 0:57 ` Willem de Bruijn
2020-12-29 0:57 ` Willem de Bruijn
2020-12-30 8:44 ` Jason Wang
2020-12-30 8:44 ` Jason Wang
2020-12-30 12:30 ` Richard Cochran
2021-02-02 13:05 ` kernel test robot
2021-02-02 13:05 ` kernel test robot
2021-02-02 13:05 ` kernel test robot
2021-02-02 14:08 ` Michael S. Tsirkin
2021-02-02 14:08 ` Michael S. Tsirkin
2021-02-02 22:17 ` Willem de Bruijn
2021-02-02 22:17 ` Willem de Bruijn
2021-02-02 23:02 ` Michael S. Tsirkin
2021-02-02 23:02 ` Michael S. Tsirkin
2021-02-02 23:43 ` Willem de Bruijn
2021-02-02 23:43 ` Willem de Bruijn
2020-12-28 16:22 ` [PATCH rfc 3/3] virtio-net: support transmit timestamp Willem de Bruijn
2020-12-28 16:22 ` Willem de Bruijn
2020-12-30 12:38 ` Richard Cochran
2020-12-30 15:25 ` Willem de Bruijn
2020-12-30 15:25 ` Willem de Bruijn
2021-02-02 13:47 ` kernel test robot
2021-02-02 13:47 ` kernel test robot
2021-02-02 13:47 ` kernel test robot
2020-12-28 17:29 ` [PATCH rfc 0/3] virtio-net: add tx-hash, rx-tstamp and tx-tstamp Michael S. Tsirkin
2020-12-28 17:29 ` Michael S. Tsirkin
2020-12-28 19:51 ` Willem de Bruijn
2020-12-28 19:51 ` Willem de Bruijn
2020-12-28 21:38 ` Michael S. Tsirkin
2020-12-28 21:38 ` Michael S. Tsirkin
2020-12-29 1:14 ` Willem de Bruijn
2020-12-29 1:14 ` Willem de Bruijn
2021-01-06 20:32 ` Willem de Bruijn
2021-01-06 20:32 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228145953.08673c8c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.