From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: virtualization@lists.linux-foundation.org,
Network Development <netdev@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH rfc 3/3] virtio-net: support transmit timestamp
Date: Wed, 30 Dec 2020 10:25:46 -0500 [thread overview]
Message-ID: <CAF=yD-Ly3cdpj+B25Zgu+KYCE8ijV0+fQ_ssgjBAG2w8=iAp-Q@mail.gmail.com> (raw)
In-Reply-To: <20201230123854.GB2034@hoboy.vegasvil.org>
On Wed, Dec 30, 2020 at 7:38 AM Richard Cochran
<richardcochran@gmail.com> wrote:
>
> On Mon, Dec 28, 2020 at 11:22:33AM -0500, Willem de Bruijn wrote:
> > From: Willem de Bruijn <willemb@google.com>
> >
> > Add optional delivery time (SO_TXTIME) offload for virtio-net.
> >
> > The Linux TCP/IP stack tries to avoid bursty transmission and network
> > congestion through pacing: computing an skb delivery time based on
> > congestion information. Userspace protocol implementations can achieve
> > the same with SO_TXTIME. This may also reduce scheduling jitter and
> > improve RTT estimation.
>
> This description is clear, but the Subject line is confusing. It made
> me wonder whether this series is somehow about host/guest synchronization
> (but your comments do explain that that isn't the case).
>
> How about this instead?
>
> virtio-net: support future packet transmit time
Yes, that's clearer. As is, this could easily be mistaken for
SOF_TIMESTAMPING_TX_*, which it is not. Will update, thanks.
Related terms already in use are SO_TXTIME, Earliest Delivery Time
(EDT) and Earliest TxTime First (ETF).
I should probably also s/TX_TSTAMP/TX_TIME/ in the code for the same reason.
WARNING: multiple messages have this Message-ID (diff)
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Willem de Bruijn <willemb@google.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH rfc 3/3] virtio-net: support transmit timestamp
Date: Wed, 30 Dec 2020 10:25:46 -0500 [thread overview]
Message-ID: <CAF=yD-Ly3cdpj+B25Zgu+KYCE8ijV0+fQ_ssgjBAG2w8=iAp-Q@mail.gmail.com> (raw)
In-Reply-To: <20201230123854.GB2034@hoboy.vegasvil.org>
On Wed, Dec 30, 2020 at 7:38 AM Richard Cochran
<richardcochran@gmail.com> wrote:
>
> On Mon, Dec 28, 2020 at 11:22:33AM -0500, Willem de Bruijn wrote:
> > From: Willem de Bruijn <willemb@google.com>
> >
> > Add optional delivery time (SO_TXTIME) offload for virtio-net.
> >
> > The Linux TCP/IP stack tries to avoid bursty transmission and network
> > congestion through pacing: computing an skb delivery time based on
> > congestion information. Userspace protocol implementations can achieve
> > the same with SO_TXTIME. This may also reduce scheduling jitter and
> > improve RTT estimation.
>
> This description is clear, but the Subject line is confusing. It made
> me wonder whether this series is somehow about host/guest synchronization
> (but your comments do explain that that isn't the case).
>
> How about this instead?
>
> virtio-net: support future packet transmit time
Yes, that's clearer. As is, this could easily be mistaken for
SOF_TIMESTAMPING_TX_*, which it is not. Will update, thanks.
Related terms already in use are SO_TXTIME, Earliest Delivery Time
(EDT) and Earliest TxTime First (ETF).
I should probably also s/TX_TSTAMP/TX_TIME/ in the code for the same reason.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-12-30 15:27 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 16:22 [PATCH rfc 0/3] virtio-net: add tx-hash, rx-tstamp and tx-tstamp Willem de Bruijn
2020-12-28 16:22 ` Willem de Bruijn
2020-12-28 16:22 ` [PATCH rfc 1/3] virtio-net: support transmit hash report Willem de Bruijn
2020-12-28 16:22 ` Willem de Bruijn
2020-12-28 16:28 ` Michael S. Tsirkin
2020-12-28 16:28 ` Michael S. Tsirkin
2020-12-28 16:47 ` Willem de Bruijn
2020-12-28 16:47 ` Willem de Bruijn
2020-12-28 17:22 ` Michael S. Tsirkin
2020-12-28 17:22 ` Michael S. Tsirkin
2020-12-29 1:19 ` Willem de Bruijn
2020-12-29 1:19 ` Willem de Bruijn
2020-12-28 21:36 ` Michael S. Tsirkin
2020-12-28 21:36 ` Michael S. Tsirkin
2020-12-29 1:23 ` Willem de Bruijn
2020-12-29 1:23 ` Willem de Bruijn
2020-12-28 16:22 ` [PATCH rfc 2/3] virtio-net: support receive timestamp Willem de Bruijn
2020-12-28 16:22 ` Willem de Bruijn
2020-12-28 17:28 ` Michael S. Tsirkin
2020-12-28 17:28 ` Michael S. Tsirkin
2020-12-28 19:30 ` Willem de Bruijn
2020-12-28 19:30 ` Willem de Bruijn
2020-12-28 21:32 ` Michael S. Tsirkin
2020-12-28 21:32 ` Michael S. Tsirkin
2020-12-29 1:05 ` Willem de Bruijn
2020-12-29 1:05 ` Willem de Bruijn
2020-12-29 9:17 ` Jason Wang
2020-12-29 9:17 ` Jason Wang
2020-12-29 14:20 ` Willem de Bruijn
2020-12-29 14:20 ` Willem de Bruijn
2020-12-30 8:38 ` Jason Wang
2020-12-30 8:38 ` Jason Wang
2020-12-28 22:59 ` Jakub Kicinski
2020-12-29 0:57 ` Willem de Bruijn
2020-12-29 0:57 ` Willem de Bruijn
2020-12-30 8:44 ` Jason Wang
2020-12-30 8:44 ` Jason Wang
2020-12-30 12:30 ` Richard Cochran
2021-02-02 13:05 ` kernel test robot
2021-02-02 13:05 ` kernel test robot
2021-02-02 13:05 ` kernel test robot
2021-02-02 14:08 ` Michael S. Tsirkin
2021-02-02 14:08 ` Michael S. Tsirkin
2021-02-02 22:17 ` Willem de Bruijn
2021-02-02 22:17 ` Willem de Bruijn
2021-02-02 23:02 ` Michael S. Tsirkin
2021-02-02 23:02 ` Michael S. Tsirkin
2021-02-02 23:43 ` Willem de Bruijn
2021-02-02 23:43 ` Willem de Bruijn
2020-12-28 16:22 ` [PATCH rfc 3/3] virtio-net: support transmit timestamp Willem de Bruijn
2020-12-28 16:22 ` Willem de Bruijn
2020-12-30 12:38 ` Richard Cochran
2020-12-30 15:25 ` Willem de Bruijn [this message]
2020-12-30 15:25 ` Willem de Bruijn
2021-02-02 13:47 ` kernel test robot
2021-02-02 13:47 ` kernel test robot
2021-02-02 13:47 ` kernel test robot
2020-12-28 17:29 ` [PATCH rfc 0/3] virtio-net: add tx-hash, rx-tstamp and tx-tstamp Michael S. Tsirkin
2020-12-28 17:29 ` Michael S. Tsirkin
2020-12-28 19:51 ` Willem de Bruijn
2020-12-28 19:51 ` Willem de Bruijn
2020-12-28 21:38 ` Michael S. Tsirkin
2020-12-28 21:38 ` Michael S. Tsirkin
2020-12-29 1:14 ` Willem de Bruijn
2020-12-29 1:14 ` Willem de Bruijn
2021-01-06 20:32 ` Willem de Bruijn
2021-01-06 20:32 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-Ly3cdpj+B25Zgu+KYCE8ijV0+fQ_ssgjBAG2w8=iAp-Q@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.