From: Peter Geis <pgwipeout@gmail.com> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Peter De Schrijver <pdeschrijver@nvidia.com>, Prashant Gaikwad <pgaikwad@nvidia.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Sameer Pujar <spujar@nvidia.com>, Mohan Kumar <mkumard@nvidia.com> Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Peter Geis <pgwipeout@gmail.com> Subject: [PATCH v2 0/2] fix tegra-hda on tegra30 devices Date: Fri, 8 Jan 2021 13:59:11 +0000 [thread overview] Message-ID: <20210108135913.2421585-1-pgwipeout@gmail.com> (raw) The following patches fix tegra-hda on legacy tegra devices. Two issues were discovered preventing tegra-hda from functioning: -The hda clocks on tegra30 were assigned to clk_m and running at too low of a rate to function. -The tegra-hda encounters an input/output error when opening a stream. Since the only mainline device that used tegra-hda until recently was the t124, it is unknown exactly when this was broken. Fortunately a recent patch was submitted that fixed the issue only on t194 devices. We can apply it to the tegra30-hda device to resolve the issue across the board. Note that downstream devices used the spdif device instead of hda for hdmi audio. The spdif device lacks a driver on mainline. -Checkpatch seems to have issues finding [1], but git show has no issue. [1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on Tegra194") Changelog: v2: -Added ack and reviewed-by from Jon -Updated fix to apply to tegra30-hda vice universally (Thanks Jon) -Updated commit to include comments from hardware team (Thanks Sameer) -Cleaned up commit messages Peter Geis (2): clk: tegra30: Add hda clock default rates to clock driver ALSA: hda/tegra: fix tegra-hda on tegra30 soc drivers/clk/tegra/clk-tegra30.c | 2 ++ sound/pci/hda/hda_tegra.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Peter Geis <pgwipeout@gmail.com> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Peter De Schrijver <pdeschrijver@nvidia.com>, Prashant Gaikwad <pgaikwad@nvidia.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Sameer Pujar <spujar@nvidia.com>, Mohan Kumar <mkumard@nvidia.com> Cc: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org, linux-clk@vger.kernel.org, Peter Geis <pgwipeout@gmail.com>, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/2] fix tegra-hda on tegra30 devices Date: Fri, 8 Jan 2021 13:59:11 +0000 [thread overview] Message-ID: <20210108135913.2421585-1-pgwipeout@gmail.com> (raw) The following patches fix tegra-hda on legacy tegra devices. Two issues were discovered preventing tegra-hda from functioning: -The hda clocks on tegra30 were assigned to clk_m and running at too low of a rate to function. -The tegra-hda encounters an input/output error when opening a stream. Since the only mainline device that used tegra-hda until recently was the t124, it is unknown exactly when this was broken. Fortunately a recent patch was submitted that fixed the issue only on t194 devices. We can apply it to the tegra30-hda device to resolve the issue across the board. Note that downstream devices used the spdif device instead of hda for hdmi audio. The spdif device lacks a driver on mainline. -Checkpatch seems to have issues finding [1], but git show has no issue. [1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on Tegra194") Changelog: v2: -Added ack and reviewed-by from Jon -Updated fix to apply to tegra30-hda vice universally (Thanks Jon) -Updated commit to include comments from hardware team (Thanks Sameer) -Cleaned up commit messages Peter Geis (2): clk: tegra30: Add hda clock default rates to clock driver ALSA: hda/tegra: fix tegra-hda on tegra30 soc drivers/clk/tegra/clk-tegra30.c | 2 ++ sound/pci/hda/hda_tegra.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.25.1
next reply other threads:[~2021-01-08 14:00 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-08 13:59 Peter Geis [this message] 2021-01-08 13:59 ` [PATCH v2 0/2] fix tegra-hda on tegra30 devices Peter Geis 2021-01-08 13:59 ` [PATCH v2 1/2] clk: tegra30: Add hda clock default rates to clock driver Peter Geis 2021-01-08 13:59 ` Peter Geis 2021-01-08 15:13 ` Sameer Pujar 2021-01-08 15:13 ` Sameer Pujar 2021-01-12 12:58 ` Thierry Reding 2021-01-12 12:58 ` Thierry Reding 2021-01-08 13:59 ` [PATCH v2 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc Peter Geis 2021-01-08 13:59 ` Peter Geis 2021-01-08 15:15 ` Sameer Pujar 2021-01-08 15:15 ` Sameer Pujar 2021-01-12 12:58 ` Thierry Reding 2021-01-12 12:58 ` Thierry Reding 2021-01-12 8:22 ` [PATCH v2 0/2] fix tegra-hda on tegra30 devices Takashi Iwai 2021-01-12 8:22 ` Takashi Iwai 2021-01-12 13:00 ` Thierry Reding 2021-01-12 13:00 ` Thierry Reding 2021-01-12 13:46 ` Takashi Iwai 2021-01-12 13:46 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210108135913.2421585-1-pgwipeout@gmail.com \ --to=pgwipeout@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=jonathanh@nvidia.com \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mkumard@nvidia.com \ --cc=mturquette@baylibre.com \ --cc=pdeschrijver@nvidia.com \ --cc=perex@perex.cz \ --cc=pgaikwad@nvidia.com \ --cc=sboyd@kernel.org \ --cc=spujar@nvidia.com \ --cc=thierry.reding@gmail.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.