From: Pratyush Yadav <p.yadav@ti.com> To: "Péter Ujfalusi" <peter.ujfalusi@gmail.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Maxime Ripard <mripard@kernel.org>, Benoit Parrot <bparrot@ti.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Alexandre Courbot <acourbot@chromium.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Stanimir Varbanov <stanimir.varbanov@linaro.org>, Helen Koike <helen.koike@collabora.com>, Michael Tretter <m.tretter@pengutronix.de>, Peter Chen <peter.chen@nxp.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>, <dmaengine@vger.kernel.org>, Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Subject: Re: [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Date: Tue, 6 Apr 2021 20:39:44 +0530 [thread overview] Message-ID: <20210406150942.4kyjh2ehsvklupjr@ti.com> (raw) In-Reply-To: <78a5983c-04c8-4a4c-04fe-bb1f31e87375@gmail.com> On 04/04/21 04:24PM, Péter Ujfalusi wrote: > Hi Pratyush, > > On 3/30/21 8:33 PM, Pratyush Yadav wrote: > > The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory. It can > > have up to 32 threads but the current driver only supports using one. So > > add an entry for that one thread. > > If you are absolutely sure that the other threads are not going to be > used, then: The opposite in fact. I do expect other threads to be used in the future. But the current driver can only use one so I figured it is better to add just the thread that is currently needed and then I can always add the rest later. Why does this have to be a one-and-done deal? Is there anything wrong with adding the other threads when the driver can actually use them? > Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> > > but I would consider adding the other threads if there is a chance that > the cs2rx will need to support it in the future. > > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > > --- > > drivers/dma/ti/k3-psil-j721e.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/dma/ti/k3-psil-j721e.c b/drivers/dma/ti/k3-psil-j721e.c > > index 7580870ed746..19ffa31e6dc6 100644 > > --- a/drivers/dma/ti/k3-psil-j721e.c > > +++ b/drivers/dma/ti/k3-psil-j721e.c > > @@ -58,6 +58,14 @@ > > }, \ > > } > > > > +#define PSIL_CSI2RX(x) \ > > + { \ > > + .thread_id = x, \ > > + .ep_config = { \ > > + .ep_type = PSIL_EP_NATIVE, \ > > + }, \ > > + } > > + > > /* PSI-L source thread IDs, used for RX (DMA_DEV_TO_MEM) */ > > static struct psil_ep j721e_src_ep_map[] = { > > /* SA2UL */ > > @@ -138,6 +146,8 @@ static struct psil_ep j721e_src_ep_map[] = { > > PSIL_PDMA_XY_PKT(0x4707), > > PSIL_PDMA_XY_PKT(0x4708), > > PSIL_PDMA_XY_PKT(0x4709), > > + /* CSI2RX */ > > + PSIL_CSI2RX(0x4940), > > /* CPSW9 */ > > PSIL_ETHERNET(0x4a00), > > /* CPSW0 */ > > > > -- > Péter -- Regards, Pratyush Yadav Texas Instruments Inc.
WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <p.yadav@ti.com> To: "Péter Ujfalusi" <peter.ujfalusi@gmail.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Maxime Ripard <mripard@kernel.org>, Benoit Parrot <bparrot@ti.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Alexandre Courbot <acourbot@chromium.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Stanimir Varbanov <stanimir.varbanov@linaro.org>, Helen Koike <helen.koike@collabora.com>, Michael Tretter <m.tretter@pengutronix.de>, Peter Chen <peter.chen@nxp.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>, <dmaengine@vger.kernel.org>, Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Subject: Re: [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Date: Tue, 6 Apr 2021 20:39:44 +0530 [thread overview] Message-ID: <20210406150942.4kyjh2ehsvklupjr@ti.com> (raw) In-Reply-To: <78a5983c-04c8-4a4c-04fe-bb1f31e87375@gmail.com> On 04/04/21 04:24PM, Péter Ujfalusi wrote: > Hi Pratyush, > > On 3/30/21 8:33 PM, Pratyush Yadav wrote: > > The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory. It can > > have up to 32 threads but the current driver only supports using one. So > > add an entry for that one thread. > > If you are absolutely sure that the other threads are not going to be > used, then: The opposite in fact. I do expect other threads to be used in the future. But the current driver can only use one so I figured it is better to add just the thread that is currently needed and then I can always add the rest later. Why does this have to be a one-and-done deal? Is there anything wrong with adding the other threads when the driver can actually use them? > Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> > > but I would consider adding the other threads if there is a chance that > the cs2rx will need to support it in the future. > > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > > --- > > drivers/dma/ti/k3-psil-j721e.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/dma/ti/k3-psil-j721e.c b/drivers/dma/ti/k3-psil-j721e.c > > index 7580870ed746..19ffa31e6dc6 100644 > > --- a/drivers/dma/ti/k3-psil-j721e.c > > +++ b/drivers/dma/ti/k3-psil-j721e.c > > @@ -58,6 +58,14 @@ > > }, \ > > } > > > > +#define PSIL_CSI2RX(x) \ > > + { \ > > + .thread_id = x, \ > > + .ep_config = { \ > > + .ep_type = PSIL_EP_NATIVE, \ > > + }, \ > > + } > > + > > /* PSI-L source thread IDs, used for RX (DMA_DEV_TO_MEM) */ > > static struct psil_ep j721e_src_ep_map[] = { > > /* SA2UL */ > > @@ -138,6 +146,8 @@ static struct psil_ep j721e_src_ep_map[] = { > > PSIL_PDMA_XY_PKT(0x4707), > > PSIL_PDMA_XY_PKT(0x4708), > > PSIL_PDMA_XY_PKT(0x4709), > > + /* CSI2RX */ > > + PSIL_CSI2RX(0x4940), > > /* CPSW9 */ > > PSIL_ETHERNET(0x4a00), > > /* CPSW0 */ > > > > -- > Péter -- Regards, Pratyush Yadav Texas Instruments Inc. -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-04-06 15:10 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-30 17:33 [PATCH 00/16] CSI2RX support on J721E Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 01/16] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 02/16] phy: cdns-dphy: Prepare for Rx support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 03/16] phy: cdns-dphy: Allow setting mode Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:38 ` Laurent Pinchart 2021-04-02 10:38 ` Laurent Pinchart 2021-04-06 18:22 ` Pratyush Yadav 2021-04-06 18:22 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 04/16] phy: cdns-dphy: Add Rx support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 05/16] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 9:24 ` Chunfeng Yun 2021-03-31 9:24 ` Chunfeng Yun 2021-04-06 18:54 ` Pratyush Yadav 2021-04-06 18:54 ` Pratyush Yadav 2021-04-08 8:13 ` Chunfeng Yun 2021-04-08 8:13 ` Chunfeng Yun 2021-04-08 8:22 ` Tomi Valkeinen 2021-04-08 8:22 ` Tomi Valkeinen 2021-03-30 17:33 ` [PATCH 06/16] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 07/16] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 08/16] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 09/16] media: cadence: csi2rx: Turn subdev power on before starting stream Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:55 ` Laurent Pinchart 2021-04-02 10:55 ` Laurent Pinchart 2021-04-06 17:53 ` Pratyush Yadav 2021-04-06 17:53 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 10/16] media: cadence: csi2rx: Add wrappers for subdev calls Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:47 ` Laurent Pinchart 2021-04-02 10:47 ` Laurent Pinchart 2021-04-06 15:11 ` Pratyush Yadav 2021-04-06 15:11 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-04 13:24 ` Péter Ujfalusi 2021-04-04 13:24 ` Péter Ujfalusi 2021-04-06 15:09 ` Pratyush Yadav [this message] 2021-04-06 15:09 ` Pratyush Yadav 2021-04-06 15:33 ` Péter Ujfalusi 2021-04-06 15:33 ` Péter Ujfalusi 2021-04-06 16:55 ` Pratyush Yadav 2021-04-06 16:55 ` Pratyush Yadav 2021-04-06 17:10 ` Pratyush Yadav 2021-04-06 17:10 ` Pratyush Yadav 2021-04-06 19:13 ` Péter Ujfalusi 2021-04-06 19:13 ` Péter Ujfalusi 2021-03-30 17:33 ` [PATCH 12/16] dt-bindings: media: Add DT bindings for TI CSI2RX driver Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 13:40 ` Rob Herring 2021-03-31 13:40 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-04-02 10:01 ` Laurent Pinchart 2021-04-02 10:01 ` Laurent Pinchart 2021-04-02 10:53 ` Laurent Pinchart 2021-04-02 10:53 ` Laurent Pinchart 2021-04-06 18:15 ` Pratyush Yadav 2021-04-06 18:15 ` Pratyush Yadav 2021-04-06 18:13 ` Pratyush Yadav 2021-04-06 18:13 ` Pratyush Yadav 2021-04-06 18:00 ` Pratyush Yadav 2021-04-06 18:00 ` Pratyush Yadav 2021-04-01 15:52 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-03-30 17:33 ` [PATCH 13/16] media: ti-vpe: csi2rx: Add CSI2RX support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 6:06 ` Tomi Valkeinen 2021-03-31 6:06 ` Tomi Valkeinen 2021-03-31 15:44 ` Benoit Parrot 2021-03-31 15:44 ` Benoit Parrot 2021-03-31 15:50 ` Laurent Pinchart 2021-03-31 15:50 ` Laurent Pinchart 2021-04-06 15:05 ` Pratyush Yadav 2021-04-06 15:05 ` Pratyush Yadav 2021-04-04 13:38 ` Péter Ujfalusi 2021-04-04 13:38 ` Péter Ujfalusi 2021-03-30 17:33 ` [PATCH 14/16] dt-bindings: phy: Convert Cadence DPHY binding to YAML Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:23 ` Laurent Pinchart 2021-04-02 10:23 ` Laurent Pinchart 2021-04-06 18:51 ` Pratyush Yadav 2021-04-06 18:51 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 15/16] dt-bindings: phy: cdns,dphy: make clocks optional Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:31 ` Laurent Pinchart 2021-04-02 10:31 ` Laurent Pinchart 2021-04-06 18:48 ` Pratyush Yadav 2021-04-06 18:48 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 16/16] dt-bindings: phy: cdns,dphy: add power-domains property Pratyush Yadav 2021-03-30 17:33 ` [PATCH 16/16] dt-bindings: phy: cdns, dphy: " Pratyush Yadav 2021-04-02 10:35 ` [PATCH 16/16] dt-bindings: phy: cdns,dphy: " Laurent Pinchart 2021-04-02 10:35 ` Laurent Pinchart 2021-04-06 18:23 ` Pratyush Yadav 2021-04-06 18:23 ` Pratyush Yadav 2021-03-31 9:33 ` [PATCH 00/16] CSI2RX support on J721E Vinod Koul 2021-03-31 9:33 ` Vinod Koul 2021-03-31 11:40 ` Pratyush Yadav 2021-03-31 11:40 ` Pratyush Yadav 2021-03-31 13:06 ` Vinod Koul 2021-03-31 13:06 ` Vinod Koul 2021-03-31 13:51 ` Pratyush Yadav 2021-03-31 13:51 ` Pratyush Yadav 2021-04-02 10:57 ` Laurent Pinchart 2021-04-02 10:57 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210406150942.4kyjh2ehsvklupjr@ti.com \ --to=p.yadav@ti.com \ --cc=acourbot@chromium.org \ --cc=bparrot@ti.com \ --cc=chunfeng.yun@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=helen.koike@collabora.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kishon@ti.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=m.tretter@pengutronix.de \ --cc=mchehab@kernel.org \ --cc=mripard@kernel.org \ --cc=peter.chen@nxp.com \ --cc=peter.ujfalusi@gmail.com \ --cc=robh+dt@kernel.org \ --cc=stanimir.varbanov@linaro.org \ --cc=tomi.valkeinen@ideasonboard.com \ --cc=vigneshr@ti.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.