From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Pratyush Yadav <p.yadav@ti.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Maxime Ripard <mripard@kernel.org>, Benoit Parrot <bparrot@ti.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Alexandre Courbot <acourbot@chromium.org>, Stanimir Varbanov <stanimir.varbanov@linaro.org>, Helen Koike <helen.koike@collabora.com>, Michael Tretter <m.tretter@pengutronix.de>, Peter Chen <peter.chen@nxp.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, dmaengine@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Subject: Re: [PATCH 10/16] media: cadence: csi2rx: Add wrappers for subdev calls Date: Fri, 2 Apr 2021 13:47:11 +0300 [thread overview] Message-ID: <YGb2L7dq0fBma1or@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210330173348.30135-11-p.yadav@ti.com> Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:42PM +0530, Pratyush Yadav wrote: > When this bridge driver is being user by another platform driver, it > might want to call subdev operations like getting format, setting > format, enumerating format codes, etc. Add wrapper functions that pass > that call through to the sensor. > > Currently wrappers are added only for the ops used by TI's platform > driver. More can be added later as needed. This isn't the direction we want to take. For new platforms, propagation of subdev configuration should be handled by userspace, using the V4L2 userspace subdev API. This subdev should not call any subdev operation from its source other than .s_stream(). > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > --- > drivers/media/platform/cadence/cdns-csi2rx.c | 77 ++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c > index 3385e1bc213e..2e8bbc53cb8b 100644 > --- a/drivers/media/platform/cadence/cdns-csi2rx.c > +++ b/drivers/media/platform/cadence/cdns-csi2rx.c > @@ -408,12 +408,89 @@ static int csi2rx_s_stream(struct v4l2_subdev *subdev, int enable) > return ret; > } > > +static int csi2rx_g_frame_interval(struct v4l2_subdev *subdev, > + struct v4l2_subdev_frame_interval *fi) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, video, g_frame_interval, > + fi); > +} > + > +static int csi2rx_s_frame_interval(struct v4l2_subdev *subdev, > + struct v4l2_subdev_frame_interval *fi) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, video, s_frame_interval, > + fi); > +} > + > +static int csi2rx_enum_mbus_code(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_mbus_code_enum *code) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, enum_mbus_code, > + cfg, code); > +} > + > +static int csi2rx_get_fmt(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_format *fmt) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, get_fmt, cfg, fmt); > +} > + > +static int csi2rx_set_fmt(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_format *fmt) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, set_fmt, cfg, fmt); > +} > + > +static int csi2rx_enum_frame_size(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_frame_size_enum *fse) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, enum_frame_size, > + cfg, fse); > +} > + > +static int csi2rx_enum_frame_interval(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_frame_interval_enum *fie) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, enum_frame_interval, > + cfg, fie); > +} > + > static const struct v4l2_subdev_video_ops csi2rx_video_ops = { > .s_stream = csi2rx_s_stream, > + .g_frame_interval = csi2rx_g_frame_interval, > + .s_frame_interval = csi2rx_s_frame_interval, > +}; > + > +static const struct v4l2_subdev_pad_ops csi2rx_pad_ops = { > + .enum_mbus_code = csi2rx_enum_mbus_code, > + .get_fmt = csi2rx_get_fmt, > + .set_fmt = csi2rx_set_fmt, > + .enum_frame_size = csi2rx_enum_frame_size, > + .enum_frame_interval = csi2rx_enum_frame_interval, > }; > > static const struct v4l2_subdev_ops csi2rx_subdev_ops = { > .video = &csi2rx_video_ops, > + .pad = &csi2rx_pad_ops, > }; > > static int csi2rx_async_bound(struct v4l2_async_notifier *notifier, -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Pratyush Yadav <p.yadav@ti.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Maxime Ripard <mripard@kernel.org>, Benoit Parrot <bparrot@ti.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Alexandre Courbot <acourbot@chromium.org>, Stanimir Varbanov <stanimir.varbanov@linaro.org>, Helen Koike <helen.koike@collabora.com>, Michael Tretter <m.tretter@pengutronix.de>, Peter Chen <peter.chen@nxp.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, dmaengine@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Subject: Re: [PATCH 10/16] media: cadence: csi2rx: Add wrappers for subdev calls Date: Fri, 2 Apr 2021 13:47:11 +0300 [thread overview] Message-ID: <YGb2L7dq0fBma1or@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210330173348.30135-11-p.yadav@ti.com> Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:42PM +0530, Pratyush Yadav wrote: > When this bridge driver is being user by another platform driver, it > might want to call subdev operations like getting format, setting > format, enumerating format codes, etc. Add wrapper functions that pass > that call through to the sensor. > > Currently wrappers are added only for the ops used by TI's platform > driver. More can be added later as needed. This isn't the direction we want to take. For new platforms, propagation of subdev configuration should be handled by userspace, using the V4L2 userspace subdev API. This subdev should not call any subdev operation from its source other than .s_stream(). > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > --- > drivers/media/platform/cadence/cdns-csi2rx.c | 77 ++++++++++++++++++++ > 1 file changed, 77 insertions(+) > > diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c > index 3385e1bc213e..2e8bbc53cb8b 100644 > --- a/drivers/media/platform/cadence/cdns-csi2rx.c > +++ b/drivers/media/platform/cadence/cdns-csi2rx.c > @@ -408,12 +408,89 @@ static int csi2rx_s_stream(struct v4l2_subdev *subdev, int enable) > return ret; > } > > +static int csi2rx_g_frame_interval(struct v4l2_subdev *subdev, > + struct v4l2_subdev_frame_interval *fi) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, video, g_frame_interval, > + fi); > +} > + > +static int csi2rx_s_frame_interval(struct v4l2_subdev *subdev, > + struct v4l2_subdev_frame_interval *fi) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, video, s_frame_interval, > + fi); > +} > + > +static int csi2rx_enum_mbus_code(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_mbus_code_enum *code) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, enum_mbus_code, > + cfg, code); > +} > + > +static int csi2rx_get_fmt(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_format *fmt) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, get_fmt, cfg, fmt); > +} > + > +static int csi2rx_set_fmt(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_format *fmt) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, set_fmt, cfg, fmt); > +} > + > +static int csi2rx_enum_frame_size(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_frame_size_enum *fse) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, enum_frame_size, > + cfg, fse); > +} > + > +static int csi2rx_enum_frame_interval(struct v4l2_subdev *subdev, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_frame_interval_enum *fie) > +{ > + struct csi2rx_priv *csi2rx = v4l2_subdev_to_csi2rx(subdev); > + > + return v4l2_subdev_call(csi2rx->source_subdev, pad, enum_frame_interval, > + cfg, fie); > +} > + > static const struct v4l2_subdev_video_ops csi2rx_video_ops = { > .s_stream = csi2rx_s_stream, > + .g_frame_interval = csi2rx_g_frame_interval, > + .s_frame_interval = csi2rx_s_frame_interval, > +}; > + > +static const struct v4l2_subdev_pad_ops csi2rx_pad_ops = { > + .enum_mbus_code = csi2rx_enum_mbus_code, > + .get_fmt = csi2rx_get_fmt, > + .set_fmt = csi2rx_set_fmt, > + .enum_frame_size = csi2rx_enum_frame_size, > + .enum_frame_interval = csi2rx_enum_frame_interval, > }; > > static const struct v4l2_subdev_ops csi2rx_subdev_ops = { > .video = &csi2rx_video_ops, > + .pad = &csi2rx_pad_ops, > }; > > static int csi2rx_async_bound(struct v4l2_async_notifier *notifier, -- Regards, Laurent Pinchart -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-04-02 10:48 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-30 17:33 [PATCH 00/16] CSI2RX support on J721E Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 01/16] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 02/16] phy: cdns-dphy: Prepare for Rx support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 03/16] phy: cdns-dphy: Allow setting mode Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:38 ` Laurent Pinchart 2021-04-02 10:38 ` Laurent Pinchart 2021-04-06 18:22 ` Pratyush Yadav 2021-04-06 18:22 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 04/16] phy: cdns-dphy: Add Rx support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 05/16] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 9:24 ` Chunfeng Yun 2021-03-31 9:24 ` Chunfeng Yun 2021-04-06 18:54 ` Pratyush Yadav 2021-04-06 18:54 ` Pratyush Yadav 2021-04-08 8:13 ` Chunfeng Yun 2021-04-08 8:13 ` Chunfeng Yun 2021-04-08 8:22 ` Tomi Valkeinen 2021-04-08 8:22 ` Tomi Valkeinen 2021-03-30 17:33 ` [PATCH 06/16] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 07/16] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 08/16] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 09/16] media: cadence: csi2rx: Turn subdev power on before starting stream Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:55 ` Laurent Pinchart 2021-04-02 10:55 ` Laurent Pinchart 2021-04-06 17:53 ` Pratyush Yadav 2021-04-06 17:53 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 10/16] media: cadence: csi2rx: Add wrappers for subdev calls Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:47 ` Laurent Pinchart [this message] 2021-04-02 10:47 ` Laurent Pinchart 2021-04-06 15:11 ` Pratyush Yadav 2021-04-06 15:11 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-04 13:24 ` Péter Ujfalusi 2021-04-04 13:24 ` Péter Ujfalusi 2021-04-06 15:09 ` Pratyush Yadav 2021-04-06 15:09 ` Pratyush Yadav 2021-04-06 15:33 ` Péter Ujfalusi 2021-04-06 15:33 ` Péter Ujfalusi 2021-04-06 16:55 ` Pratyush Yadav 2021-04-06 16:55 ` Pratyush Yadav 2021-04-06 17:10 ` Pratyush Yadav 2021-04-06 17:10 ` Pratyush Yadav 2021-04-06 19:13 ` Péter Ujfalusi 2021-04-06 19:13 ` Péter Ujfalusi 2021-03-30 17:33 ` [PATCH 12/16] dt-bindings: media: Add DT bindings for TI CSI2RX driver Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 13:40 ` Rob Herring 2021-03-31 13:40 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-04-02 10:01 ` Laurent Pinchart 2021-04-02 10:01 ` Laurent Pinchart 2021-04-02 10:53 ` Laurent Pinchart 2021-04-02 10:53 ` Laurent Pinchart 2021-04-06 18:15 ` Pratyush Yadav 2021-04-06 18:15 ` Pratyush Yadav 2021-04-06 18:13 ` Pratyush Yadav 2021-04-06 18:13 ` Pratyush Yadav 2021-04-06 18:00 ` Pratyush Yadav 2021-04-06 18:00 ` Pratyush Yadav 2021-04-01 15:52 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-03-30 17:33 ` [PATCH 13/16] media: ti-vpe: csi2rx: Add CSI2RX support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 6:06 ` Tomi Valkeinen 2021-03-31 6:06 ` Tomi Valkeinen 2021-03-31 15:44 ` Benoit Parrot 2021-03-31 15:44 ` Benoit Parrot 2021-03-31 15:50 ` Laurent Pinchart 2021-03-31 15:50 ` Laurent Pinchart 2021-04-06 15:05 ` Pratyush Yadav 2021-04-06 15:05 ` Pratyush Yadav 2021-04-04 13:38 ` Péter Ujfalusi 2021-04-04 13:38 ` Péter Ujfalusi 2021-03-30 17:33 ` [PATCH 14/16] dt-bindings: phy: Convert Cadence DPHY binding to YAML Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:23 ` Laurent Pinchart 2021-04-02 10:23 ` Laurent Pinchart 2021-04-06 18:51 ` Pratyush Yadav 2021-04-06 18:51 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 15/16] dt-bindings: phy: cdns,dphy: make clocks optional Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:31 ` Laurent Pinchart 2021-04-02 10:31 ` Laurent Pinchart 2021-04-06 18:48 ` Pratyush Yadav 2021-04-06 18:48 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 16/16] dt-bindings: phy: cdns,dphy: add power-domains property Pratyush Yadav 2021-03-30 17:33 ` [PATCH 16/16] dt-bindings: phy: cdns, dphy: " Pratyush Yadav 2021-04-02 10:35 ` [PATCH 16/16] dt-bindings: phy: cdns,dphy: " Laurent Pinchart 2021-04-02 10:35 ` Laurent Pinchart 2021-04-06 18:23 ` Pratyush Yadav 2021-04-06 18:23 ` Pratyush Yadav 2021-03-31 9:33 ` [PATCH 00/16] CSI2RX support on J721E Vinod Koul 2021-03-31 9:33 ` Vinod Koul 2021-03-31 11:40 ` Pratyush Yadav 2021-03-31 11:40 ` Pratyush Yadav 2021-03-31 13:06 ` Vinod Koul 2021-03-31 13:06 ` Vinod Koul 2021-03-31 13:51 ` Pratyush Yadav 2021-03-31 13:51 ` Pratyush Yadav 2021-04-02 10:57 ` Laurent Pinchart 2021-04-02 10:57 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YGb2L7dq0fBma1or@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=acourbot@chromium.org \ --cc=bparrot@ti.com \ --cc=chunfeng.yun@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=helen.koike@collabora.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kishon@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=m.tretter@pengutronix.de \ --cc=mchehab@kernel.org \ --cc=mripard@kernel.org \ --cc=p.yadav@ti.com \ --cc=peter.chen@nxp.com \ --cc=peter.ujfalusi@gmail.com \ --cc=robh+dt@kernel.org \ --cc=stanimir.varbanov@linaro.org \ --cc=tomi.valkeinen@ideasonboard.com \ --cc=vigneshr@ti.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.