From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Pratyush Yadav <p.yadav@ti.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Maxime Ripard <mripard@kernel.org>, Benoit Parrot <bparrot@ti.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Alexandre Courbot <acourbot@chromium.org>, Stanimir Varbanov <stanimir.varbanov@linaro.org>, Helen Koike <helen.koike@collabora.com>, Michael Tretter <m.tretter@pengutronix.de>, Peter Chen <peter.chen@nxp.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, dmaengine@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Subject: Re: [PATCH 09/16] media: cadence: csi2rx: Turn subdev power on before starting stream Date: Fri, 2 Apr 2021 13:55:35 +0300 [thread overview] Message-ID: <YGb4J5q9N0ExOgn9@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210330173348.30135-10-p.yadav@ti.com> Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:41PM +0530, Pratyush Yadav wrote: > The subdevice power needs to be turned on before the stream is started. > Otherwise it might not be in the proper state to stream the data. Turn > it off when stopping the stream. The .s_power() operation is deprecated. Subdev drivers should control power internally in their .s_stream() operation, and they should use runtime PM to do so (this will allow usage of runtime PM autosuspend, to avoid expensive power off/on cycles when stopping and restarting video capture). > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > --- > drivers/media/platform/cadence/cdns-csi2rx.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c > index 7d1ac51e0698..3385e1bc213e 100644 > --- a/drivers/media/platform/cadence/cdns-csi2rx.c > +++ b/drivers/media/platform/cadence/cdns-csi2rx.c > @@ -256,6 +256,10 @@ static int csi2rx_start(struct csi2rx_priv *csi2rx) > > writel(reg, csi2rx->base + CSI2RX_STATIC_CFG_REG); > > + ret = v4l2_subdev_call(csi2rx->source_subdev, core, s_power, true); > + if (ret && ret != -ENOIOCTLCMD) > + goto err_disable_pclk; > + > ret = v4l2_subdev_call(csi2rx->source_subdev, video, s_stream, true); > if (ret) > goto err_disable_pclk; > @@ -358,6 +362,10 @@ static void csi2rx_stop(struct csi2rx_priv *csi2rx) > if (v4l2_subdev_call(csi2rx->source_subdev, video, s_stream, false)) > dev_warn(csi2rx->dev, "Couldn't disable our subdev\n"); > > + ret = v4l2_subdev_call(csi2rx->source_subdev, core, s_power, false); > + if (ret && ret != -ENOIOCTLCMD) > + dev_warn(csi2rx->dev, "Couldn't power off subdev\n"); > + > if (csi2rx->dphy) { > writel(0, csi2rx->base + CSI2RX_DPHY_LANE_CTRL_REG); > -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Pratyush Yadav <p.yadav@ti.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring <robh+dt@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Maxime Ripard <mripard@kernel.org>, Benoit Parrot <bparrot@ti.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Alexandre Courbot <acourbot@chromium.org>, Stanimir Varbanov <stanimir.varbanov@linaro.org>, Helen Koike <helen.koike@collabora.com>, Michael Tretter <m.tretter@pengutronix.de>, Peter Chen <peter.chen@nxp.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, dmaengine@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Subject: Re: [PATCH 09/16] media: cadence: csi2rx: Turn subdev power on before starting stream Date: Fri, 2 Apr 2021 13:55:35 +0300 [thread overview] Message-ID: <YGb4J5q9N0ExOgn9@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210330173348.30135-10-p.yadav@ti.com> Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:41PM +0530, Pratyush Yadav wrote: > The subdevice power needs to be turned on before the stream is started. > Otherwise it might not be in the proper state to stream the data. Turn > it off when stopping the stream. The .s_power() operation is deprecated. Subdev drivers should control power internally in their .s_stream() operation, and they should use runtime PM to do so (this will allow usage of runtime PM autosuspend, to avoid expensive power off/on cycles when stopping and restarting video capture). > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > --- > drivers/media/platform/cadence/cdns-csi2rx.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c > index 7d1ac51e0698..3385e1bc213e 100644 > --- a/drivers/media/platform/cadence/cdns-csi2rx.c > +++ b/drivers/media/platform/cadence/cdns-csi2rx.c > @@ -256,6 +256,10 @@ static int csi2rx_start(struct csi2rx_priv *csi2rx) > > writel(reg, csi2rx->base + CSI2RX_STATIC_CFG_REG); > > + ret = v4l2_subdev_call(csi2rx->source_subdev, core, s_power, true); > + if (ret && ret != -ENOIOCTLCMD) > + goto err_disable_pclk; > + > ret = v4l2_subdev_call(csi2rx->source_subdev, video, s_stream, true); > if (ret) > goto err_disable_pclk; > @@ -358,6 +362,10 @@ static void csi2rx_stop(struct csi2rx_priv *csi2rx) > if (v4l2_subdev_call(csi2rx->source_subdev, video, s_stream, false)) > dev_warn(csi2rx->dev, "Couldn't disable our subdev\n"); > > + ret = v4l2_subdev_call(csi2rx->source_subdev, core, s_power, false); > + if (ret && ret != -ENOIOCTLCMD) > + dev_warn(csi2rx->dev, "Couldn't power off subdev\n"); > + > if (csi2rx->dphy) { > writel(0, csi2rx->base + CSI2RX_DPHY_LANE_CTRL_REG); > -- Regards, Laurent Pinchart -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-04-02 10:56 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-30 17:33 [PATCH 00/16] CSI2RX support on J721E Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 01/16] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 02/16] phy: cdns-dphy: Prepare for Rx support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 03/16] phy: cdns-dphy: Allow setting mode Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:38 ` Laurent Pinchart 2021-04-02 10:38 ` Laurent Pinchart 2021-04-06 18:22 ` Pratyush Yadav 2021-04-06 18:22 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 04/16] phy: cdns-dphy: Add Rx support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 05/16] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 9:24 ` Chunfeng Yun 2021-03-31 9:24 ` Chunfeng Yun 2021-04-06 18:54 ` Pratyush Yadav 2021-04-06 18:54 ` Pratyush Yadav 2021-04-08 8:13 ` Chunfeng Yun 2021-04-08 8:13 ` Chunfeng Yun 2021-04-08 8:22 ` Tomi Valkeinen 2021-04-08 8:22 ` Tomi Valkeinen 2021-03-30 17:33 ` [PATCH 06/16] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 07/16] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 08/16] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 09/16] media: cadence: csi2rx: Turn subdev power on before starting stream Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:55 ` Laurent Pinchart [this message] 2021-04-02 10:55 ` Laurent Pinchart 2021-04-06 17:53 ` Pratyush Yadav 2021-04-06 17:53 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 10/16] media: cadence: csi2rx: Add wrappers for subdev calls Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:47 ` Laurent Pinchart 2021-04-02 10:47 ` Laurent Pinchart 2021-04-06 15:11 ` Pratyush Yadav 2021-04-06 15:11 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-04 13:24 ` Péter Ujfalusi 2021-04-04 13:24 ` Péter Ujfalusi 2021-04-06 15:09 ` Pratyush Yadav 2021-04-06 15:09 ` Pratyush Yadav 2021-04-06 15:33 ` Péter Ujfalusi 2021-04-06 15:33 ` Péter Ujfalusi 2021-04-06 16:55 ` Pratyush Yadav 2021-04-06 16:55 ` Pratyush Yadav 2021-04-06 17:10 ` Pratyush Yadav 2021-04-06 17:10 ` Pratyush Yadav 2021-04-06 19:13 ` Péter Ujfalusi 2021-04-06 19:13 ` Péter Ujfalusi 2021-03-30 17:33 ` [PATCH 12/16] dt-bindings: media: Add DT bindings for TI CSI2RX driver Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 13:40 ` Rob Herring 2021-03-31 13:40 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-04-02 10:01 ` Laurent Pinchart 2021-04-02 10:01 ` Laurent Pinchart 2021-04-02 10:53 ` Laurent Pinchart 2021-04-02 10:53 ` Laurent Pinchart 2021-04-06 18:15 ` Pratyush Yadav 2021-04-06 18:15 ` Pratyush Yadav 2021-04-06 18:13 ` Pratyush Yadav 2021-04-06 18:13 ` Pratyush Yadav 2021-04-06 18:00 ` Pratyush Yadav 2021-04-06 18:00 ` Pratyush Yadav 2021-04-01 15:52 ` Rob Herring 2021-04-01 15:52 ` Rob Herring 2021-03-30 17:33 ` [PATCH 13/16] media: ti-vpe: csi2rx: Add CSI2RX support Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-03-31 6:06 ` Tomi Valkeinen 2021-03-31 6:06 ` Tomi Valkeinen 2021-03-31 15:44 ` Benoit Parrot 2021-03-31 15:44 ` Benoit Parrot 2021-03-31 15:50 ` Laurent Pinchart 2021-03-31 15:50 ` Laurent Pinchart 2021-04-06 15:05 ` Pratyush Yadav 2021-04-06 15:05 ` Pratyush Yadav 2021-04-04 13:38 ` Péter Ujfalusi 2021-04-04 13:38 ` Péter Ujfalusi 2021-03-30 17:33 ` [PATCH 14/16] dt-bindings: phy: Convert Cadence DPHY binding to YAML Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:23 ` Laurent Pinchart 2021-04-02 10:23 ` Laurent Pinchart 2021-04-06 18:51 ` Pratyush Yadav 2021-04-06 18:51 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 15/16] dt-bindings: phy: cdns,dphy: make clocks optional Pratyush Yadav 2021-03-30 17:33 ` Pratyush Yadav 2021-04-02 10:31 ` Laurent Pinchart 2021-04-02 10:31 ` Laurent Pinchart 2021-04-06 18:48 ` Pratyush Yadav 2021-04-06 18:48 ` Pratyush Yadav 2021-03-30 17:33 ` [PATCH 16/16] dt-bindings: phy: cdns,dphy: add power-domains property Pratyush Yadav 2021-03-30 17:33 ` [PATCH 16/16] dt-bindings: phy: cdns, dphy: " Pratyush Yadav 2021-04-02 10:35 ` [PATCH 16/16] dt-bindings: phy: cdns,dphy: " Laurent Pinchart 2021-04-02 10:35 ` Laurent Pinchart 2021-04-06 18:23 ` Pratyush Yadav 2021-04-06 18:23 ` Pratyush Yadav 2021-03-31 9:33 ` [PATCH 00/16] CSI2RX support on J721E Vinod Koul 2021-03-31 9:33 ` Vinod Koul 2021-03-31 11:40 ` Pratyush Yadav 2021-03-31 11:40 ` Pratyush Yadav 2021-03-31 13:06 ` Vinod Koul 2021-03-31 13:06 ` Vinod Koul 2021-03-31 13:51 ` Pratyush Yadav 2021-03-31 13:51 ` Pratyush Yadav 2021-04-02 10:57 ` Laurent Pinchart 2021-04-02 10:57 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YGb4J5q9N0ExOgn9@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=acourbot@chromium.org \ --cc=bparrot@ti.com \ --cc=chunfeng.yun@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=helen.koike@collabora.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kishon@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=m.tretter@pengutronix.de \ --cc=mchehab@kernel.org \ --cc=mripard@kernel.org \ --cc=p.yadav@ti.com \ --cc=peter.chen@nxp.com \ --cc=peter.ujfalusi@gmail.com \ --cc=robh+dt@kernel.org \ --cc=stanimir.varbanov@linaro.org \ --cc=tomi.valkeinen@ideasonboard.com \ --cc=vigneshr@ti.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.