From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: simple-card-utils: Propagate errors on too many links
Date: Fri, 16 Apr 2021 16:55:15 +0100 [thread overview]
Message-ID: <20210416155515.GG5560@sirena.org.uk> (raw)
In-Reply-To: <1303b932-5226-0ee6-8f41-fd896908b045@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
On Fri, Apr 16, 2021 at 03:49:34PM +0100, Jon Hunter wrote:
>
> On 16/04/2021 08:11, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The DAI counting code doesn't propagate errors when the number of
> > maximum links is exceeded, which causes subsequent initialization code
> > to continue to run and that eventually leads to memory corruption with
> > the code trying to access memory that is out of bounds.
> >
> > Fix this by propgating errors when the maximum number of links is
>
> s/propgating/propagating
>
> > reached, which ensures that the driver fails to load and prevents the
> > memory corruption.
> >
> > Fixes: f2138aed231c ("ASoC: simple-card-utils: enable flexible CPU/Codec/Platform")
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: simple-card-utils: Propagate errors on too many links
Date: Fri, 16 Apr 2021 16:55:15 +0100 [thread overview]
Message-ID: <20210416155515.GG5560@sirena.org.uk> (raw)
In-Reply-To: <1303b932-5226-0ee6-8f41-fd896908b045@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
On Fri, Apr 16, 2021 at 03:49:34PM +0100, Jon Hunter wrote:
>
> On 16/04/2021 08:11, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The DAI counting code doesn't propagate errors when the number of
> > maximum links is exceeded, which causes subsequent initialization code
> > to continue to run and that eventually leads to memory corruption with
> > the code trying to access memory that is out of bounds.
> >
> > Fix this by propgating errors when the maximum number of links is
>
> s/propgating/propagating
>
> > reached, which ensures that the driver fails to load and prevents the
> > memory corruption.
> >
> > Fixes: f2138aed231c ("ASoC: simple-card-utils: enable flexible CPU/Codec/Platform")
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-16 15:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 7:11 [PATCH 1/2] ASoC: simple-card-utils: Propagate errors on too many links Thierry Reding
2021-04-16 7:11 ` Thierry Reding
2021-04-16 7:11 ` [PATCH 2/2] ASoC: simple-card-utils: Increase maximum number of links to 128 Thierry Reding
2021-04-16 7:11 ` Thierry Reding
2021-04-16 14:50 ` Jon Hunter
2021-04-16 14:50 ` Jon Hunter
2021-04-19 1:42 ` Kuninori Morimoto
2021-04-19 1:42 ` Kuninori Morimoto
2021-04-19 14:51 ` Thierry Reding
2021-04-19 14:51 ` Thierry Reding
2021-04-19 15:08 ` Mark Brown
2021-04-19 15:08 ` Mark Brown
2021-04-19 22:15 ` Kuninori Morimoto
2021-04-19 22:15 ` Kuninori Morimoto
2021-04-16 14:49 ` [PATCH 1/2] ASoC: simple-card-utils: Propagate errors on too many links Jon Hunter
2021-04-16 14:49 ` Jon Hunter
2021-04-16 15:55 ` Mark Brown [this message]
2021-04-16 15:55 ` Mark Brown
2021-04-16 16:01 ` Mark Brown
2021-04-16 16:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416155515.GG5560@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.