From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Jon Hunter <jonathanh@nvidia.com>,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: simple-card-utils: Increase maximum number of links to 128
Date: 20 Apr 2021 07:15:31 +0900 [thread overview]
Message-ID: <87k0ox53b0.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20210419150811.GC5645@sirena.org.uk>
Hi Thierry, Mark
> > The data structure seems to be only used during initialization, so
> > something like a kzalloc()/kfree() pair doesn't seem like it would
> > hurt much performance-wise. Add in the devm_ variants and the code
> > complexity should also remain moderately low.
>
> Yes, that'd be much better - ideally we wouldn't have a fixed limit of
> any kind but that's a more involved change and quite possibly more
> trouble than it's worth.
Using "fixed array style" was very easy for me (*^o^*).
OK, let's use kzalloc()/kfree() style.
I can try it.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH 2/2] ASoC: simple-card-utils: Increase maximum number of links to 128
Date: 20 Apr 2021 07:15:31 +0900 [thread overview]
Message-ID: <87k0ox53b0.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20210419150811.GC5645@sirena.org.uk>
Hi Thierry, Mark
> > The data structure seems to be only used during initialization, so
> > something like a kzalloc()/kfree() pair doesn't seem like it would
> > hurt much performance-wise. Add in the devm_ variants and the code
> > complexity should also remain moderately low.
>
> Yes, that'd be much better - ideally we wouldn't have a fixed limit of
> any kind but that's a more involved change and quite possibly more
> trouble than it's worth.
Using "fixed array style" was very easy for me (*^o^*).
OK, let's use kzalloc()/kfree() style.
I can try it.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2021-04-19 22:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 7:11 [PATCH 1/2] ASoC: simple-card-utils: Propagate errors on too many links Thierry Reding
2021-04-16 7:11 ` Thierry Reding
2021-04-16 7:11 ` [PATCH 2/2] ASoC: simple-card-utils: Increase maximum number of links to 128 Thierry Reding
2021-04-16 7:11 ` Thierry Reding
2021-04-16 14:50 ` Jon Hunter
2021-04-16 14:50 ` Jon Hunter
2021-04-19 1:42 ` Kuninori Morimoto
2021-04-19 1:42 ` Kuninori Morimoto
2021-04-19 14:51 ` Thierry Reding
2021-04-19 14:51 ` Thierry Reding
2021-04-19 15:08 ` Mark Brown
2021-04-19 15:08 ` Mark Brown
2021-04-19 22:15 ` Kuninori Morimoto [this message]
2021-04-19 22:15 ` Kuninori Morimoto
2021-04-16 14:49 ` [PATCH 1/2] ASoC: simple-card-utils: Propagate errors on too many links Jon Hunter
2021-04-16 14:49 ` Jon Hunter
2021-04-16 15:55 ` Mark Brown
2021-04-16 15:55 ` Mark Brown
2021-04-16 16:01 ` Mark Brown
2021-04-16 16:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0ox53b0.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.