From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Jon Hunter <jonathanh@nvidia.com>,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: simple-card-utils: Increase maximum number of links to 128
Date: 19 Apr 2021 10:42:55 +0900 [thread overview]
Message-ID: <8735vn59sw.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20210416071147.2149109-2-thierry.reding@gmail.com>
Hi Thierry
> From: Thierry Reding <treding@nvidia.com>
>
> On Tegra186 and later, the number of links can go up to 72, so bump the
> maximum number of links to the next power of two (128).
>
> Fixes: f2138aed231c ("ASoC: simple-card-utils: enable flexible CPU/Codec/Platform")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
(snip)
> +#define SNDRV_MAX_LINKS 128
> +
> struct link_info {
> int link; /* number of link */
> int cpu; /* turn for CPU / Codec */
> - struct prop_nums num[SNDRV_MINOR_DEVICES];
> + struct prop_nums num[SNDRV_MAX_LINKS];
> };
How many numbers do you really need ?
Because simple-card needs many parameters,
thus I will get below warning.
# It is not yet happen on upstream kernel, but will be
warning: the frame size of 2280 bytes is larger than 2048 bytes [-Wframe-larger-than=]
This warning doesn't appear if SNDRV_MAX_LINKS was 64.
Can we reduce it ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-tegra@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH 2/2] ASoC: simple-card-utils: Increase maximum number of links to 128
Date: 19 Apr 2021 10:42:55 +0900 [thread overview]
Message-ID: <8735vn59sw.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20210416071147.2149109-2-thierry.reding@gmail.com>
Hi Thierry
> From: Thierry Reding <treding@nvidia.com>
>
> On Tegra186 and later, the number of links can go up to 72, so bump the
> maximum number of links to the next power of two (128).
>
> Fixes: f2138aed231c ("ASoC: simple-card-utils: enable flexible CPU/Codec/Platform")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
(snip)
> +#define SNDRV_MAX_LINKS 128
> +
> struct link_info {
> int link; /* number of link */
> int cpu; /* turn for CPU / Codec */
> - struct prop_nums num[SNDRV_MINOR_DEVICES];
> + struct prop_nums num[SNDRV_MAX_LINKS];
> };
How many numbers do you really need ?
Because simple-card needs many parameters,
thus I will get below warning.
# It is not yet happen on upstream kernel, but will be
warning: the frame size of 2280 bytes is larger than 2048 bytes [-Wframe-larger-than=]
This warning doesn't appear if SNDRV_MAX_LINKS was 64.
Can we reduce it ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2021-04-19 1:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 7:11 [PATCH 1/2] ASoC: simple-card-utils: Propagate errors on too many links Thierry Reding
2021-04-16 7:11 ` Thierry Reding
2021-04-16 7:11 ` [PATCH 2/2] ASoC: simple-card-utils: Increase maximum number of links to 128 Thierry Reding
2021-04-16 7:11 ` Thierry Reding
2021-04-16 14:50 ` Jon Hunter
2021-04-16 14:50 ` Jon Hunter
2021-04-19 1:42 ` Kuninori Morimoto [this message]
2021-04-19 1:42 ` Kuninori Morimoto
2021-04-19 14:51 ` Thierry Reding
2021-04-19 14:51 ` Thierry Reding
2021-04-19 15:08 ` Mark Brown
2021-04-19 15:08 ` Mark Brown
2021-04-19 22:15 ` Kuninori Morimoto
2021-04-19 22:15 ` Kuninori Morimoto
2021-04-16 14:49 ` [PATCH 1/2] ASoC: simple-card-utils: Propagate errors on too many links Jon Hunter
2021-04-16 14:49 ` Jon Hunter
2021-04-16 15:55 ` Mark Brown
2021-04-16 15:55 ` Mark Brown
2021-04-16 16:01 ` Mark Brown
2021-04-16 16:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735vn59sw.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.