From: Matthew Brost <matthew.brost@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>
Cc: <daniel.vetter@ffwll.ch>
Subject: [PATCH 00/22] Clean up GuC CI failures, simplify locking, and kernel DOC
Date: Mon, 16 Aug 2021 06:51:17 -0700 [thread overview]
Message-ID: <20210816135139.10060-1-matthew.brost@intel.com> (raw)
Daniel Vetter pointed out that locking in the GuC submission code was
overly complicated, let's clean this up a bit before introducing more
features in the GuC submission backend.
Also fix some CI failures, port fixes from our internal tree, and add a
few more selftests for coverage.
Lastly, add some kernel DOC explaining how the GuC submission backend
works.
v2: Fix logic error in 'Workaround reset G2H is received after schedule
done G2H', don't propagate errors to dependent fences in execlists
submissiom, resolve checkpatch issues, resend to correct lists
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Matthew Brost (22):
drm/i915/guc: Fix blocked context accounting
drm/i915/guc: Fix outstanding G2H accounting
drm/i915/guc: Unwind context requests in reverse order
drm/i915/guc: Don't drop ce->guc_active.lock when unwinding context
drm/i915/guc: Workaround reset G2H is received after schedule done G2H
drm/i915/execlists: Do not propagate errors to dependent fences
drm/i915/selftests: Add a cancel request selftest that triggers a
reset
drm/i915/guc: Don't enable scheduling on a banned context, guc_id
invalid, not registered
drm/i915/selftests: Fix memory corruption in live_lrc_isolation
drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H
drm/i915/guc: Take context ref when cancelling request
drm/i915/guc: Don't touch guc_state.sched_state without a lock
drm/i915/guc: Reset LRC descriptor if register returns -ENODEV
drm/i915: Allocate error capture in atomic context
drm/i915/guc: Flush G2H work queue during reset
drm/i915/guc: Release submit fence from an IRQ
drm/i915/guc: Move guc_blocked fence to struct guc_state
drm/i915/guc: Rework and simplify locking
drm/i915/guc: Proper xarray usage for contexts_lookup
drm/i915/guc: Drop pin count check trick between sched_disable and
re-pin
drm/i915/guc: Move GuC priority fields in context under guc_active
drm/i915/guc: Add GuC kernel doc
drivers/gpu/drm/i915/gt/intel_context.c | 5 +-
drivers/gpu/drm/i915/gt/intel_context_types.h | 68 +-
.../drm/i915/gt/intel_execlists_submission.c | 4 -
drivers/gpu/drm/i915/gt/selftest_lrc.c | 29 +-
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 19 +-
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 690 +++++++++++-------
drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 126 ++++
drivers/gpu/drm/i915/i915_gpu_error.c | 37 +-
drivers/gpu/drm/i915/i915_request.h | 23 +-
drivers/gpu/drm/i915/i915_trace.h | 8 +-
.../drm/i915/selftests/i915_live_selftests.h | 1 +
drivers/gpu/drm/i915/selftests/i915_request.c | 100 +++
.../i915/selftests/intel_scheduler_helpers.c | 12 +
.../i915/selftests/intel_scheduler_helpers.h | 2 +
14 files changed, 813 insertions(+), 311 deletions(-)
create mode 100644 drivers/gpu/drm/i915/gt/uc/selftest_guc.c
--
2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Brost <matthew.brost@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>
Cc: <daniel.vetter@ffwll.ch>
Subject: [Intel-gfx] [PATCH 00/22] Clean up GuC CI failures, simplify locking, and kernel DOC
Date: Mon, 16 Aug 2021 06:51:17 -0700 [thread overview]
Message-ID: <20210816135139.10060-1-matthew.brost@intel.com> (raw)
Daniel Vetter pointed out that locking in the GuC submission code was
overly complicated, let's clean this up a bit before introducing more
features in the GuC submission backend.
Also fix some CI failures, port fixes from our internal tree, and add a
few more selftests for coverage.
Lastly, add some kernel DOC explaining how the GuC submission backend
works.
v2: Fix logic error in 'Workaround reset G2H is received after schedule
done G2H', don't propagate errors to dependent fences in execlists
submissiom, resolve checkpatch issues, resend to correct lists
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Matthew Brost (22):
drm/i915/guc: Fix blocked context accounting
drm/i915/guc: Fix outstanding G2H accounting
drm/i915/guc: Unwind context requests in reverse order
drm/i915/guc: Don't drop ce->guc_active.lock when unwinding context
drm/i915/guc: Workaround reset G2H is received after schedule done G2H
drm/i915/execlists: Do not propagate errors to dependent fences
drm/i915/selftests: Add a cancel request selftest that triggers a
reset
drm/i915/guc: Don't enable scheduling on a banned context, guc_id
invalid, not registered
drm/i915/selftests: Fix memory corruption in live_lrc_isolation
drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H
drm/i915/guc: Take context ref when cancelling request
drm/i915/guc: Don't touch guc_state.sched_state without a lock
drm/i915/guc: Reset LRC descriptor if register returns -ENODEV
drm/i915: Allocate error capture in atomic context
drm/i915/guc: Flush G2H work queue during reset
drm/i915/guc: Release submit fence from an IRQ
drm/i915/guc: Move guc_blocked fence to struct guc_state
drm/i915/guc: Rework and simplify locking
drm/i915/guc: Proper xarray usage for contexts_lookup
drm/i915/guc: Drop pin count check trick between sched_disable and
re-pin
drm/i915/guc: Move GuC priority fields in context under guc_active
drm/i915/guc: Add GuC kernel doc
drivers/gpu/drm/i915/gt/intel_context.c | 5 +-
drivers/gpu/drm/i915/gt/intel_context_types.h | 68 +-
.../drm/i915/gt/intel_execlists_submission.c | 4 -
drivers/gpu/drm/i915/gt/selftest_lrc.c | 29 +-
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 19 +-
.../gpu/drm/i915/gt/uc/intel_guc_submission.c | 690 +++++++++++-------
drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 126 ++++
drivers/gpu/drm/i915/i915_gpu_error.c | 37 +-
drivers/gpu/drm/i915/i915_request.h | 23 +-
drivers/gpu/drm/i915/i915_trace.h | 8 +-
.../drm/i915/selftests/i915_live_selftests.h | 1 +
drivers/gpu/drm/i915/selftests/i915_request.c | 100 +++
.../i915/selftests/intel_scheduler_helpers.c | 12 +
.../i915/selftests/intel_scheduler_helpers.h | 2 +
14 files changed, 813 insertions(+), 311 deletions(-)
create mode 100644 drivers/gpu/drm/i915/gt/uc/selftest_guc.c
--
2.32.0
next reply other threads:[~2021-08-16 13:57 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 13:51 Matthew Brost [this message]
2021-08-16 13:51 ` [Intel-gfx] [PATCH 00/22] Clean up GuC CI failures, simplify locking, and kernel DOC Matthew Brost
2021-08-16 13:51 ` [PATCH 01/22] drm/i915/guc: Fix blocked context accounting Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 02/22] drm/i915/guc: Fix outstanding G2H accounting Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 9:39 ` Daniel Vetter
2021-08-17 9:39 ` [Intel-gfx] " Daniel Vetter
2021-08-17 18:17 ` Matthew Brost
2021-08-17 18:17 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 03/22] drm/i915/guc: Unwind context requests in reverse order Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 04/22] drm/i915/guc: Don't drop ce->guc_active.lock when unwinding context Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 05/22] drm/i915/guc: Workaround reset G2H is received after schedule done G2H Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 9:32 ` Daniel Vetter
2021-08-17 9:32 ` [Intel-gfx] " Daniel Vetter
2021-08-17 15:03 ` Matthew Brost
2021-08-17 15:03 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 06/22] drm/i915/execlists: Do not propagate errors to dependent fences Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 9:21 ` Daniel Vetter
2021-08-17 9:21 ` [Intel-gfx] " Daniel Vetter
2021-08-17 15:08 ` Matthew Brost
2021-08-17 15:08 ` [Intel-gfx] " Matthew Brost
2021-08-17 15:49 ` Daniel Vetter
2021-08-17 15:49 ` [Intel-gfx] " Daniel Vetter
2021-08-16 13:51 ` [PATCH 07/22] drm/i915/selftests: Add a cancel request selftest that triggers a reset Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 08/22] drm/i915/guc: Don't enable scheduling on a banned context, guc_id invalid, not registered Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 9:47 ` Daniel Vetter
2021-08-17 9:47 ` [Intel-gfx] " Daniel Vetter
2021-08-17 9:57 ` Daniel Vetter
2021-08-17 9:57 ` [Intel-gfx] " Daniel Vetter
2021-08-17 16:44 ` Matthew Brost
2021-08-17 16:44 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 09/22] drm/i915/selftests: Fix memory corruption in live_lrc_isolation Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 10/22] drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 11/22] drm/i915/guc: Take context ref when cancelling request Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 12/22] drm/i915/guc: Don't touch guc_state.sched_state without a lock Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 7:21 ` kernel test robot
2021-08-17 7:21 ` kernel test robot
2021-08-17 7:21 ` [Intel-gfx] " kernel test robot
2021-08-16 13:51 ` [PATCH 13/22] drm/i915/guc: Reset LRC descriptor if register returns -ENODEV Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 14/22] drm/i915: Allocate error capture in atomic context Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 10:06 ` Daniel Vetter
2021-08-17 10:06 ` [Intel-gfx] " Daniel Vetter
2021-08-17 16:12 ` Matthew Brost
2021-08-17 16:12 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 15/22] drm/i915/guc: Flush G2H work queue during reset Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 10:06 ` Daniel Vetter
2021-08-16 13:51 ` [PATCH 16/22] drm/i915/guc: Release submit fence from an IRQ Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 10:08 ` Daniel Vetter
2021-08-17 10:08 ` [Intel-gfx] " Daniel Vetter
2021-08-16 13:51 ` [PATCH 17/22] drm/i915/guc: Move guc_blocked fence to struct guc_state Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 10:10 ` Daniel Vetter
2021-08-17 10:10 ` [Intel-gfx] " Daniel Vetter
2021-08-16 13:51 ` [PATCH 18/22] drm/i915/guc: Rework and simplify locking Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 10:15 ` Daniel Vetter
2021-08-17 10:15 ` [Intel-gfx] " Daniel Vetter
2021-08-17 15:30 ` Matthew Brost
2021-08-17 15:30 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 19/22] drm/i915/guc: Proper xarray usage for contexts_lookup Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 10:27 ` Daniel Vetter
2021-08-17 15:26 ` Matthew Brost
2021-08-17 17:13 ` Daniel Vetter
2021-08-17 17:13 ` Matthew Brost
2021-08-16 13:51 ` [PATCH 20/22] drm/i915/guc: Drop pin count check trick between sched_disable and re-pin Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 21/22] drm/i915/guc: Move GuC priority fields in context under guc_active Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-16 13:51 ` [PATCH 22/22] drm/i915/guc: Add GuC kernel doc Matthew Brost
2021-08-16 13:51 ` [Intel-gfx] " Matthew Brost
2021-08-17 11:11 ` Daniel Vetter
2021-08-17 11:11 ` [Intel-gfx] " Daniel Vetter
2021-08-17 16:36 ` Matthew Brost
2021-08-17 16:36 ` [Intel-gfx] " Matthew Brost
2021-08-17 17:20 ` Daniel Vetter
2021-08-17 17:20 ` [Intel-gfx] " Daniel Vetter
2021-08-17 17:27 ` Michal Wajdeczko
2021-08-17 17:27 ` [Intel-gfx] " Michal Wajdeczko
2021-08-17 17:34 ` Daniel Vetter
2021-08-17 17:34 ` [Intel-gfx] " Daniel Vetter
2021-08-17 20:41 ` Michal Wajdeczko
2021-08-17 20:41 ` [Intel-gfx] " Michal Wajdeczko
2021-08-17 21:49 ` Daniel Vetter
2021-08-17 21:49 ` [Intel-gfx] " Daniel Vetter
2021-08-17 12:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clean up GuC CI failures, simplify locking, and kernel DOC (rev2) Patchwork
2021-08-17 12:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-08-17 13:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-17 14:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816135139.10060-1-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.