From: Serge Semin <fancer.lancer@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
nandhini.srikandan@intel.com, robh+dt@kernel.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, mgross@linux.intel.com,
kris.pan@intel.com, kenchappa.demakkanavar@intel.com,
furong.zhou@intel.com, mallikarjunappa.sangannavar@intel.com,
mahesh.r.vaidya@intel.com, rashmi.a@intel.com
Subject: Re: [PATCH v3 2/5] spi: dw: Add SSTE support for DWC SSI controller
Date: Thu, 11 Nov 2021 17:16:34 +0300 [thread overview]
Message-ID: <20211111141634.je2lppv5yjhsannb@mobilestation> (raw)
In-Reply-To: <YY0hFOr0SnDDDuSf@sirena.org.uk>
On Thu, Nov 11, 2021 at 01:56:36PM +0000, Mark Brown wrote:
> On Thu, Nov 11, 2021 at 02:51:58PM +0800, nandhini.srikandan@intel.com wrote:
> > From: Nandhini Srikandan <nandhini.srikandan@intel.com>
> >
> > Add support for Slave Select Toggle Enable (SSTE) in DWC SSI controller
> > via DTS. The slave select line will toggle between consecutive data frames,
> > with the serial clock being held to its default value while slave
> > select line is high.
>
> This should be controlled by SPI_CS_WORD.
Oh, yeah. I've absolutely forgotten about that flag. Indeed then there
is no need in implementing a separate DT-property. In this case the
patchset will need to be fixed a bit: remove the DT-part of the
sste-feature and alter the dw_spi_setup() method so to take the
SPI_CS_WORD flag into account.
Nandhini, sorry about a wrong advice on v2. It seems v4 will be
required...
-Sergey
next prev parent reply other threads:[~2021-11-11 14:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 6:51 [PATCH v3 0/5] Add support for Intel Thunder Bay SPI controller nandhini.srikandan
2021-11-11 6:51 ` [PATCH v3 1/5] dt-bindings: spi: Add SSTE support for DWC SSI controller nandhini.srikandan
2021-11-11 13:53 ` Mark Brown
2021-11-11 14:31 ` Serge Semin
2021-11-11 15:01 ` Mark Brown
2021-11-11 15:06 ` Serge Semin
2021-11-17 12:05 ` Srikandan, Nandhini
2021-11-11 6:51 ` [PATCH v3 2/5] spi: dw: " nandhini.srikandan
2021-11-11 13:56 ` Mark Brown
2021-11-11 14:16 ` Serge Semin [this message]
2021-11-11 14:42 ` Serge Semin
2021-11-11 6:51 ` [PATCH v3 3/5] spi: dw: Add support for master mode selection " nandhini.srikandan
2021-11-11 14:16 ` Mark Brown
2021-11-11 14:52 ` Serge Semin
2021-11-11 15:14 ` Mark Brown
2021-11-11 16:06 ` Serge Semin
2021-11-11 16:25 ` Mark Brown
2021-11-16 19:15 ` Serge Semin
2021-11-17 11:59 ` Srikandan, Nandhini
2021-12-08 11:03 ` Srikandan, Nandhini
2021-12-09 8:40 ` Serge Semin
2021-11-11 6:52 ` [PATCH v3 4/5] dt-bindings: spi: Add bindings for Intel Thunder Bay SoC nandhini.srikandan
2021-11-19 16:55 ` Rob Herring
2021-11-11 6:52 ` [PATCH v3 5/5] spi: dw: Add support for Intel Thunder Bay SPI controller nandhini.srikandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211111141634.je2lppv5yjhsannb@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=furong.zhou@intel.com \
--cc=kenchappa.demakkanavar@intel.com \
--cc=kris.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mahesh.r.vaidya@intel.com \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=nandhini.srikandan@intel.com \
--cc=rashmi.a@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.