From: Leo Yan <leo.yan@linaro.org> To: Arnaldo Carvalho de Melo <acme@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>, German Gomez <german.gomez@arm.com>, Ali Saidi <alisaidi@amazon.com>, Joe Mario <jmario@redhat.com>, Adam Li <adam.li@amperecomputing.com>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan <leo.yan@linaro.org>, Kajol Jain <kjain@linux.ibm.com> Subject: [PATCH v5 01/17] perf: Add SNOOP_PEER flag to perf mem data struct Date: Sat, 4 Jun 2022 12:28:04 +0800 [thread overview] Message-ID: <20220604042820.2270916-2-leo.yan@linaro.org> (raw) In-Reply-To: <20220604042820.2270916-1-leo.yan@linaro.org> From: Ali Saidi <alisaidi@amazon.com> Add a flag to the perf mem data struct to signal that a request caused a cache-to-cache transfer of a line from a peer of the requestor and wasn't sourced from a lower cache level. The line being moved from one peer cache to another has latency and performance implications. On Arm64 Neoverse systems the data source can indicate a cache-to-cache transfer but not if the line is dirty or clean, so instead of overloading HITM define a new flag that indicates this type of transfer. Signed-off-by: Ali Saidi <alisaidi@amazon.com> Reviewed-by: Leo Yan <leo.yan@linaro.org> Reviewed-by: Kajol Jain<kjain@linux.ibm.com> --- include/uapi/linux/perf_event.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index d37629dbad72..7b88bfd097dc 100644 --- a/include/uapi/linux/perf_event.h +++ b/include/uapi/linux/perf_event.h @@ -1310,7 +1310,7 @@ union perf_mem_data_src { #define PERF_MEM_SNOOP_SHIFT 19 #define PERF_MEM_SNOOPX_FWD 0x01 /* forward */ -/* 1 free */ +#define PERF_MEM_SNOOPX_PEER 0x02 /* xfer from peer */ #define PERF_MEM_SNOOPX_SHIFT 38 /* locked instruction */ -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Leo Yan <leo.yan@linaro.org> To: Arnaldo Carvalho de Melo <acme@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Ian Rogers <irogers@google.com>, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>, German Gomez <german.gomez@arm.com>, Ali Saidi <alisaidi@amazon.com>, Joe Mario <jmario@redhat.com>, Adam Li <adam.li@amperecomputing.com>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Leo Yan <leo.yan@linaro.org>, Kajol Jain <kjain@linux.ibm.com> Subject: [PATCH v5 01/17] perf: Add SNOOP_PEER flag to perf mem data struct Date: Sat, 4 Jun 2022 12:28:04 +0800 [thread overview] Message-ID: <20220604042820.2270916-2-leo.yan@linaro.org> (raw) In-Reply-To: <20220604042820.2270916-1-leo.yan@linaro.org> From: Ali Saidi <alisaidi@amazon.com> Add a flag to the perf mem data struct to signal that a request caused a cache-to-cache transfer of a line from a peer of the requestor and wasn't sourced from a lower cache level. The line being moved from one peer cache to another has latency and performance implications. On Arm64 Neoverse systems the data source can indicate a cache-to-cache transfer but not if the line is dirty or clean, so instead of overloading HITM define a new flag that indicates this type of transfer. Signed-off-by: Ali Saidi <alisaidi@amazon.com> Reviewed-by: Leo Yan <leo.yan@linaro.org> Reviewed-by: Kajol Jain<kjain@linux.ibm.com> --- include/uapi/linux/perf_event.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index d37629dbad72..7b88bfd097dc 100644 --- a/include/uapi/linux/perf_event.h +++ b/include/uapi/linux/perf_event.h @@ -1310,7 +1310,7 @@ union perf_mem_data_src { #define PERF_MEM_SNOOP_SHIFT 19 #define PERF_MEM_SNOOPX_FWD 0x01 /* forward */ -/* 1 free */ +#define PERF_MEM_SNOOPX_PEER 0x02 /* xfer from peer */ #define PERF_MEM_SNOOPX_SHIFT 38 /* locked instruction */ -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-04 4:29 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-04 4:28 [PATCH v5 00/17] perf c2c: Support data source and display for Arm64 Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` Leo Yan [this message] 2022-06-04 4:28 ` [PATCH v5 01/17] perf: Add SNOOP_PEER flag to perf mem data struct Leo Yan 2022-07-20 18:45 ` Arnaldo Carvalho de Melo 2022-07-20 18:45 ` Arnaldo Carvalho de Melo 2022-07-20 18:46 ` Arnaldo Carvalho de Melo 2022-07-20 18:46 ` Arnaldo Carvalho de Melo 2022-07-21 0:27 ` Leo Yan 2022-07-21 0:27 ` Leo Yan 2022-08-08 16:40 ` ping " Arnaldo Carvalho de Melo 2022-06-04 4:28 ` [PATCH v5 02/17] perf tools: sync addition of PERF_MEM_SNOOPX_PEER Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 03/17] perf mem: Print snoop peer flag Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 04/17] perf arm-spe: Don't set data source if it's not a memory operation Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 05/17] perf arm-spe: Use SPE data source for neoverse cores Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 06/17] perf mem: Add statistics for peer snooping Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 07/17] perf c2c: Output " Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 08/17] perf c2c: Add dimensions for peer load operations Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 09/17] perf c2c: Add dimensions of peer metrics for cache line view Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 10/17] perf c2c: Add mean dimensions for peer operations Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 11/17] perf c2c: Use explicit names for display macros Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 12/17] perf c2c: Rename dimension from 'percent_hitm' to 'percent_costly_snoop' Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 13/17] perf c2c: Refactor node header Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 14/17] perf c2c: Refactor display string Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 15/17] perf c2c: Sort on peer snooping for load operations Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 16/17] perf c2c: Use 'peer' as default display for Arm64 Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-06-04 4:28 ` [PATCH v5 17/17] perf c2c: Update documentation for new display option 'peer' Leo Yan 2022-06-04 4:28 ` Leo Yan 2022-08-10 13:37 ` [PATCH v5 00/17] perf c2c: Support data source and display for Arm64 Arnaldo Carvalho de Melo 2022-08-10 13:37 ` Arnaldo Carvalho de Melo 2022-08-11 6:41 ` Leo Yan 2022-08-11 6:41 ` Leo Yan 2022-08-12 12:43 ` Arnaldo Carvalho de Melo 2022-08-12 12:43 ` Arnaldo Carvalho de Melo 2022-08-12 15:20 ` Leo Yan 2022-08-12 15:20 ` Leo Yan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220604042820.2270916-2-leo.yan@linaro.org \ --to=leo.yan@linaro.org \ --cc=acme@kernel.org \ --cc=adam.li@amperecomputing.com \ --cc=alisaidi@amazon.com \ --cc=german.gomez@arm.com \ --cc=irogers@google.com \ --cc=james.clark@arm.com \ --cc=jmario@redhat.com \ --cc=john.garry@huawei.com \ --cc=jolsa@kernel.org \ --cc=kjain@linux.ibm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.