From: Sudeep Holla <sudeep.holla@arm.com>
To: Conor Dooley <mail@conchuod.ie>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Conor Dooley <conor.dooley@microchip.com>,
valentina.fernandezalanis@microchip.com,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Qing Wang <wangqing@vivo.com>, Rob Herring <robh+dt@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Pierre Gondois <pierre.gondois@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH v6 09/21] arch_topology: Add support to parse and detect cache attributes
Date: Tue, 19 Jul 2022 16:05:13 +0100 [thread overview]
Message-ID: <20220719150513.a525arh663qlhkob@bogus> (raw)
In-Reply-To: <73f9d00c-b64c-7c70-c49f-99d3894fad24@conchuod.ie>
On Tue, Jul 19, 2022 at 03:37:22PM +0100, Conor Dooley wrote:
> On 19/07/2022 15:22, Geert Uytterhoeven wrote:
> > Hi Sudeep,
> >
>
> Hey Geert,
>
[...]
> >
> > This is triggered
> >
> > Early cacheinfo failed, ret = -12
> >
> > on all my RV64 platforms (K210, PolarFire, StarLight).
>
> This should be fixed by Sudeeps most recent patchset, at least
> it was when I tested it!
> https://lore.kernel.org/all/20220713133344.1201247-1-sudeep.holla@arm.com/
>
Conor you beat me in the response speed :).
> > -12 = -ENOMEM.
> >
> > The boot continues regardless, and the K210 even has enough spare
> > RAM after boot to run "ls", unlike two weeks ago ;-)
> >
Yes Conor initially reported this and I suspected something to do with
per-cpu allocation as the early cacheinfo failed but succeeded in device
initcall level. However when fixing some hotplug issue, I moved the
detection of cache attributes on all cpus from boot cpu to individual
CPUs in the secondary startup which seem to fix the issue as I assume the
per-cpu allocation is ready to use at that stage.
However we still have one pending issue[0] to address even after [1], but
that doesn't affect DT platforms.
--
Regards,
Sudeep
[0] https://lore.kernel.org/all/20220718174151.GA462603@roeck-us.net/
[1] https://lore.kernel.org/all/20220715102609.2160689-1-sudeep.holla@arm.com/
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Conor Dooley <mail@conchuod.ie>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Conor Dooley <conor.dooley@microchip.com>,
valentina.fernandezalanis@microchip.com,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Qing Wang <wangqing@vivo.com>, Rob Herring <robh+dt@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Pierre Gondois <pierre.gondois@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH v6 09/21] arch_topology: Add support to parse and detect cache attributes
Date: Tue, 19 Jul 2022 16:05:13 +0100 [thread overview]
Message-ID: <20220719150513.a525arh663qlhkob@bogus> (raw)
In-Reply-To: <73f9d00c-b64c-7c70-c49f-99d3894fad24@conchuod.ie>
On Tue, Jul 19, 2022 at 03:37:22PM +0100, Conor Dooley wrote:
> On 19/07/2022 15:22, Geert Uytterhoeven wrote:
> > Hi Sudeep,
> >
>
> Hey Geert,
>
[...]
> >
> > This is triggered
> >
> > Early cacheinfo failed, ret = -12
> >
> > on all my RV64 platforms (K210, PolarFire, StarLight).
>
> This should be fixed by Sudeeps most recent patchset, at least
> it was when I tested it!
> https://lore.kernel.org/all/20220713133344.1201247-1-sudeep.holla@arm.com/
>
Conor you beat me in the response speed :).
> > -12 = -ENOMEM.
> >
> > The boot continues regardless, and the K210 even has enough spare
> > RAM after boot to run "ls", unlike two weeks ago ;-)
> >
Yes Conor initially reported this and I suspected something to do with
per-cpu allocation as the early cacheinfo failed but succeeded in device
initcall level. However when fixing some hotplug issue, I moved the
detection of cache attributes on all cpus from boot cpu to individual
CPUs in the secondary startup which seem to fix the issue as I assume the
per-cpu allocation is ready to use at that stage.
However we still have one pending issue[0] to address even after [1], but
that doesn't affect DT platforms.
--
Regards,
Sudeep
[0] https://lore.kernel.org/all/20220718174151.GA462603@roeck-us.net/
[1] https://lore.kernel.org/all/20220715102609.2160689-1-sudeep.holla@arm.com/
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Conor Dooley <mail@conchuod.ie>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Conor Dooley <conor.dooley@microchip.com>,
valentina.fernandezalanis@microchip.com,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Qing Wang <wangqing@vivo.com>, Rob Herring <robh+dt@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Pierre Gondois <pierre.gondois@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH v6 09/21] arch_topology: Add support to parse and detect cache attributes
Date: Tue, 19 Jul 2022 16:05:13 +0100 [thread overview]
Message-ID: <20220719150513.a525arh663qlhkob@bogus> (raw)
In-Reply-To: <73f9d00c-b64c-7c70-c49f-99d3894fad24@conchuod.ie>
On Tue, Jul 19, 2022 at 03:37:22PM +0100, Conor Dooley wrote:
> On 19/07/2022 15:22, Geert Uytterhoeven wrote:
> > Hi Sudeep,
> >
>
> Hey Geert,
>
[...]
> >
> > This is triggered
> >
> > Early cacheinfo failed, ret = -12
> >
> > on all my RV64 platforms (K210, PolarFire, StarLight).
>
> This should be fixed by Sudeeps most recent patchset, at least
> it was when I tested it!
> https://lore.kernel.org/all/20220713133344.1201247-1-sudeep.holla@arm.com/
>
Conor you beat me in the response speed :).
> > -12 = -ENOMEM.
> >
> > The boot continues regardless, and the K210 even has enough spare
> > RAM after boot to run "ls", unlike two weeks ago ;-)
> >
Yes Conor initially reported this and I suspected something to do with
per-cpu allocation as the early cacheinfo failed but succeeded in device
initcall level. However when fixing some hotplug issue, I moved the
detection of cache attributes on all cpus from boot cpu to individual
CPUs in the secondary startup which seem to fix the issue as I assume the
per-cpu allocation is ready to use at that stage.
However we still have one pending issue[0] to address even after [1], but
that doesn't affect DT platforms.
--
Regards,
Sudeep
[0] https://lore.kernel.org/all/20220718174151.GA462603@roeck-us.net/
[1] https://lore.kernel.org/all/20220715102609.2160689-1-sudeep.holla@arm.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-19 15:05 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 10:15 [PATCH v6 00/21] arch_topology: Updates to add socket support and fix cluster ids Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 01/21] ACPI: PPTT: Use table offset as fw_token instead of virtual address Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 02/21] cacheinfo: Use of_cpu_device_node_get instead cpu_dev->of_node Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 03/21] cacheinfo: Add helper to access any cache index for a given CPU Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 04/21] cacheinfo: Move cache_leaves_are_shared out of CONFIG_OF Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 05/21] cacheinfo: Add support to check if last level cache(LLC) is valid or shared Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 06/21] cacheinfo: Allow early detection and population of cache attributes Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 07/21] cacheinfo: Use cache identifiers to check if the caches are shared if available Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 08/21] cacheinfo: Align checks in cache_shared_cpu_map_{setup,remove} for readability Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 09/21] arch_topology: Add support to parse and detect cache attributes Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-19 14:22 ` Geert Uytterhoeven
2022-07-19 14:22 ` Geert Uytterhoeven
2022-07-19 14:22 ` Geert Uytterhoeven
2022-07-19 14:37 ` Conor Dooley
2022-07-19 14:37 ` Conor Dooley
2022-07-19 14:37 ` Conor Dooley
2022-07-19 15:05 ` Sudeep Holla [this message]
2022-07-19 15:05 ` Sudeep Holla
2022-07-19 15:05 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 10/21] arch_topology: Use the last level cache information from the cacheinfo Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 11/21] arm64: topology: Remove redundant setting of llc_id in CPU topology Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 12/21] arch_topology: Drop LLC identifier stash from the " Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 13/21] arch_topology: Set thread sibling cpumask only within the cluster Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 14/21] arch_topology: Check for non-negative value rather than -1 for IDs validity Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` [PATCH v6 15/21] arch_topology: Avoid parsing through all the CPUs once a outlier CPU is found Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:15 ` Sudeep Holla
2022-07-04 10:16 ` [PATCH v6 16/21] arch_topology: Don't set cluster identifier as physical package identifier Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` [PATCH v6 17/21] arch_topology: Limit span of cpu_clustergroup_mask() Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-08 0:10 ` Darren Hart
2022-07-08 0:10 ` Darren Hart
2022-07-08 0:10 ` Darren Hart
2022-07-08 8:04 ` Sudeep Holla
2022-07-08 8:04 ` Sudeep Holla
2022-07-08 8:04 ` Sudeep Holla
2022-07-08 16:27 ` Darren Hart
2022-07-08 16:27 ` Darren Hart
2022-07-08 16:27 ` Darren Hart
2022-07-08 9:05 ` Ionela Voinescu
2022-07-08 9:05 ` Ionela Voinescu
2022-07-08 9:05 ` Ionela Voinescu
2022-07-08 16:14 ` Darren Hart
2022-07-08 16:14 ` Darren Hart
2022-07-08 16:14 ` Darren Hart
2022-07-04 10:16 ` [PATCH v6 18/21] arch_topology: Set cluster identifier in each core/thread from /cpu-map Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` [PATCH v6 19/21] arch_topology: Add support for parsing sockets in /cpu-map Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` [PATCH v6 20/21] arch_topology: Warn that topology for nested clusters is not supported Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` [PATCH v6 21/21] ACPI: Remove the unused find_acpi_cpu_cache_topology() Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 10:16 ` Sudeep Holla
2022-07-04 15:10 ` [PATCH v6 00/21] arch_topology: Updates to add socket support and fix cluster ids Conor.Dooley
2022-07-04 15:10 ` Conor.Dooley
2022-07-04 15:10 ` Conor.Dooley
2022-07-04 15:20 ` Sudeep Holla
2022-07-04 15:20 ` Sudeep Holla
2022-07-04 15:20 ` Sudeep Holla
[not found] ` <507c6b64-fc23-3eea-e4c1-4d426025d658@inria.fr>
2022-07-05 19:06 ` Conor.Dooley
2022-07-05 19:06 ` Conor.Dooley
2022-07-05 19:06 ` Conor.Dooley
2022-07-05 20:07 ` Sudeep Holla
2022-07-05 20:07 ` Sudeep Holla
2022-07-05 20:07 ` Sudeep Holla
2022-07-05 20:14 ` Conor.Dooley
2022-07-05 20:14 ` Conor.Dooley
2022-07-05 20:14 ` Conor.Dooley
2022-07-05 20:22 ` Sudeep Holla
2022-07-05 20:22 ` Sudeep Holla
2022-07-05 20:22 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719150513.a525arh663qlhkob@bogus \
--to=sudeep.holla@arm.com \
--cc=conor.dooley@microchip.com \
--cc=dietmar.eggemann@arm.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mail@conchuod.ie \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=valentina.fernandezalanis@microchip.com \
--cc=vincent.guittot@linaro.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.