From: Marijn Suijten <marijn.suijten@somainline.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Loic Poulain <loic.poulain@linaro.org>,
Rajeev Nandan <quic_rajeevny@quicinc.com>,
Sean Paul <sean@poorly.run>, Stephen Boyd <swboyd@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660
Date: Wed, 3 Aug 2022 16:25:12 +0200 [thread overview]
Message-ID: <20220803142512.f5d2umiymqwbxfzt@SoMainline.org> (raw)
In-Reply-To: <20220802153434.v3.2.I94b3c3e412b7c208061349f05659e126483171b1@changeid>
On 2022-08-02 15:37:34, Douglas Anderson wrote:
> 1 regulators is specified listed but the number 2 is specified. This
> presumably means we try to get a regulator with no name. Fix it.
>
> Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660")
This should be:
Fixes: 462f7017a691 ("drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660")
The original patch included two regulators; that "fix" patch removed
"vdd".
After that:
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - ("Fix number of regulators for SDM660") new for v2.
>
> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> index 02000a7b7a18..72c018e26f47 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> @@ -148,7 +148,7 @@ static const char * const dsi_sdm660_bus_clk_names[] = {
> static const struct msm_dsi_config sdm660_dsi_cfg = {
> .io_offset = DSI_6G_REG_SHIFT,
> .reg_cfg = {
> - .num = 2,
> + .num = 1,
> .regs = {
> {"vdda", 12560, 4 }, /* 1.2 V */
> },
> --
> 2.37.1.455.g008518b4e5-goog
>
WARNING: multiple messages have this Message-ID (diff)
From: Marijn Suijten <marijn.suijten@somainline.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Sean Paul <sean@poorly.run>,
Loic Poulain <loic.poulain@linaro.org>,
David Airlie <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>,
Mark Brown <broonie@kernel.org>,
Rajeev Nandan <quic_rajeevny@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660
Date: Wed, 3 Aug 2022 16:25:12 +0200 [thread overview]
Message-ID: <20220803142512.f5d2umiymqwbxfzt@SoMainline.org> (raw)
In-Reply-To: <20220802153434.v3.2.I94b3c3e412b7c208061349f05659e126483171b1@changeid>
On 2022-08-02 15:37:34, Douglas Anderson wrote:
> 1 regulators is specified listed but the number 2 is specified. This
> presumably means we try to get a regulator with no name. Fix it.
>
> Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660")
This should be:
Fixes: 462f7017a691 ("drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660")
The original patch included two regulators; that "fix" patch removed
"vdd".
After that:
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - ("Fix number of regulators for SDM660") new for v2.
>
> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> index 02000a7b7a18..72c018e26f47 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> @@ -148,7 +148,7 @@ static const char * const dsi_sdm660_bus_clk_names[] = {
> static const struct msm_dsi_config sdm660_dsi_cfg = {
> .io_offset = DSI_6G_REG_SHIFT,
> .reg_cfg = {
> - .num = 2,
> + .num = 1,
> .regs = {
> {"vdda", 12560, 4 }, /* 1.2 V */
> },
> --
> 2.37.1.455.g008518b4e5-goog
>
next prev parent reply other threads:[~2022-08-03 14:25 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 22:37 [PATCH v3 0/6] drm/msm/dsi regulator improvements Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-02 22:37 ` [PATCH v3 1/6] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:01 ` Dmitry Baryshkov
2022-08-03 7:01 ` Dmitry Baryshkov
2022-08-04 0:12 ` Abhinav Kumar
2022-08-04 0:12 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660 Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:02 ` Dmitry Baryshkov
2022-08-03 7:02 ` Dmitry Baryshkov
2022-08-03 14:25 ` Marijn Suijten [this message]
2022-08-03 14:25 ` Marijn Suijten
2022-08-04 0:14 ` Abhinav Kumar
2022-08-04 0:14 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 3/6] drm/msm/dsi: Don't set a load before disabling a regulator Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:07 ` Dmitry Baryshkov
2022-08-03 7:07 ` Dmitry Baryshkov
2022-08-04 0:16 ` Abhinav Kumar
2022-08-04 0:16 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:12 ` Dmitry Baryshkov
2022-08-03 7:12 ` Dmitry Baryshkov
2022-08-03 13:50 ` Doug Anderson
2022-08-03 13:50 ` Doug Anderson
2022-08-04 0:18 ` Abhinav Kumar
2022-08-04 0:18 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 5/6] drm/msm/dsi: Take advantage of devm_regulator_bulk_get_const() Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:18 ` Dmitry Baryshkov
2022-08-03 7:18 ` Dmitry Baryshkov
2022-08-03 13:53 ` Doug Anderson
2022-08-03 13:53 ` Doug Anderson
2022-08-04 2:00 ` Abhinav Kumar
2022-08-04 2:00 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 6/6] drm/msm/dsi: Improve dsi_phy_driver_probe() probe error handling Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:32 ` Dmitry Baryshkov
2022-08-03 7:32 ` Dmitry Baryshkov
2022-08-03 13:54 ` Doug Anderson
2022-08-03 13:54 ` Doug Anderson
2022-08-04 2:13 ` Abhinav Kumar
2022-08-04 2:13 ` Abhinav Kumar
2022-08-03 7:37 ` [PATCH v3 0/6] drm/msm/dsi regulator improvements Dmitry Baryshkov
2022-08-03 7:37 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220803142512.f5d2umiymqwbxfzt@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_rajeevny@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.