From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Douglas Anderson <dianders@chromium.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Archit Taneja <architt@codeaurora.org>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Konrad Dybcio <konrad.dybcio@somainline.org>, Loic Poulain <loic.poulain@linaro.org>, Rajeev Nandan <quic_rajeevny@quicinc.com>, Sean Paul <sean@poorly.run>, Stephen Boyd <swboyd@chromium.org>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg Date: Wed, 3 Aug 2022 10:01:14 +0300 [thread overview] Message-ID: <6723fb49-4768-c40b-0d00-6be594adccf0@linaro.org> (raw) In-Reply-To: <20220802153434.v3.1.I1056ee3f77f71287f333279efe4c85f88d403f65@changeid> On 03/08/2022 01:37, Douglas Anderson wrote: > 3 regulators are specified listed but the number 2 is specified. Fix > it. > > Fixes: 3a3ff88a0fc1 ("drm/msm/dsi: Add 8x96 info in dsi_cfg") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > > (no changes since v2) > > Changes in v2: > - ("Fix number of regulators for msm8996_dsi_cfg") new for v2. > > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index 2c23324a2296..02000a7b7a18 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -109,7 +109,7 @@ static const char * const dsi_8996_bus_clk_names[] = { > static const struct msm_dsi_config msm8996_dsi_cfg = { > .io_offset = DSI_6G_REG_SHIFT, > .reg_cfg = { > - .num = 2, > + .num = 3, > .regs = { > {"vdda", 18160, 1 }, /* 1.25 V */ > {"vcca", 17000, 32 }, /* 0.925 V */ -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Douglas Anderson <dianders@chromium.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Sean Paul <sean@poorly.run>, Archit Taneja <architt@codeaurora.org>, Loic Poulain <loic.poulain@linaro.org>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, Konrad Dybcio <konrad.dybcio@somainline.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd <swboyd@chromium.org>, Mark Brown <broonie@kernel.org>, Rajeev Nandan <quic_rajeevny@quicinc.com>, freedreno@lists.freedesktop.org Subject: Re: [PATCH v3 1/6] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg Date: Wed, 3 Aug 2022 10:01:14 +0300 [thread overview] Message-ID: <6723fb49-4768-c40b-0d00-6be594adccf0@linaro.org> (raw) In-Reply-To: <20220802153434.v3.1.I1056ee3f77f71287f333279efe4c85f88d403f65@changeid> On 03/08/2022 01:37, Douglas Anderson wrote: > 3 regulators are specified listed but the number 2 is specified. Fix > it. > > Fixes: 3a3ff88a0fc1 ("drm/msm/dsi: Add 8x96 info in dsi_cfg") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > > (no changes since v2) > > Changes in v2: > - ("Fix number of regulators for msm8996_dsi_cfg") new for v2. > > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index 2c23324a2296..02000a7b7a18 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -109,7 +109,7 @@ static const char * const dsi_8996_bus_clk_names[] = { > static const struct msm_dsi_config msm8996_dsi_cfg = { > .io_offset = DSI_6G_REG_SHIFT, > .reg_cfg = { > - .num = 2, > + .num = 3, > .regs = { > {"vdda", 18160, 1 }, /* 1.25 V */ > {"vcca", 17000, 32 }, /* 0.925 V */ -- With best wishes Dmitry
next prev parent reply other threads:[~2022-08-03 7:01 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-02 22:37 [PATCH v3 0/6] drm/msm/dsi regulator improvements Douglas Anderson 2022-08-02 22:37 ` Douglas Anderson 2022-08-02 22:37 ` [PATCH v3 1/6] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg Douglas Anderson 2022-08-02 22:37 ` Douglas Anderson 2022-08-03 7:01 ` Dmitry Baryshkov [this message] 2022-08-03 7:01 ` Dmitry Baryshkov 2022-08-04 0:12 ` Abhinav Kumar 2022-08-04 0:12 ` Abhinav Kumar 2022-08-02 22:37 ` [PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660 Douglas Anderson 2022-08-02 22:37 ` Douglas Anderson 2022-08-03 7:02 ` Dmitry Baryshkov 2022-08-03 7:02 ` Dmitry Baryshkov 2022-08-03 14:25 ` Marijn Suijten 2022-08-03 14:25 ` Marijn Suijten 2022-08-04 0:14 ` Abhinav Kumar 2022-08-04 0:14 ` Abhinav Kumar 2022-08-02 22:37 ` [PATCH v3 3/6] drm/msm/dsi: Don't set a load before disabling a regulator Douglas Anderson 2022-08-02 22:37 ` Douglas Anderson 2022-08-03 7:07 ` Dmitry Baryshkov 2022-08-03 7:07 ` Dmitry Baryshkov 2022-08-04 0:16 ` Abhinav Kumar 2022-08-04 0:16 ` Abhinav Kumar 2022-08-02 22:37 ` [PATCH v3 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load Douglas Anderson 2022-08-02 22:37 ` Douglas Anderson 2022-08-03 7:12 ` Dmitry Baryshkov 2022-08-03 7:12 ` Dmitry Baryshkov 2022-08-03 13:50 ` Doug Anderson 2022-08-03 13:50 ` Doug Anderson 2022-08-04 0:18 ` Abhinav Kumar 2022-08-04 0:18 ` Abhinav Kumar 2022-08-02 22:37 ` [PATCH v3 5/6] drm/msm/dsi: Take advantage of devm_regulator_bulk_get_const() Douglas Anderson 2022-08-02 22:37 ` Douglas Anderson 2022-08-03 7:18 ` Dmitry Baryshkov 2022-08-03 7:18 ` Dmitry Baryshkov 2022-08-03 13:53 ` Doug Anderson 2022-08-03 13:53 ` Doug Anderson 2022-08-04 2:00 ` Abhinav Kumar 2022-08-04 2:00 ` Abhinav Kumar 2022-08-02 22:37 ` [PATCH v3 6/6] drm/msm/dsi: Improve dsi_phy_driver_probe() probe error handling Douglas Anderson 2022-08-02 22:37 ` Douglas Anderson 2022-08-03 7:32 ` Dmitry Baryshkov 2022-08-03 7:32 ` Dmitry Baryshkov 2022-08-03 13:54 ` Doug Anderson 2022-08-03 13:54 ` Doug Anderson 2022-08-04 2:13 ` Abhinav Kumar 2022-08-04 2:13 ` Abhinav Kumar 2022-08-03 7:37 ` [PATCH v3 0/6] drm/msm/dsi regulator improvements Dmitry Baryshkov 2022-08-03 7:37 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6723fb49-4768-c40b-0d00-6be594adccf0@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@linux.ie \ --cc=architt@codeaurora.org \ --cc=broonie@kernel.org \ --cc=daniel@ffwll.ch \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=konrad.dybcio@somainline.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=loic.poulain@linaro.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_rajeevny@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.