From: Doug Anderson <dianders@chromium.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Sean Paul <sean@poorly.run>, Vinod Koul <vkoul@kernel.org>,
Jonathan Marek <jonathan@marek.ca>,
David Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Stephen Boyd <swboyd@chromium.org>,
Mark Brown <broonie@kernel.org>,
Rajeev Nandan <quic_rajeevny@quicinc.com>,
freedreno <freedreno@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load
Date: Wed, 3 Aug 2022 06:50:35 -0700 [thread overview]
Message-ID: <CAD=FV=XWxMis61zouPeAoTUC6xYz7rSUC33wdvyLii0Cd2j4Ww@mail.gmail.com> (raw)
In-Reply-To: <232f875a-4986-300a-f1e8-18f2da3a8fc6@linaro.org>
Hi,
On Wed, Aug 3, 2022 at 12:12 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On 03/08/2022 01:37, Douglas Anderson wrote:
> > As of commit 6eabfc018e8d ("regulator: core: Allow specifying an
> > initial load w/ the bulk API") we can now specify the initial load in
> > the bulk data rather than having to manually call regulator_set_load()
> > on each regulator. Let's use it.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> It might have been better, if the previous patch had only removed the
> load_setting on disable and inlined the dsi_host_regulator_disable().
> Then this patch would drop the regulator_set_load() from
> dsi_host_regulator_enable() path and inline it. Then it would have been
> more obvious that after these two changes the time when we set loads is
> not changed.
Seems like I should post a v4 to update the commit message of the
final patch in the series, but I'm going to leave this the way it is
since the end result is the same. Originally when I wrote the series I
didn't know if the new regulator API changes would be accepted, so the
previous patch did the most cleanup it could do with the old API. ;-)
-Doug
WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Mark Brown <broonie@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
freedreno <freedreno@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Jonathan Marek <jonathan@marek.ca>,
Rajeev Nandan <quic_rajeevny@quicinc.com>,
Sean Paul <sean@poorly.run>, Stephen Boyd <swboyd@chromium.org>,
Vinod Koul <vkoul@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load
Date: Wed, 3 Aug 2022 06:50:35 -0700 [thread overview]
Message-ID: <CAD=FV=XWxMis61zouPeAoTUC6xYz7rSUC33wdvyLii0Cd2j4Ww@mail.gmail.com> (raw)
In-Reply-To: <232f875a-4986-300a-f1e8-18f2da3a8fc6@linaro.org>
Hi,
On Wed, Aug 3, 2022 at 12:12 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On 03/08/2022 01:37, Douglas Anderson wrote:
> > As of commit 6eabfc018e8d ("regulator: core: Allow specifying an
> > initial load w/ the bulk API") we can now specify the initial load in
> > the bulk data rather than having to manually call regulator_set_load()
> > on each regulator. Let's use it.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> It might have been better, if the previous patch had only removed the
> load_setting on disable and inlined the dsi_host_regulator_disable().
> Then this patch would drop the regulator_set_load() from
> dsi_host_regulator_enable() path and inline it. Then it would have been
> more obvious that after these two changes the time when we set loads is
> not changed.
Seems like I should post a v4 to update the commit message of the
final patch in the series, but I'm going to leave this the way it is
since the end result is the same. Originally when I wrote the series I
didn't know if the new regulator API changes would be accepted, so the
previous patch did the most cleanup it could do with the old API. ;-)
-Doug
next prev parent reply other threads:[~2022-08-03 13:51 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 22:37 [PATCH v3 0/6] drm/msm/dsi regulator improvements Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-02 22:37 ` [PATCH v3 1/6] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:01 ` Dmitry Baryshkov
2022-08-03 7:01 ` Dmitry Baryshkov
2022-08-04 0:12 ` Abhinav Kumar
2022-08-04 0:12 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660 Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:02 ` Dmitry Baryshkov
2022-08-03 7:02 ` Dmitry Baryshkov
2022-08-03 14:25 ` Marijn Suijten
2022-08-03 14:25 ` Marijn Suijten
2022-08-04 0:14 ` Abhinav Kumar
2022-08-04 0:14 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 3/6] drm/msm/dsi: Don't set a load before disabling a regulator Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:07 ` Dmitry Baryshkov
2022-08-03 7:07 ` Dmitry Baryshkov
2022-08-04 0:16 ` Abhinav Kumar
2022-08-04 0:16 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:12 ` Dmitry Baryshkov
2022-08-03 7:12 ` Dmitry Baryshkov
2022-08-03 13:50 ` Doug Anderson [this message]
2022-08-03 13:50 ` Doug Anderson
2022-08-04 0:18 ` Abhinav Kumar
2022-08-04 0:18 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 5/6] drm/msm/dsi: Take advantage of devm_regulator_bulk_get_const() Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:18 ` Dmitry Baryshkov
2022-08-03 7:18 ` Dmitry Baryshkov
2022-08-03 13:53 ` Doug Anderson
2022-08-03 13:53 ` Doug Anderson
2022-08-04 2:00 ` Abhinav Kumar
2022-08-04 2:00 ` Abhinav Kumar
2022-08-02 22:37 ` [PATCH v3 6/6] drm/msm/dsi: Improve dsi_phy_driver_probe() probe error handling Douglas Anderson
2022-08-02 22:37 ` Douglas Anderson
2022-08-03 7:32 ` Dmitry Baryshkov
2022-08-03 7:32 ` Dmitry Baryshkov
2022-08-03 13:54 ` Doug Anderson
2022-08-03 13:54 ` Doug Anderson
2022-08-04 2:13 ` Abhinav Kumar
2022-08-04 2:13 ` Abhinav Kumar
2022-08-03 7:37 ` [PATCH v3 0/6] drm/msm/dsi regulator improvements Dmitry Baryshkov
2022-08-03 7:37 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XWxMis61zouPeAoTUC6xYz7rSUC33wdvyLii0Cd2j4Ww@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_rajeevny@quicinc.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.