All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Taube <mr.bossman075@gmail.com>
To: linux-riscv@lists.infradead.org
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jesse Taube <Mr.Bossman075@gmail.com>,
	Yimin Gu <ustcymgu@gmail.com>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Waldemar Brodkorb <wbx@openadk.org>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Conor Dooley <conor.dooley@microchip.com>,
	kernel test robot <lkp@intel.com>
Subject: [PATCH v3 1/3] clk: k210: remove an implicit 64-bit division
Date: Tue, 28 Feb 2023 19:26:55 -0500	[thread overview]
Message-ID: <20230301002657.352637-2-Mr.Bossman075@gmail.com> (raw)
In-Reply-To: <20230301002657.352637-1-Mr.Bossman075@gmail.com>

From: Conor Dooley <conor.dooley@microchip.com>

The K210 clock driver depends on SOC_CANAAN, which is only selectable
when !MMU on RISC-V. !MMU is not possible on 32-bit yet, but patches
have been sent for its enabling. The kernel test robot reported this
implicit 64-bit division there.

Replace the implicit division with an explicit one.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/linux-riscv/202301201538.zNlqgE4L-lkp@intel.com/
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
---
V1->V2:
 - new commit
V2->V3:
 - No change
---
 drivers/clk/clk-k210.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-k210.c b/drivers/clk/clk-k210.c
index 67a7cb3503c3..4eed667eddaf 100644
--- a/drivers/clk/clk-k210.c
+++ b/drivers/clk/clk-k210.c
@@ -495,7 +495,7 @@ static unsigned long k210_pll_get_rate(struct clk_hw *hw,
 	f = FIELD_GET(K210_PLL_CLKF, reg) + 1;
 	od = FIELD_GET(K210_PLL_CLKOD, reg) + 1;
 
-	return (u64)parent_rate * f / (r * od);
+	return div_u64((u64)parent_rate * f, r * od);
 }
 
 static const struct clk_ops k210_pll_ops = {
-- 
2.39.0


WARNING: multiple messages have this Message-ID (diff)
From: Jesse Taube <mr.bossman075@gmail.com>
To: linux-riscv@lists.infradead.org
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jesse Taube <Mr.Bossman075@gmail.com>,
	Yimin Gu <ustcymgu@gmail.com>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Waldemar Brodkorb <wbx@openadk.org>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Conor Dooley <conor.dooley@microchip.com>,
	kernel test robot <lkp@intel.com>
Subject: [PATCH v3 1/3] clk: k210: remove an implicit 64-bit division
Date: Tue, 28 Feb 2023 19:26:55 -0500	[thread overview]
Message-ID: <20230301002657.352637-2-Mr.Bossman075@gmail.com> (raw)
In-Reply-To: <20230301002657.352637-1-Mr.Bossman075@gmail.com>

From: Conor Dooley <conor.dooley@microchip.com>

The K210 clock driver depends on SOC_CANAAN, which is only selectable
when !MMU on RISC-V. !MMU is not possible on 32-bit yet, but patches
have been sent for its enabling. The kernel test robot reported this
implicit 64-bit division there.

Replace the implicit division with an explicit one.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/linux-riscv/202301201538.zNlqgE4L-lkp@intel.com/
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
---
V1->V2:
 - new commit
V2->V3:
 - No change
---
 drivers/clk/clk-k210.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-k210.c b/drivers/clk/clk-k210.c
index 67a7cb3503c3..4eed667eddaf 100644
--- a/drivers/clk/clk-k210.c
+++ b/drivers/clk/clk-k210.c
@@ -495,7 +495,7 @@ static unsigned long k210_pll_get_rate(struct clk_hw *hw,
 	f = FIELD_GET(K210_PLL_CLKF, reg) + 1;
 	od = FIELD_GET(K210_PLL_CLKOD, reg) + 1;
 
-	return (u64)parent_rate * f / (r * od);
+	return div_u64((u64)parent_rate * f, r * od);
 }
 
 static const struct clk_ops k210_pll_ops = {
-- 
2.39.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-03-01  0:27 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  0:26 [PATCH v3 0/3] Add RISC-V 32 NOMMU support Jesse Taube
2023-03-01  0:26 ` Jesse Taube
2023-03-01  0:26 ` Jesse Taube [this message]
2023-03-01  0:26   ` [PATCH v3 1/3] clk: k210: remove an implicit 64-bit division Jesse Taube
2023-03-01  1:19   ` Damien Le Moal
2023-03-01  1:19     ` Damien Le Moal
2023-03-06 22:31   ` Stephen Boyd
2023-03-06 22:31     ` Stephen Boyd
2023-03-06 22:35     ` Conor Dooley
2023-03-06 22:35       ` Conor Dooley
2023-03-06 22:37       ` Stephen Boyd
2023-03-06 22:37         ` Stephen Boyd
2023-03-06 22:41   ` Stephen Boyd
2023-03-06 22:41     ` Stephen Boyd
2023-03-06 22:48     ` Palmer Dabbelt
2023-03-06 22:48       ` Palmer Dabbelt
2023-03-01  0:26 ` [PATCH v3 2/3] riscv: Kconfig: Allow RV32 to build with no MMU Jesse Taube
2023-03-01  0:26   ` Jesse Taube
2023-03-01  1:22   ` Damien Le Moal
2023-03-01  1:22     ` Damien Le Moal
2023-03-01  0:26 ` [PATCH v3 3/3] riscv: configs: Add nommu PHONY defconfig for RV32 Jesse Taube
2023-03-01  0:26   ` Jesse Taube
2023-03-01  4:07 ` [PATCH v3 0/3] Add RISC-V 32 NOMMU support Randy Dunlap
2023-03-01  4:07   ` Randy Dunlap
2023-03-01  4:42   ` Damien Le Moal
2023-03-01  4:42     ` Damien Le Moal
2023-03-08  1:26     ` Jesse Taube
2023-03-08  1:26       ` Jesse Taube
2023-03-08  2:16       ` Randy Dunlap
2023-03-08  2:16         ` Randy Dunlap
2023-03-08  2:30         ` Jesse Taube
2023-03-08  2:30           ` Jesse Taube
2023-03-08  2:33           ` Randy Dunlap
2023-03-08  2:33             ` Randy Dunlap
2023-03-08  2:51             ` Randy Dunlap
2023-03-08  2:51               ` Randy Dunlap
2023-03-08  2:54               ` Jesse Taube
2023-03-08  2:54                 ` Jesse Taube
2023-03-08  3:23                 ` Randy Dunlap
2023-03-08  3:23                   ` Randy Dunlap
2023-03-08  3:42                   ` Damien Le Moal
2023-03-08  3:42                     ` Damien Le Moal
2023-03-08  3:46                     ` Jesse Taube
2023-03-08  3:46                       ` Jesse Taube
2023-03-08  4:11                       ` Damien Le Moal
2023-03-08  4:11                         ` Damien Le Moal
2023-03-14 18:35                         ` Jesse Taube
2023-03-14 18:35                           ` Jesse Taube
2023-03-14 19:16                           ` Conor Dooley
2023-03-14 19:16                             ` Conor Dooley
2023-03-08  3:51                     ` Randy Dunlap
2023-03-08  3:51                       ` Randy Dunlap
2023-03-25 11:57 ` Conor Dooley
2023-03-25 11:57   ` Conor Dooley
2023-03-28 18:50 ` (subset) " Palmer Dabbelt
2023-03-28 18:50   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301002657.352637-2-Mr.Bossman075@gmail.com \
    --to=mr.bossman075@gmail.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor.dooley@microchip.com \
    --cc=damien.lemoal@wdc.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=mturquette@baylibre.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=sboyd@kernel.org \
    --cc=ustcymgu@gmail.com \
    --cc=wbx@openadk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.