From: Damien Le Moal <damien.lemoal@opensource.wdc.com> To: Randy Dunlap <rdunlap@infradead.org>, Jesse Taube <mr.bossman075@gmail.com>, linux-riscv@lists.infradead.org Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Yimin Gu <ustcymgu@gmail.com>, Damien Le Moal <damien.lemoal@wdc.com>, Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Waldemar Brodkorb <wbx@openadk.org>, Albert Ou <aou@eecs.berkeley.edu>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com> Subject: Re: [PATCH v3 0/3] Add RISC-V 32 NOMMU support Date: Wed, 8 Mar 2023 12:42:06 +0900 [thread overview] Message-ID: <d3fb242e-646e-50b5-7dba-17b228bb32aa@opensource.wdc.com> (raw) In-Reply-To: <2ebe4bc5-c11c-89b1-2644-358dc12bdfa5@infradead.org> On 3/8/23 12:23, Randy Dunlap wrote: >>> OK, I don't know how it happened. I cannot reproduce it now. >>> The failing .config files has CONFIG_MMU is not set (for RV32I), which >>> appears to be impossible. >> These patches add `CONFIG_MMU is not set` (for RV32I). >> But no worries it seems to be a non issue now. >> >> Your thoughts Damien? >> > > Thanks for reminding me. > > With these 3 patches applied to linux-next-20230307, > I still get this build error. Does this help ? diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig index 2527cf5757ec..7796c5f1d109 100644 --- a/drivers/soc/canaan/Kconfig +++ b/drivers/soc/canaan/Kconfig @@ -4,7 +4,8 @@ config SOC_K210_SYSCTL bool "Canaan Kendryte K210 SoC system controller" depends on RISCV && SOC_CANAAN && OF default SOC_CANAAN - select PM - select MFD_SYSCON + select COMMON_CLK_K210 + select PM + select MFD_SYSCON help Canaan Kendryte K210 SoC system controller driver. (just noticed that there are whitespace errors here...) Note that both the sysctl and clk driver depend on RISCV. I think these should probably also depend on 64BIT, and eventually add a "|| COMPILE_TEST" as well. So something like this: diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index b6c5bf69a2b2..657a36d2640d 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -431,7 +431,7 @@ config COMMON_CLK_FIXED_MMIO config COMMON_CLK_K210 bool "Clock driver for the Canaan Kendryte K210 SoC" - depends on OF && RISCV && SOC_CANAAN + depends on OF && RISCV && SOC_CANAAN && (64BIT || COMPILE_TEST) default SOC_CANAAN help Support for the Canaan Kendryte K210 RISC-V SoC clocks. diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig index 2527cf5757ec..1745a614d2a7 100644 --- a/drivers/soc/canaan/Kconfig +++ b/drivers/soc/canaan/Kconfig @@ -2,9 +2,10 @@ config SOC_K210_SYSCTL bool "Canaan Kendryte K210 SoC system controller" - depends on RISCV && SOC_CANAAN && OF + depends on RISCV && SOC_CANAAN && OF && (64BIT || COMPILE_TEST) default SOC_CANAAN - select PM - select MFD_SYSCON + select COMMON_CLK_K210 + select PM + select MFD_SYSCON help Canaan Kendryte K210 SoC system controller driver. COMPILE_TEST is optional though, but I do not see any reason why not eventhough in practice these drivers will likely never end up in 32-bits SoC. -- Damien Le Moal Western Digital Research
WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <damien.lemoal@opensource.wdc.com> To: Randy Dunlap <rdunlap@infradead.org>, Jesse Taube <mr.bossman075@gmail.com>, linux-riscv@lists.infradead.org Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Yimin Gu <ustcymgu@gmail.com>, Damien Le Moal <damien.lemoal@wdc.com>, Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Waldemar Brodkorb <wbx@openadk.org>, Albert Ou <aou@eecs.berkeley.edu>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com> Subject: Re: [PATCH v3 0/3] Add RISC-V 32 NOMMU support Date: Wed, 8 Mar 2023 12:42:06 +0900 [thread overview] Message-ID: <d3fb242e-646e-50b5-7dba-17b228bb32aa@opensource.wdc.com> (raw) In-Reply-To: <2ebe4bc5-c11c-89b1-2644-358dc12bdfa5@infradead.org> On 3/8/23 12:23, Randy Dunlap wrote: >>> OK, I don't know how it happened. I cannot reproduce it now. >>> The failing .config files has CONFIG_MMU is not set (for RV32I), which >>> appears to be impossible. >> These patches add `CONFIG_MMU is not set` (for RV32I). >> But no worries it seems to be a non issue now. >> >> Your thoughts Damien? >> > > Thanks for reminding me. > > With these 3 patches applied to linux-next-20230307, > I still get this build error. Does this help ? diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig index 2527cf5757ec..7796c5f1d109 100644 --- a/drivers/soc/canaan/Kconfig +++ b/drivers/soc/canaan/Kconfig @@ -4,7 +4,8 @@ config SOC_K210_SYSCTL bool "Canaan Kendryte K210 SoC system controller" depends on RISCV && SOC_CANAAN && OF default SOC_CANAAN - select PM - select MFD_SYSCON + select COMMON_CLK_K210 + select PM + select MFD_SYSCON help Canaan Kendryte K210 SoC system controller driver. (just noticed that there are whitespace errors here...) Note that both the sysctl and clk driver depend on RISCV. I think these should probably also depend on 64BIT, and eventually add a "|| COMPILE_TEST" as well. So something like this: diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index b6c5bf69a2b2..657a36d2640d 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -431,7 +431,7 @@ config COMMON_CLK_FIXED_MMIO config COMMON_CLK_K210 bool "Clock driver for the Canaan Kendryte K210 SoC" - depends on OF && RISCV && SOC_CANAAN + depends on OF && RISCV && SOC_CANAAN && (64BIT || COMPILE_TEST) default SOC_CANAAN help Support for the Canaan Kendryte K210 RISC-V SoC clocks. diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig index 2527cf5757ec..1745a614d2a7 100644 --- a/drivers/soc/canaan/Kconfig +++ b/drivers/soc/canaan/Kconfig @@ -2,9 +2,10 @@ config SOC_K210_SYSCTL bool "Canaan Kendryte K210 SoC system controller" - depends on RISCV && SOC_CANAAN && OF + depends on RISCV && SOC_CANAAN && OF && (64BIT || COMPILE_TEST) default SOC_CANAAN - select PM - select MFD_SYSCON + select COMMON_CLK_K210 + select PM + select MFD_SYSCON help Canaan Kendryte K210 SoC system controller driver. COMPILE_TEST is optional though, but I do not see any reason why not eventhough in practice these drivers will likely never end up in 32-bits SoC. -- Damien Le Moal Western Digital Research _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-03-08 3:43 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-01 0:26 [PATCH v3 0/3] Add RISC-V 32 NOMMU support Jesse Taube 2023-03-01 0:26 ` Jesse Taube 2023-03-01 0:26 ` [PATCH v3 1/3] clk: k210: remove an implicit 64-bit division Jesse Taube 2023-03-01 0:26 ` Jesse Taube 2023-03-01 1:19 ` Damien Le Moal 2023-03-01 1:19 ` Damien Le Moal 2023-03-06 22:31 ` Stephen Boyd 2023-03-06 22:31 ` Stephen Boyd 2023-03-06 22:35 ` Conor Dooley 2023-03-06 22:35 ` Conor Dooley 2023-03-06 22:37 ` Stephen Boyd 2023-03-06 22:37 ` Stephen Boyd 2023-03-06 22:41 ` Stephen Boyd 2023-03-06 22:41 ` Stephen Boyd 2023-03-06 22:48 ` Palmer Dabbelt 2023-03-06 22:48 ` Palmer Dabbelt 2023-03-01 0:26 ` [PATCH v3 2/3] riscv: Kconfig: Allow RV32 to build with no MMU Jesse Taube 2023-03-01 0:26 ` Jesse Taube 2023-03-01 1:22 ` Damien Le Moal 2023-03-01 1:22 ` Damien Le Moal 2023-03-01 0:26 ` [PATCH v3 3/3] riscv: configs: Add nommu PHONY defconfig for RV32 Jesse Taube 2023-03-01 0:26 ` Jesse Taube 2023-03-01 4:07 ` [PATCH v3 0/3] Add RISC-V 32 NOMMU support Randy Dunlap 2023-03-01 4:07 ` Randy Dunlap 2023-03-01 4:42 ` Damien Le Moal 2023-03-01 4:42 ` Damien Le Moal 2023-03-08 1:26 ` Jesse Taube 2023-03-08 1:26 ` Jesse Taube 2023-03-08 2:16 ` Randy Dunlap 2023-03-08 2:16 ` Randy Dunlap 2023-03-08 2:30 ` Jesse Taube 2023-03-08 2:30 ` Jesse Taube 2023-03-08 2:33 ` Randy Dunlap 2023-03-08 2:33 ` Randy Dunlap 2023-03-08 2:51 ` Randy Dunlap 2023-03-08 2:51 ` Randy Dunlap 2023-03-08 2:54 ` Jesse Taube 2023-03-08 2:54 ` Jesse Taube 2023-03-08 3:23 ` Randy Dunlap 2023-03-08 3:23 ` Randy Dunlap 2023-03-08 3:42 ` Damien Le Moal [this message] 2023-03-08 3:42 ` Damien Le Moal 2023-03-08 3:46 ` Jesse Taube 2023-03-08 3:46 ` Jesse Taube 2023-03-08 4:11 ` Damien Le Moal 2023-03-08 4:11 ` Damien Le Moal 2023-03-14 18:35 ` Jesse Taube 2023-03-14 18:35 ` Jesse Taube 2023-03-14 19:16 ` Conor Dooley 2023-03-14 19:16 ` Conor Dooley 2023-03-08 3:51 ` Randy Dunlap 2023-03-08 3:51 ` Randy Dunlap 2023-03-25 11:57 ` Conor Dooley 2023-03-25 11:57 ` Conor Dooley 2023-03-28 18:50 ` (subset) " Palmer Dabbelt 2023-03-28 18:50 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d3fb242e-646e-50b5-7dba-17b228bb32aa@opensource.wdc.com \ --to=damien.lemoal@opensource.wdc.com \ --cc=aou@eecs.berkeley.edu \ --cc=damien.lemoal@wdc.com \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=mr.bossman075@gmail.com \ --cc=mturquette@baylibre.com \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=rdunlap@infradead.org \ --cc=sboyd@kernel.org \ --cc=ustcymgu@gmail.com \ --cc=wbx@openadk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.