From: Rob Herring <robh@kernel.org> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi <cristian.marussi@arm.com>, Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>, Nikunj Kela <nkela@quicinc.com>, Prasad Sodagudi <psodagud@quicinc.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org Subject: Re: [PATCH 09/16] dt-bindings: firmware: arm,scmi: Extend bindings for protocol@13 Date: Wed, 14 Jun 2023 17:00:44 -0600 [thread overview] Message-ID: <20230614230044.GA3019052-robh@kernel.org> (raw) In-Reply-To: <20230607124628.157465-10-ulf.hansson@linaro.org> On Wed, Jun 07, 2023 at 02:46:21PM +0200, Ulf Hansson wrote: > The protocol@13 node is describing the performance scaling option for the > ARM SCMI interface, as a clock provider. This is unnecessary limiting, as > performance scaling is in many cases not limited to switching a clock's > frequency. > > Therefore, let's extend the binding so the interface can be modelled as a > generic "performance domain" too. The common way to describe this, is to > use the "power-domain" bindings, so let's use that. What's wrong with the performance-domain binding? > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5824c43e9893..cff9d1e4cea1 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -145,8 +145,8 @@ properties: > '#clock-cells': > const: 1 > > - required: > - - '#clock-cells' > + '#power-domain-cells': > + const: 1 > > protocol@14: > $ref: '#/$defs/protocol-node' > -- > 2.34.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi <cristian.marussi@arm.com>, Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>, Nikunj Kela <nkela@quicinc.com>, Prasad Sodagudi <psodagud@quicinc.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org Subject: Re: [PATCH 09/16] dt-bindings: firmware: arm,scmi: Extend bindings for protocol@13 Date: Wed, 14 Jun 2023 17:00:44 -0600 [thread overview] Message-ID: <20230614230044.GA3019052-robh@kernel.org> (raw) In-Reply-To: <20230607124628.157465-10-ulf.hansson@linaro.org> On Wed, Jun 07, 2023 at 02:46:21PM +0200, Ulf Hansson wrote: > The protocol@13 node is describing the performance scaling option for the > ARM SCMI interface, as a clock provider. This is unnecessary limiting, as > performance scaling is in many cases not limited to switching a clock's > frequency. > > Therefore, let's extend the binding so the interface can be modelled as a > generic "performance domain" too. The common way to describe this, is to > use the "power-domain" bindings, so let's use that. What's wrong with the performance-domain binding? > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5824c43e9893..cff9d1e4cea1 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -145,8 +145,8 @@ properties: > '#clock-cells': > const: 1 > > - required: > - - '#clock-cells' > + '#power-domain-cells': > + const: 1 > > protocol@14: > $ref: '#/$defs/protocol-node' > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-14 23:00 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-07 12:46 [PATCH 00/16] arm_scmi/opp/dvfs: Add generic performance scaling support Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 01/16] firmware: arm_scmi: Extend perf protocol ops to get number of domains Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 02/16] firmware: arm_scmi: Extend perf protocol ops to get the name of a domain Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 03/16] firmware: arm_scmi: Extend perf protocol ops to inform of set level support Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 04/16] cpufreq: scmi: Prepare to move OF parsing of domain-id to cpufreq Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 05/16] firmware: arm_scmi: Align perf ops to use domain-id as in-parameter Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 06/16] firmware: arm_scmi: Drop redundant ->device_domain_id() from perf ops Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 07/16] cpufreq: scmi: Avoid one OF parsing in scmi_get_sharing_cpus() Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 08/16] PM: domains: Allow genpd providers to manage OPP tables directly by its FW Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 09/16] dt-bindings: firmware: arm,scmi: Extend bindings for protocol@13 Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-14 23:00 ` Rob Herring [this message] 2023-06-14 23:00 ` Rob Herring 2023-06-15 9:10 ` Ulf Hansson 2023-06-15 9:10 ` Ulf Hansson 2023-07-14 17:14 ` Rob Herring 2023-07-14 17:14 ` Rob Herring 2023-07-15 12:35 ` Ulf Hansson 2023-07-15 12:35 ` Ulf Hansson 2023-06-15 8:44 ` Sudeep Holla 2023-06-15 8:44 ` Sudeep Holla 2023-06-15 9:39 ` Ulf Hansson 2023-06-15 9:39 ` Ulf Hansson 2023-06-15 13:30 ` Sudeep Holla 2023-06-15 13:30 ` Sudeep Holla 2023-06-16 11:48 ` Ulf Hansson 2023-06-16 11:48 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 10/16] firmware: arm_scmi: Add the SCMI performance domain Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 11/16] OPP: Add dev_pm_opp_add_dynamic() to allow more flexibility Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-08 5:29 ` Viresh Kumar 2023-06-08 5:29 ` Viresh Kumar 2023-06-08 8:59 ` Ulf Hansson 2023-06-08 8:59 ` Ulf Hansson 2023-06-08 9:22 ` Viresh Kumar 2023-06-08 9:22 ` Viresh Kumar 2023-06-08 9:40 ` Ulf Hansson 2023-06-08 9:40 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 12/16] OPP: Extend dev_pm_opp_data with performance level Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 13/16] OPP: Extend dev_pm_opp_data with OPP provider support Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-08 5:34 ` Viresh Kumar 2023-06-08 5:34 ` Viresh Kumar 2023-06-08 9:37 ` Ulf Hansson 2023-06-08 9:37 ` Ulf Hansson 2023-06-08 10:45 ` Viresh Kumar 2023-06-08 10:45 ` Viresh Kumar 2023-06-08 11:45 ` Ulf Hansson 2023-06-08 11:45 ` Ulf Hansson 2023-06-09 5:10 ` Viresh Kumar 2023-06-09 5:10 ` Viresh Kumar 2023-06-09 10:59 ` Ulf Hansson 2023-06-09 10:59 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 14/16] firmware: arm_scmi: Simplify error path in scmi_dvfs_device_opps_add() Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 15/16] firmware: arm_scmi: Extend perf support with OPP from genpd providers Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 12:46 ` [PATCH 16/16] firmware: arm_scmi: Add generic OPP support to the SCMI performance domain Ulf Hansson 2023-06-07 12:46 ` Ulf Hansson 2023-06-07 14:43 ` [PATCH 00/16] arm_scmi/opp/dvfs: Add generic performance scaling support Cristian Marussi 2023-06-07 14:43 ` Cristian Marussi 2023-06-08 9:53 ` Ulf Hansson 2023-06-08 9:53 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230614230044.GA3019052-robh@kernel.org \ --to=robh@kernel.org \ --cc=alexandre.torgue@foss.st.com \ --cc=conor+dt@kernel.org \ --cc=cristian.marussi@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=nkela@quicinc.com \ --cc=nm@ti.com \ --cc=psodagud@quicinc.com \ --cc=sboyd@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=ulf.hansson@linaro.org \ --cc=vireshk@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.