From: Heiner Kallweit <hkallweit1@gmail.com> To: Wolfram Sang <wsa@kernel.org>, Xinliang Liu <xinliang.liu@linaro.org> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>, John Stultz <jstultz@google.com>, Xinwei Kong <kong.kongxinwei@hisilicon.com>, Yongqin Liu <yongqin.liu@linaro.org>, linux-i2c@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>, Tian Tao <tiantao6@hisilicon.com>, Sumit Semwal <sumit.semwal@linaro.org>, Heiner Kallweit <hkallweit1@gmail.com> Subject: [PATCH 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:40 +0100 [thread overview] Message-ID: <20231113112344.719-17-hkallweit1@gmail.com> (raw) In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector);
WARNING: multiple messages have this Message-ID (diff)
From: Heiner Kallweit <hkallweit1@gmail.com> To: Wolfram Sang <wsa@kernel.org>, Xinliang Liu <xinliang.liu@linaro.org> Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>, Tian Tao <tiantao6@hisilicon.com>, Xinwei Kong <kong.kongxinwei@hisilicon.com>, Sumit Semwal <sumit.semwal@linaro.org>, Yongqin Liu <yongqin.liu@linaro.org>, John Stultz <jstultz@google.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Mon, 13 Nov 2023 12:23:40 +0100 [thread overview] Message-ID: <20231113112344.719-17-hkallweit1@gmail.com> (raw) In-Reply-To: <20231113112344.719-1-hkallweit1@gmail.com> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner = THIS_MODULE; - connector->adapter.class = I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent = drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector);
next prev parent reply other threads:[~2023-11-13 11:24 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-13 11:23 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit 2023-11-13 11:23 ` [Intel-gfx] " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 20:42 ` Heiko Stübner 2023-11-13 20:42 ` Heiko Stübner 2023-11-13 20:42 ` Heiko Stübner 2023-11-13 20:42 ` Heiko Stübner 2023-11-13 11:23 ` [PATCH 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 17:50 ` Harry Wentland 2023-11-13 17:50 ` Harry Wentland 2023-11-13 17:50 ` Harry Wentland 2023-11-13 18:32 ` Heiner Kallweit 2023-11-13 18:32 ` Heiner Kallweit 2023-11-13 18:32 ` Heiner Kallweit 2023-11-16 19:18 ` Alex Deucher 2023-11-16 19:18 ` Alex Deucher 2023-11-16 19:18 ` Alex Deucher 2023-11-13 11:23 ` [PATCH 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 05/20] drivers/video/fbdev: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 07/20] drivers/gpu/drm: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-16 19:16 ` Alex Deucher 2023-11-16 19:16 ` Alex Deucher 2023-11-13 11:23 ` [PATCH 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit 2023-11-13 11:23 ` [Intel-gfx] " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 12:17 ` Jani Nikula 2023-11-13 12:17 ` [Intel-gfx] " Jani Nikula 2023-11-13 12:17 ` Jani Nikula 2023-11-13 12:32 ` Heiner Kallweit 2023-11-13 12:32 ` [Intel-gfx] " Heiner Kallweit 2023-11-13 12:32 ` Heiner Kallweit 2023-11-13 17:50 ` Jani Nikula 2023-11-13 17:50 ` [Intel-gfx] " Jani Nikula 2023-11-13 17:50 ` Jani Nikula 2023-11-13 18:20 ` Heiner Kallweit 2023-11-13 18:20 ` [Intel-gfx] " Heiner Kallweit 2023-11-13 18:20 ` Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit [this message] 2023-11-13 11:23 ` [PATCH 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit 2023-11-13 11:23 ` [PATCH 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-13 11:23 ` [PATCH 19/20] drivers/gpu/drm/display: " Heiner Kallweit 2023-11-13 11:23 ` Heiner Kallweit 2023-11-16 19:14 ` Alex Deucher 2023-11-16 19:14 ` Alex Deucher 2023-11-13 11:23 ` [PATCH 20/20] include/linux/i2c.h: " Heiner Kallweit 2023-11-13 17:49 ` [PATCH 00/20] " Wolfram Sang 2023-11-13 17:49 ` [Intel-gfx] " Wolfram Sang 2023-11-13 17:49 ` Wolfram Sang 2023-11-13 17:49 ` Wolfram Sang 2023-11-13 17:49 ` Wolfram Sang 2023-11-13 18:21 ` Heiner Kallweit 2023-11-13 18:21 ` [Intel-gfx] " Heiner Kallweit 2023-11-13 18:21 ` Heiner Kallweit 2023-11-13 18:21 ` Heiner Kallweit 2023-11-13 20:54 ` Wolfram Sang 2023-11-13 20:54 ` [Intel-gfx] " Wolfram Sang 2023-11-13 20:54 ` Wolfram Sang 2023-11-13 20:54 ` Wolfram Sang 2023-11-13 20:54 ` Wolfram Sang 2023-11-16 19:17 ` Alex Deucher 2023-11-16 19:17 ` Alex Deucher 2023-11-16 19:17 ` [Intel-gfx] " Alex Deucher 2023-11-16 19:17 ` Alex Deucher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231113112344.719-17-hkallweit1@gmail.com \ --to=hkallweit1@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jstultz@google.com \ --cc=kong.kongxinwei@hisilicon.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mripard@kernel.org \ --cc=sumit.semwal@linaro.org \ --cc=tiantao6@hisilicon.com \ --cc=tzimmermann@suse.de \ --cc=wsa@kernel.org \ --cc=xinliang.liu@linaro.org \ --cc=yongqin.liu@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.