From: Alex Deucher <alexdeucher@gmail.com>
To: Harry Wentland <harry.wentland@amd.com>
Cc: "Heiner Kallweit" <hkallweit1@gmail.com>,
"Wolfram Sang" <wsa@kernel.org>, "Leo Li" <sunpeng.li@amd.com>,
dri-devel@lists.freedesktop.org, "Pan,
Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-i2c@vger.kernel.org, "Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support
Date: Thu, 16 Nov 2023 14:18:23 -0500 [thread overview]
Message-ID: <CADnq5_NjZkGLz-J39h_6djdgaD8zT3_pEq4iy5FfcYTz646SFg@mail.gmail.com> (raw)
In-Reply-To: <e4ee224f-8f18-4922-ac1c-4612b8e021d8@amd.com>
On Mon, Nov 13, 2023 at 12:50 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
> Please just use "drm/amd/display:" as tag in the commit subject.
>
> With that fixed, this is
> Acked-by: Harry Wentland <harry.wentland@amd.com>
>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Feel free to take this via the i2c tree if you prefer.
Alex
> Harry
>
> On 2023-11-13 06:23, Heiner Kallweit wrote:
> > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> > Class-based device auto-detection is a legacy mechanism and shouldn't
> > be used in new code. So we can remove this class completely now.
> >
> > Preferably this series should be applied via the i2c tree.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 6f99f6754..ae1edc6ab 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service,
> > if (!i2c)
> > return NULL;
> > i2c->base.owner = THIS_MODULE;
> > - i2c->base.class = I2C_CLASS_DDC;
> > i2c->base.dev.parent = &adev->pdev->dev;
> > i2c->base.algo = &amdgpu_dm_i2c_algo;
> > snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
> >
>
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Harry Wentland <harry.wentland@amd.com>
Cc: "Leo Li" <sunpeng.li@amd.com>, "Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Wolfram Sang" <wsa@kernel.org>,
linux-i2c@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support
Date: Thu, 16 Nov 2023 14:18:23 -0500 [thread overview]
Message-ID: <CADnq5_NjZkGLz-J39h_6djdgaD8zT3_pEq4iy5FfcYTz646SFg@mail.gmail.com> (raw)
In-Reply-To: <e4ee224f-8f18-4922-ac1c-4612b8e021d8@amd.com>
On Mon, Nov 13, 2023 at 12:50 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
> Please just use "drm/amd/display:" as tag in the commit subject.
>
> With that fixed, this is
> Acked-by: Harry Wentland <harry.wentland@amd.com>
>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Feel free to take this via the i2c tree if you prefer.
Alex
> Harry
>
> On 2023-11-13 06:23, Heiner Kallweit wrote:
> > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> > Class-based device auto-detection is a legacy mechanism and shouldn't
> > be used in new code. So we can remove this class completely now.
> >
> > Preferably this series should be applied via the i2c tree.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 6f99f6754..ae1edc6ab 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service,
> > if (!i2c)
> > return NULL;
> > i2c->base.owner = THIS_MODULE;
> > - i2c->base.class = I2C_CLASS_DDC;
> > i2c->base.dev.parent = &adev->pdev->dev;
> > i2c->base.algo = &amdgpu_dm_i2c_algo;
> > snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
> >
>
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Harry Wentland <harry.wentland@amd.com>
Cc: "Leo Li" <sunpeng.li@amd.com>, "Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Wolfram Sang" <wsa@kernel.org>,
linux-i2c@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support
Date: Thu, 16 Nov 2023 14:18:23 -0500 [thread overview]
Message-ID: <CADnq5_NjZkGLz-J39h_6djdgaD8zT3_pEq4iy5FfcYTz646SFg@mail.gmail.com> (raw)
In-Reply-To: <e4ee224f-8f18-4922-ac1c-4612b8e021d8@amd.com>
On Mon, Nov 13, 2023 at 12:50 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
> Please just use "drm/amd/display:" as tag in the commit subject.
>
> With that fixed, this is
> Acked-by: Harry Wentland <harry.wentland@amd.com>
>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Feel free to take this via the i2c tree if you prefer.
Alex
> Harry
>
> On 2023-11-13 06:23, Heiner Kallweit wrote:
> > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> > Class-based device auto-detection is a legacy mechanism and shouldn't
> > be used in new code. So we can remove this class completely now.
> >
> > Preferably this series should be applied via the i2c tree.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 6f99f6754..ae1edc6ab 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service,
> > if (!i2c)
> > return NULL;
> > i2c->base.owner = THIS_MODULE;
> > - i2c->base.class = I2C_CLASS_DDC;
> > i2c->base.dev.parent = &adev->pdev->dev;
> > i2c->base.algo = &amdgpu_dm_i2c_algo;
> > snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d", link_index);
> >
>
next prev parent reply other threads:[~2023-11-16 19:18 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 11:23 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-13 11:23 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 20:42 ` Heiko Stübner
2023-11-13 20:42 ` Heiko Stübner
2023-11-13 20:42 ` Heiko Stübner
2023-11-13 20:42 ` Heiko Stübner
2023-11-13 11:23 ` [PATCH 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 17:50 ` Harry Wentland
2023-11-13 17:50 ` Harry Wentland
2023-11-13 17:50 ` Harry Wentland
2023-11-13 18:32 ` Heiner Kallweit
2023-11-13 18:32 ` Heiner Kallweit
2023-11-13 18:32 ` Heiner Kallweit
2023-11-16 19:18 ` Alex Deucher [this message]
2023-11-16 19:18 ` Alex Deucher
2023-11-16 19:18 ` Alex Deucher
2023-11-13 11:23 ` [PATCH 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-16 19:16 ` Alex Deucher
2023-11-16 19:16 ` Alex Deucher
2023-11-13 11:23 ` [PATCH 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-13 11:23 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 12:17 ` Jani Nikula
2023-11-13 12:17 ` [Intel-gfx] " Jani Nikula
2023-11-13 12:17 ` Jani Nikula
2023-11-13 12:32 ` Heiner Kallweit
2023-11-13 12:32 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 12:32 ` Heiner Kallweit
2023-11-13 17:50 ` Jani Nikula
2023-11-13 17:50 ` [Intel-gfx] " Jani Nikula
2023-11-13 17:50 ` Jani Nikula
2023-11-13 18:20 ` Heiner Kallweit
2023-11-13 18:20 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 18:20 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-16 19:14 ` Alex Deucher
2023-11-16 19:14 ` Alex Deucher
2023-11-13 11:23 ` [PATCH 20/20] include/linux/i2c.h: " Heiner Kallweit
2023-11-13 17:49 ` [PATCH 00/20] " Wolfram Sang
2023-11-13 17:49 ` [Intel-gfx] " Wolfram Sang
2023-11-13 17:49 ` Wolfram Sang
2023-11-13 17:49 ` Wolfram Sang
2023-11-13 17:49 ` Wolfram Sang
2023-11-13 18:21 ` Heiner Kallweit
2023-11-13 18:21 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 18:21 ` Heiner Kallweit
2023-11-13 18:21 ` Heiner Kallweit
2023-11-13 20:54 ` Wolfram Sang
2023-11-13 20:54 ` [Intel-gfx] " Wolfram Sang
2023-11-13 20:54 ` Wolfram Sang
2023-11-13 20:54 ` Wolfram Sang
2023-11-13 20:54 ` Wolfram Sang
2023-11-16 19:17 ` Alex Deucher
2023-11-16 19:17 ` Alex Deucher
2023-11-16 19:17 ` [Intel-gfx] " Alex Deucher
2023-11-16 19:17 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_NjZkGLz-J39h_6djdgaD8zT3_pEq4iy5FfcYTz646SFg@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.