From: Jani Nikula <jani.nikula@linux.intel.com>
To: Heiner Kallweit <hkallweit1@gmail.com>, Wolfram Sang <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support
Date: Mon, 13 Nov 2023 14:17:14 +0200 [thread overview]
Message-ID: <87sf59vodx.fsf@intel.com> (raw)
In-Reply-To: <20231113112344.719-16-hkallweit1@gmail.com>
On Mon, 13 Nov 2023, Heiner Kallweit <hkallweit1@gmail.com> wrote:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
So this is copy-pasted to all commits and the cover letter, but please
do explain why there are no functional changes here (or are there?),
without me having to go through the i2c stack and try to find the
commits alluded to in "After removal of the legacy ...".
What does this mean?
BR,
Jani.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> ---
> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
> index 40d7b6f3f..e9e4dcf34 100644
> --- a/drivers/gpu/drm/i915/display/intel_gmbus.c
> +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
> @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915)
> }
>
> bus->adapter.owner = THIS_MODULE;
> - bus->adapter.class = I2C_CLASS_DDC;
> snprintf(bus->adapter.name,
> sizeof(bus->adapter.name),
> "i915 gmbus %s", gmbus_pin->name);
> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
> index a636f42ce..5e64d1baf 100644
> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
> @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc,
> ddc->ddc_bus = ddc_bus;
>
> ddc->ddc.owner = THIS_MODULE;
> - ddc->ddc.class = I2C_CLASS_DDC;
> snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d",
> port_name(sdvo->base.port), ddc_bus);
> ddc->ddc.dev.parent = &pdev->dev;
>
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Heiner Kallweit <hkallweit1@gmail.com>, Wolfram Sang <wsa@kernel.org>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support
Date: Mon, 13 Nov 2023 14:17:14 +0200 [thread overview]
Message-ID: <87sf59vodx.fsf@intel.com> (raw)
In-Reply-To: <20231113112344.719-16-hkallweit1@gmail.com>
On Mon, 13 Nov 2023, Heiner Kallweit <hkallweit1@gmail.com> wrote:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
So this is copy-pasted to all commits and the cover letter, but please
do explain why there are no functional changes here (or are there?),
without me having to go through the i2c stack and try to find the
commits alluded to in "After removal of the legacy ...".
What does this mean?
BR,
Jani.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> ---
> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
> index 40d7b6f3f..e9e4dcf34 100644
> --- a/drivers/gpu/drm/i915/display/intel_gmbus.c
> +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
> @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915)
> }
>
> bus->adapter.owner = THIS_MODULE;
> - bus->adapter.class = I2C_CLASS_DDC;
> snprintf(bus->adapter.name,
> sizeof(bus->adapter.name),
> "i915 gmbus %s", gmbus_pin->name);
> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
> index a636f42ce..5e64d1baf 100644
> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
> @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc,
> ddc->ddc_bus = ddc_bus;
>
> ddc->ddc.owner = THIS_MODULE;
> - ddc->ddc.class = I2C_CLASS_DDC;
> snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d",
> port_name(sdvo->base.port), ddc_bus);
> ddc->ddc.dev.parent = &pdev->dev;
>
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Heiner Kallweit <hkallweit1@gmail.com>, Wolfram Sang <wsa@kernel.org>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org,
Daniel Vetter <daniel@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [Intel-gfx] [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support
Date: Mon, 13 Nov 2023 14:17:14 +0200 [thread overview]
Message-ID: <87sf59vodx.fsf@intel.com> (raw)
In-Reply-To: <20231113112344.719-16-hkallweit1@gmail.com>
On Mon, 13 Nov 2023, Heiner Kallweit <hkallweit1@gmail.com> wrote:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
So this is copy-pasted to all commits and the cover letter, but please
do explain why there are no functional changes here (or are there?),
without me having to go through the i2c stack and try to find the
commits alluded to in "After removal of the legacy ...".
What does this mean?
BR,
Jani.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> ---
> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i915/display/intel_gmbus.c
> index 40d7b6f3f..e9e4dcf34 100644
> --- a/drivers/gpu/drm/i915/display/intel_gmbus.c
> +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c
> @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915)
> }
>
> bus->adapter.owner = THIS_MODULE;
> - bus->adapter.class = I2C_CLASS_DDC;
> snprintf(bus->adapter.name,
> sizeof(bus->adapter.name),
> "i915 gmbus %s", gmbus_pin->name);
> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
> index a636f42ce..5e64d1baf 100644
> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
> @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc,
> ddc->ddc_bus = ddc_bus;
>
> ddc->ddc.owner = THIS_MODULE;
> - ddc->ddc.class = I2C_CLASS_DDC;
> snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d",
> port_name(sdvo->base.port), ddc_bus);
> ddc->ddc.dev.parent = &pdev->dev;
>
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-11-13 12:17 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 11:23 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-13 11:23 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 20:42 ` Heiko Stübner
2023-11-13 20:42 ` Heiko Stübner
2023-11-13 20:42 ` Heiko Stübner
2023-11-13 20:42 ` Heiko Stübner
2023-11-13 11:23 ` [PATCH 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 17:50 ` Harry Wentland
2023-11-13 17:50 ` Harry Wentland
2023-11-13 17:50 ` Harry Wentland
2023-11-13 18:32 ` Heiner Kallweit
2023-11-13 18:32 ` Heiner Kallweit
2023-11-13 18:32 ` Heiner Kallweit
2023-11-16 19:18 ` Alex Deucher
2023-11-16 19:18 ` Alex Deucher
2023-11-16 19:18 ` Alex Deucher
2023-11-13 11:23 ` [PATCH 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-16 19:16 ` Alex Deucher
2023-11-16 19:16 ` Alex Deucher
2023-11-13 11:23 ` [PATCH 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-13 11:23 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 12:17 ` Jani Nikula [this message]
2023-11-13 12:17 ` [Intel-gfx] " Jani Nikula
2023-11-13 12:17 ` Jani Nikula
2023-11-13 12:32 ` Heiner Kallweit
2023-11-13 12:32 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 12:32 ` Heiner Kallweit
2023-11-13 17:50 ` Jani Nikula
2023-11-13 17:50 ` [Intel-gfx] " Jani Nikula
2023-11-13 17:50 ` Jani Nikula
2023-11-13 18:20 ` Heiner Kallweit
2023-11-13 18:20 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 18:20 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-13 11:23 ` Heiner Kallweit
2023-11-16 19:14 ` Alex Deucher
2023-11-16 19:14 ` Alex Deucher
2023-11-13 11:23 ` [PATCH 20/20] include/linux/i2c.h: " Heiner Kallweit
2023-11-13 17:49 ` [PATCH 00/20] " Wolfram Sang
2023-11-13 17:49 ` [Intel-gfx] " Wolfram Sang
2023-11-13 17:49 ` Wolfram Sang
2023-11-13 17:49 ` Wolfram Sang
2023-11-13 17:49 ` Wolfram Sang
2023-11-13 18:21 ` Heiner Kallweit
2023-11-13 18:21 ` [Intel-gfx] " Heiner Kallweit
2023-11-13 18:21 ` Heiner Kallweit
2023-11-13 18:21 ` Heiner Kallweit
2023-11-13 20:54 ` Wolfram Sang
2023-11-13 20:54 ` [Intel-gfx] " Wolfram Sang
2023-11-13 20:54 ` Wolfram Sang
2023-11-13 20:54 ` Wolfram Sang
2023-11-13 20:54 ` Wolfram Sang
2023-11-16 19:17 ` Alex Deucher
2023-11-16 19:17 ` Alex Deucher
2023-11-16 19:17 ` [Intel-gfx] " Alex Deucher
2023-11-16 19:17 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf59vodx.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hkallweit1@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.