From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org, niklas.soderlund@ragnatech.se, sergei.shtylyov@cogentembedded.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] arm64: dts: renesas: eagle: Add LVDS decoder Date: Fri, 06 Apr 2018 16:49:23 +0300 [thread overview] Message-ID: <2194450.fjOBDBAAyU@avalon> (raw) In-Reply-To: <1523020092-25540-7-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 16:08:11 EEST Jacopo Mondi wrote: > The R-Car V3M Eagle board includes a transparent THC63LVD1024 LVDS > decoder, connected to the on-chip LVDS encoder output on one side > and to the not-yet-described HDMI encoder ADV7511W on the other one. > > As the decoder does not need any configuration it has been so-far > omitted from DTS. Now that a driver is available, describe it in DT > as well. As explained in my review of patch 5/7, I'd merge 5/7, 6/7 and 7/7 all together as there's little use for enabling the LVDS decoder if there's nothing connected at its output. Note also how this patch alone, without 7/7, wouldn't comply with the LVDS decoder DT bindings that state that port@2 is mandatory. > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > --- > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 29 +++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts index 144b847..9d0e65d > 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > @@ -31,6 +31,23 @@ > /* first 128MB is reserved for secure area. */ > reg = <0x0 0x48000000 0x0 0x38000000>; > }; > + > + thc63lvd1024: lvds-decoder { > + compatible = "thine,thc63lvd1024"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + thc63lvd1024_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + }; > + }; > }; > > &avb { > @@ -104,3 +121,15 @@ > pinctrl-names = "default"; > status = "okay"; > }; > + > +&lvds0 { > + status = "okay"; > + > + ports { > + port@1 { > + lvds0_out: endpoint { > + remote-endpoint = <&thc63lvd1024_in>; > + }; > + }; > + }; > +}; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: devicetree@vger.kernel.org, sergei.shtylyov@cogentembedded.com, magnus.damm@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, horms@verge.net.au, geert@linux-m68k.org, niklas.soderlund@ragnatech.se Subject: Re: [PATCH 6/7] arm64: dts: renesas: eagle: Add LVDS decoder Date: Fri, 06 Apr 2018 16:49:23 +0300 [thread overview] Message-ID: <2194450.fjOBDBAAyU@avalon> (raw) In-Reply-To: <1523020092-25540-7-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 16:08:11 EEST Jacopo Mondi wrote: > The R-Car V3M Eagle board includes a transparent THC63LVD1024 LVDS > decoder, connected to the on-chip LVDS encoder output on one side > and to the not-yet-described HDMI encoder ADV7511W on the other one. > > As the decoder does not need any configuration it has been so-far > omitted from DTS. Now that a driver is available, describe it in DT > as well. As explained in my review of patch 5/7, I'd merge 5/7, 6/7 and 7/7 all together as there's little use for enabling the LVDS decoder if there's nothing connected at its output. Note also how this patch alone, without 7/7, wouldn't comply with the LVDS decoder DT bindings that state that port@2 is mandatory. > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > --- > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 29 +++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts index 144b847..9d0e65d > 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > @@ -31,6 +31,23 @@ > /* first 128MB is reserved for secure area. */ > reg = <0x0 0x48000000 0x0 0x38000000>; > }; > + > + thc63lvd1024: lvds-decoder { > + compatible = "thine,thc63lvd1024"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + thc63lvd1024_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + }; > + }; > }; > > &avb { > @@ -104,3 +121,15 @@ > pinctrl-names = "default"; > status = "okay"; > }; > + > +&lvds0 { > + status = "okay"; > + > + ports { > + port@1 { > + lvds0_out: endpoint { > + remote-endpoint = <&thc63lvd1024_in>; > + }; > + }; > + }; > +}; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-06 13:49 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-06 13:08 [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge Jacopo Mondi 2018-04-06 13:08 ` [PATCH 1/7] arm64: dts: renesas: r8a77970: add FCPVD support Jacopo Mondi 2018-04-06 13:28 ` Laurent Pinchart 2018-04-06 13:28 ` Laurent Pinchart 2018-04-09 12:19 ` Simon Horman 2018-04-06 13:08 ` [PATCH 2/7] arm64: dts: renesas: r8a77970: add VSPD support Jacopo Mondi 2018-04-06 13:33 ` Laurent Pinchart 2018-04-06 13:33 ` Laurent Pinchart 2018-04-09 12:21 ` Simon Horman 2018-04-06 13:08 ` [PATCH 3/7] arm64: dts: renesas: r8a77970: add DU support Jacopo Mondi 2018-04-06 13:36 ` Laurent Pinchart 2018-04-06 13:36 ` Laurent Pinchart 2018-04-06 13:08 ` [PATCH 4/7] arm64: dts: renesas: r8a77970: add the LVDS instance Jacopo Mondi 2018-04-06 13:38 ` Laurent Pinchart 2018-04-06 13:38 ` Laurent Pinchart 2018-04-06 13:08 ` [PATCH 5/7] arm64: dts: renesas: eagle: Enable DU Jacopo Mondi 2018-04-06 13:45 ` Laurent Pinchart 2018-04-06 13:45 ` Laurent Pinchart 2018-04-06 13:47 ` Laurent Pinchart 2018-04-06 13:47 ` Laurent Pinchart 2018-04-06 13:08 ` [PATCH 6/7] arm64: dts: renesas: eagle: Add LVDS decoder Jacopo Mondi 2018-04-06 13:49 ` Laurent Pinchart [this message] 2018-04-06 13:49 ` Laurent Pinchart 2018-04-06 13:08 ` [PATCH 7/7] arm64: dts: renesas: eagle: Add ADV7511W and HDMI output Jacopo Mondi 2018-04-06 13:51 ` Laurent Pinchart 2018-04-06 13:51 ` Laurent Pinchart 2018-04-06 14:16 ` jacopo mondi 2018-04-06 14:16 ` jacopo mondi 2018-04-06 13:17 ` [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge jacopo mondi 2018-04-06 13:17 ` jacopo mondi 2018-04-06 13:53 ` Laurent Pinchart 2018-04-06 13:53 ` Laurent Pinchart 2018-04-06 14:13 ` jacopo mondi 2018-04-06 14:13 ` jacopo mondi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2194450.fjOBDBAAyU@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=horms@verge.net.au \ --cc=jacopo+renesas@jmondi.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=niklas.soderlund@ragnatech.se \ --cc=sergei.shtylyov@cogentembedded.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.