From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Andrew Davis" <afd@ti.com>,
"Frank Binns" <frank.binns@imgtec.com>,
"Donald Robson" <donald.robson@imgtec.com>,
"Matt Coster" <matt.coster@imgtec.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
"Adam Ford" <aford173@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>, "Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org,
linux-omap@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue
Date: Tue, 9 Jan 2024 19:55:36 +0100 [thread overview]
Message-ID: <291ca046-c034-48a8-93d8-c4cb1cdfaf20@linaro.org> (raw)
In-Reply-To: <4cdd5c4a-f940-4635-837b-872ab776f5c4@ti.com>
On 09/01/2024 17:14, Andrew Davis wrote:
> On 1/9/24 5:28 AM, Krzysztof Kozlowski wrote:
>> On 08/01/2024 19:32, Andrew Davis wrote:
>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>> ---
>>> .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++--
>>> MAINTAINERS | 2 +-
>>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> If you are renaming it, why not renaming to match compatible as we
>> usually expect?
>>
>
> There are (or will be) multiple compatible strings described in this
> file, naming the file after just one would not fully convey the content
> of the file. This generic style naming seems common already for bindings
> with multiple compatibles.
I saw only one compatible used as fallback. Where are more?
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Andrew Davis" <afd@ti.com>,
"Frank Binns" <frank.binns@imgtec.com>,
"Donald Robson" <donald.robson@imgtec.com>,
"Matt Coster" <matt.coster@imgtec.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
"Adam Ford" <aford173@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>, "Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue
Date: Tue, 9 Jan 2024 19:55:36 +0100 [thread overview]
Message-ID: <291ca046-c034-48a8-93d8-c4cb1cdfaf20@linaro.org> (raw)
In-Reply-To: <4cdd5c4a-f940-4635-837b-872ab776f5c4@ti.com>
On 09/01/2024 17:14, Andrew Davis wrote:
> On 1/9/24 5:28 AM, Krzysztof Kozlowski wrote:
>> On 08/01/2024 19:32, Andrew Davis wrote:
>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>> ---
>>> .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++--
>>> MAINTAINERS | 2 +-
>>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> If you are renaming it, why not renaming to match compatible as we
>> usually expect?
>>
>
> There are (or will be) multiple compatible strings described in this
> file, naming the file after just one would not fully convey the content
> of the file. This generic style naming seems common already for bindings
> with multiple compatibles.
I saw only one compatible used as fallback. Where are more?
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Andrew Davis" <afd@ti.com>,
"Frank Binns" <frank.binns@imgtec.com>,
"Donald Robson" <donald.robson@imgtec.com>,
"Matt Coster" <matt.coster@imgtec.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
"Adam Ford" <aford173@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>, "Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue
Date: Tue, 9 Jan 2024 19:55:36 +0100 [thread overview]
Message-ID: <291ca046-c034-48a8-93d8-c4cb1cdfaf20@linaro.org> (raw)
In-Reply-To: <4cdd5c4a-f940-4635-837b-872ab776f5c4@ti.com>
On 09/01/2024 17:14, Andrew Davis wrote:
> On 1/9/24 5:28 AM, Krzysztof Kozlowski wrote:
>> On 08/01/2024 19:32, Andrew Davis wrote:
>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>> ---
>>> .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++--
>>> MAINTAINERS | 2 +-
>>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> If you are renaming it, why not renaming to match compatible as we
>> usually expect?
>>
>
> There are (or will be) multiple compatible strings described in this
> file, naming the file after just one would not fully convey the content
> of the file. This generic style naming seems common already for bindings
> with multiple compatibles.
I saw only one compatible used as fallback. Where are more?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-09 18:55 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 18:32 [PATCH RFC v2 00/11] Device tree support for Imagination Series5 GPU Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-08 18:32 ` [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Andrew Davis
2024-01-08 18:32 ` [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img, powervr to img, powervr-rogue Andrew Davis
2024-01-08 18:32 ` [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Andrew Davis
2024-01-09 8:14 ` [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img, powervr to img, powervr-rogue Javier Martinez Canillas
2024-01-09 8:14 ` Javier Martinez Canillas
2024-01-09 8:14 ` Javier Martinez Canillas
2024-01-09 9:40 ` [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue Frank Binns
2024-01-09 9:40 ` Frank Binns
2024-01-09 9:40 ` Frank Binns
2024-01-09 11:28 ` Krzysztof Kozlowski
2024-01-09 11:28 ` Krzysztof Kozlowski
2024-01-09 11:28 ` Krzysztof Kozlowski
2024-01-09 16:14 ` Andrew Davis
2024-01-09 16:14 ` Andrew Davis
2024-01-09 16:14 ` Andrew Davis
2024-01-09 18:55 ` Krzysztof Kozlowski [this message]
2024-01-09 18:55 ` Krzysztof Kozlowski
2024-01-09 18:55 ` Krzysztof Kozlowski
2024-01-08 18:32 ` [PATCH RFC v2 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-09 11:32 ` Krzysztof Kozlowski
2024-01-09 11:32 ` Krzysztof Kozlowski
2024-01-09 11:32 ` Krzysztof Kozlowski
2024-01-09 16:53 ` Andrew Davis
2024-01-09 16:53 ` Andrew Davis
2024-01-09 16:53 ` Andrew Davis
2024-01-09 18:58 ` Krzysztof Kozlowski
2024-01-09 18:58 ` Krzysztof Kozlowski
2024-01-09 18:58 ` Krzysztof Kozlowski
2024-01-08 18:32 ` [PATCH RFC v2 03/11] ARM: dts: omap3: Add device tree entry for SGX GPU Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-08 18:32 ` [PATCH RFC v2 04/11] ARM: dts: omap4: " Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-12 17:33 ` H. Nikolaus Schaller
2024-01-12 17:33 ` H. Nikolaus Schaller
2024-01-12 17:33 ` H. Nikolaus Schaller
2024-01-15 8:25 ` Maxime Ripard
2024-01-15 8:25 ` Maxime Ripard
2024-01-15 8:25 ` Maxime Ripard
2024-01-15 8:55 ` H. Nikolaus Schaller
2024-01-15 8:55 ` H. Nikolaus Schaller
2024-01-15 8:55 ` H. Nikolaus Schaller
2024-01-15 9:50 ` Andreas Kemnade
2024-01-15 9:50 ` Andreas Kemnade
2024-01-15 9:50 ` Andreas Kemnade
2024-01-15 14:45 ` Maxime Ripard
2024-01-15 14:45 ` Maxime Ripard
2024-01-15 14:45 ` Maxime Ripard
2024-01-08 18:32 ` [PATCH RFC v2 05/11] ARM: dts: omap5: " Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-08 18:32 ` [PATCH RFC v2 06/11] ARM: dts: AM33xx: " Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-09 8:17 ` Javier Martinez Canillas
2024-01-08 18:32 ` [PATCH RFC v2 07/11] ARM: dts: AM437x: " Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-09 8:18 ` Javier Martinez Canillas
2024-01-09 8:18 ` Javier Martinez Canillas
2024-01-09 8:18 ` Javier Martinez Canillas
2024-01-08 18:32 ` [PATCH RFC v2 08/11] ARM: dts: DRA7xx: " Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-08 18:32 ` Andrew Davis
2024-01-09 8:18 ` Javier Martinez Canillas
2024-01-09 8:18 ` Javier Martinez Canillas
2024-01-09 8:18 ` Javier Martinez Canillas
2024-01-08 18:33 ` [PATCH RFC v2 09/11] arm64: dts: ti: k3-am654-main: " Andrew Davis
2024-01-08 18:33 ` Andrew Davis
2024-01-08 18:33 ` Andrew Davis
2024-01-08 18:33 ` [PATCH RFC v2 10/11] ARM: dts: sun6i: " Andrew Davis
2024-01-08 18:33 ` Andrew Davis
2024-01-08 18:33 ` Andrew Davis
2024-01-08 18:33 ` [PATCH RFC v2 11/11] MIPS: DTS: jz4780: " Andrew Davis
2024-01-08 18:33 ` Andrew Davis
2024-01-08 18:33 ` Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=291ca046-c034-48a8-93d8-c4cb1cdfaf20@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afd@ti.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=donald.robson@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.binns@imgtec.com \
--cc=hns@goldelico.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=mripard@kernel.org \
--cc=nm@ti.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=tony@atomide.com \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.