Re: [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue

From: Frank Binns <Frank.Binns@imgtec.com>
To: "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"kristo@kernel.org" <kristo@kernel.org>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"hns@goldelico.com" <hns@goldelico.com>,
	"afd@ti.com" <afd@ti.com>,
	"paul@crapouillou.net" <paul@crapouillou.net>,
	Matt Coster <Matt.Coster@imgtec.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"aford173@gmail.com" <aford173@gmail.com>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"tony@atomide.com" <tony@atomide.com>,
	"wens@csie.org" <wens@csie.org>,
	"ivo.g.dimitrov.75@gmail.com" <ivo.g.dimitrov.75@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"bcousson@baylibre.com" <bcousson@baylibre.com>,
	"nm@ti.com" <nm@ti.com>,
	"samuel@sholland.org" <samuel@sholland.org>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-sunxi@lists.linux.dev" <linux-sunxi@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue
Date: Tue, 9 Jan 2024 09:40:03 +0000	[thread overview]
Message-ID: <c7d3d992c7a6c4f4141769b16818a977a868755a.camel@imgtec.com> (raw)
In-Reply-To: <20240108183302.255055-2-afd@ti.com>

Hi Andrew,

On Mon, 2024-01-08 at 12:32 -0600, Andrew Davis wrote:
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  .../bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} | 4 ++--
>  MAINTAINERS                                                   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>  rename Documentation/devicetree/bindings/gpu/{img,powervr.yaml => img,powervr-rogue.yaml} (91%)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> similarity index 91%
> rename from Documentation/devicetree/bindings/gpu/img,powervr.yaml
> rename to Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> index a13298f1a1827..03a8308b41ae7 100644
> --- a/Documentation/devicetree/bindings/gpu/img,powervr.yaml
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> @@ -2,10 +2,10 @@
>  # Copyright (c) 2023 Imagination Technologies Ltd.
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/gpu/img,powervr.yaml#
> +$id: http://devicetree.org/schemas/gpu/img,powervr-rogue.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Imagination Technologies PowerVR and IMG GPU
> +title: Imagination Technologies PowerVR Rogue and IMG GPUs

All the GPUs that will appear in this file will be Rogues, so for me it would be
more natural for 'Rogue' to come after 'IMG'. Can you change the title to:

Imagination Technologies PowerVR and IMG Rogue GPUs
With that changed and Javier's suggestions addressed:
Reviewed-by: Frank Binns <frank.binns@imgtec.com>

>  
>  maintainers:
>    - Frank Binns <frank.binns@imgtec.com>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fa67e2624723f..5b205795da04e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10461,7 +10461,7 @@ M:	Donald Robson <donald.robson@imgtec.com>
>  M:	Matt Coster <matt.coster@imgtec.com>
>  S:	Supported
>  T:	git git://anongit.freedesktop.org/drm/drm-misc
> -F:	Documentation/devicetree/bindings/gpu/img,powervr.yaml
> +F:	Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
>  F:	Documentation/gpu/imagination/
>  F:	drivers/gpu/drm/imagination/
>  F:	include/uapi/drm/pvr_drm.h