Re: [PATCH v3 12/13] ARM: dts: imx: add i.MXRT1050-EVK support

From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Rob Herring <robh@kernel.org>, Jesse Taube <mr.bossman075@gmail.com>
Cc: linux-imx@nxp.com, mturquette@baylibre.com, sboyd@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch,
	linus.walleij@linaro.org, gregkh@linuxfoundation.org,
	arnd@arndb.de, olof@lixom.net, soc@kernel.org,
	linux@armlinux.org.uk, abel.vesa@nxp.com,
	adrian.hunter@intel.com, jirislaby@kernel.org,
	nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 12/13] ARM: dts: imx: add i.MXRT1050-EVK support
Date: Fri, 3 Dec 2021 02:04:03 +0100	[thread overview]
Message-ID: <3E371C48-DAA9-4CE7-A907-04D755C981AE@benettiengineering.com> (raw)
In-Reply-To: <c488ed94-ad0e-a326-adda-c4d782dbd6ef@benettiengineering.com>

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

> Il giorno 3 dic 2021, alle ore 01:20, Giulio Benetti <giulio.benetti@benettiengineering.com> ha scritto:
> 
> Hi Rob, Jesse,
> 
> On 28/11/21 17:43, Rob Herring wrote:
> 
> [SNIP]
> 
>>> diff --git a/arch/arm/boot/dts/imxrt1050.dtsi b/arch/arm/boot/dts/imxrt1050.dtsi
>>> new file mode 100644
>>> index 000000000000..35943a6896fa
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imxrt1050.dtsi
>>> @@ -0,0 +1,165 @@
>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> +/*
>>> + * Copyright (C) 2019
>>> + * Author(s): Giulio Benetti <giulio.benetti@benettiengineering.com>
>>> + */
>>> +
>>> +#include "armv7-m.dtsi"
>>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +#include <dt-bindings/clock/imxrt1050-clock.h>
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +
>>> +/ {
>>> +    #address-cells = <1>;
>>> +    #size-cells = <1>;
>>> +
>>> +    clocks {
>>> +        osc: osc {
>>> +            compatible = "fsl,imx-osc", "fixed-clock";
>> fsl,imx-osc is not documented. IMO, just drop it.
> 
> Regarding this ^^^, you're right, so we avoid to add "fsl,imx-osc", but at this point, does it make sense we create a patchset to remove it from the other .dts(i) files that use it? And same goes for "fsl,imx-ckil", "fsl,imx-ckih1", "fsl,imx-ckih2"?
> 
> I see that those try to repeat the name of the node itself so they are useless. If you say so I send a patchset for that.

I’ve just made and sent such patchset:

https://lore.kernel.org/linux-arm-kernel/20211203004039.48752-1-giulio.benetti@benettiengineering.com/T/#t

Best regards
Giulio

> 
> Thank you
> Best regards
> -- 
> Giulio Benetti
> Benetti Engineering sas

[-- Attachment #2: Type: text/html, Size: 4604 bytes --]