Re: [PATCH v3 07/13] clk: imx: Add initial support for i.MXRT clock driver

From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Jesse Taube <mr.bossman075@gmail.com>,
	Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Sascha Hauer <kernel@pengutronix.de>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Stefan Agner <stefan@agner.ch>,
	Linus Walleij <linus.walleij@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	soc@kernel.org, Russell King - ARM Linux <linux@armlinux.org.uk>,
	Abel Vesa <abel.vesa@nxp.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	linux-clk <linux-clk@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 07/13] clk: imx: Add initial support for i.MXRT clock driver
Date: Sun, 28 Nov 2021 23:17:50 +0100	[thread overview]
Message-ID: <de705094-1b8c-3950-b7f5-f7150b525ea5@benettiengineering.com> (raw)
In-Reply-To: <dae68360-456e-3db8-57ed-2287dc7cfd57@gmail.com>

Hi Jesse, Fabio,

On 28/11/21 21:52, Jesse Taube wrote:
> 
> 
> On 11/28/21 15:50, Fabio Estevam wrote:
>> On Thu, Nov 25, 2021 at 6:14 PM Jesse Taube <mr.bossman075@gmail.com> wrote:
>>>
>>> From: Jesse Taube <mr.bossman075@gmail.com>
>>>
>>> This patch adds initial clock driver support for the i.MXRT series.

Also the commit log must be modified according(Summary+body).

Thank you
-- 
Giulio Benetti
Benetti Engineering sas

>>> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
>>> Suggested-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>> ---
>>> V1->V2:
>>> * Kconfig: Add new line
>>> * clk-imxrt.c: Remove unused const
>>> * clk-imxrt.c: Remove set parents
>>> * clk-imxrt.c: Use fsl,imxrt-anatop for anatop base address
>>> V2->V3:
>>> * Remove unused ANATOP_BASE_ADDR
>>> * Move to hw API
>>> * Add GPT's own clock
>>> * Add SEMC clocks to set muxing to CRITICAL
>>> ---
>>>    drivers/clk/imx/Kconfig     |   4 +
>>>    drivers/clk/imx/Makefile    |   1 +
>>>    drivers/clk/imx/clk-imxrt.c | 156 ++++++++++++++++++++++++++++++++++++
>>
>> Wouldn't it be better to name it clk-imxrt1050.c instead?
> we can have multiple imxrt versions in there like the other IMX clk
> drivers, is this okay?
>>