From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Frank Li <Frank.Li@nxp.com>, robh@kernel.org Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, gregkh@linuxfoundation.org, imx@lists.linux.dev, jirislaby@kernel.org, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, miquel.raynal@bootlin.com, zbigniew.lukwinski@linux.intel.com, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org Subject: Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-target-v1 Date: Fri, 12 Jan 2024 08:38:39 +0100 [thread overview] Message-ID: <3c0be658-e7a6-4231-b206-86ffb47e0cb2@linaro.org> (raw) In-Reply-To: <20240110175221.2335480-3-Frank.Li@nxp.com> On 10/01/2024 18:52, Frank Li wrote: > Add compatible string 'silvaco,i3c-target-v1' for target mode. Your subject has some multiple prefixes? Why there is one more ":"? Just: add XYZ device > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../devicetree/bindings/i3c/silvaco,i3c-master.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > index 133855f11b4f5..17849c91d4d2b 100644 > --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Silvaco I3C master > +title: Silvaco I3C master/target > > maintainers: > - Conor Culhane <conor.culhane@silvaco.com> > @@ -14,8 +14,9 @@ allOf: > > properties: > compatible: > - const: silvaco,i3c-master-v1 NAK, you got comment, didn't you? Why did you ignore it? It's like third time you try to push it ignoring what we keep asking. Pushing the same without resolving anything in previous discussion is not acceptable and it feels like waste of my time. > - Why are you removing the blank line? Best regards, Krzysztof -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Frank Li <Frank.Li@nxp.com>, robh@kernel.org Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, gregkh@linuxfoundation.org, imx@lists.linux.dev, jirislaby@kernel.org, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, miquel.raynal@bootlin.com, zbigniew.lukwinski@linux.intel.com, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org Subject: Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-target-v1 Date: Fri, 12 Jan 2024 08:38:39 +0100 [thread overview] Message-ID: <3c0be658-e7a6-4231-b206-86ffb47e0cb2@linaro.org> (raw) In-Reply-To: <20240110175221.2335480-3-Frank.Li@nxp.com> On 10/01/2024 18:52, Frank Li wrote: > Add compatible string 'silvaco,i3c-target-v1' for target mode. Your subject has some multiple prefixes? Why there is one more ":"? Just: add XYZ device > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../devicetree/bindings/i3c/silvaco,i3c-master.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > index 133855f11b4f5..17849c91d4d2b 100644 > --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Silvaco I3C master > +title: Silvaco I3C master/target > > maintainers: > - Conor Culhane <conor.culhane@silvaco.com> > @@ -14,8 +14,9 @@ allOf: > > properties: > compatible: > - const: silvaco,i3c-master-v1 NAK, you got comment, didn't you? Why did you ignore it? It's like third time you try to push it ignoring what we keep asking. Pushing the same without resolving anything in previous discussion is not acceptable and it feels like waste of my time. > - Why are you removing the blank line? Best regards, Krzysztof
next prev parent reply other threads:[~2024-01-12 7:38 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-10 17:52 [PATCH v2 0/7] I3C target mode support Frank Li 2024-01-10 17:52 ` Frank Li 2024-01-10 17:52 ` [PATCH v2 1/7] i3c: add " Frank Li 2024-01-10 17:52 ` Frank Li 2024-01-10 17:52 ` [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-target-v1 Frank Li 2024-01-10 17:52 ` Frank Li 2024-01-12 7:38 ` Krzysztof Kozlowski [this message] 2024-01-12 7:38 ` Krzysztof Kozlowski 2024-01-12 15:31 ` Frank Li 2024-01-12 15:31 ` Frank Li 2024-01-12 15:50 ` Krzysztof Kozlowski 2024-01-12 15:50 ` Krzysztof Kozlowski 2024-01-12 16:00 ` Krzysztof Kozlowski 2024-01-12 16:00 ` Krzysztof Kozlowski 2024-01-12 16:06 ` Frank Li 2024-01-12 16:06 ` Frank Li 2024-01-15 19:44 ` Frank Li 2024-01-15 19:44 ` Frank Li 2024-01-15 20:38 ` Krzysztof Kozlowski 2024-01-15 20:38 ` Krzysztof Kozlowski 2024-01-16 2:29 ` Frank Li 2024-01-16 2:29 ` Frank Li 2024-01-16 7:24 ` Krzysztof Kozlowski 2024-01-16 7:24 ` Krzysztof Kozlowski 2024-01-16 9:30 ` Conor Dooley 2024-01-16 9:30 ` Conor Dooley 2024-01-16 9:33 ` Krzysztof Kozlowski 2024-01-16 9:33 ` Krzysztof Kozlowski 2024-01-16 9:48 ` Conor Dooley 2024-01-16 9:48 ` Conor Dooley 2024-01-16 17:35 ` Frank Li 2024-01-16 17:35 ` Frank Li 2024-01-16 18:23 ` Conor Dooley 2024-01-16 18:23 ` Conor Dooley 2024-01-16 19:13 ` Frank Li 2024-01-16 19:13 ` Frank Li 2024-01-16 20:30 ` Krzysztof Kozlowski 2024-01-16 20:30 ` Krzysztof Kozlowski 2024-01-16 20:44 ` Frank Li 2024-01-16 20:44 ` Frank Li 2024-01-16 20:56 ` Krzysztof Kozlowski 2024-01-16 20:56 ` Krzysztof Kozlowski 2024-01-16 21:01 ` Krzysztof Kozlowski 2024-01-16 21:01 ` Krzysztof Kozlowski 2024-01-16 22:25 ` Frank Li 2024-01-16 22:25 ` Frank Li 2024-01-17 6:50 ` Krzysztof Kozlowski 2024-01-17 6:50 ` Krzysztof Kozlowski 2024-01-17 16:19 ` Frank Li 2024-01-17 16:19 ` Frank Li 2024-01-17 17:15 ` Krzysztof Kozlowski 2024-01-17 17:15 ` Krzysztof Kozlowski 2024-01-17 18:06 ` Frank Li 2024-01-17 18:06 ` Frank Li 2024-01-19 17:13 ` Frank Li 2024-01-19 17:13 ` Frank Li 2024-01-16 21:31 ` Frank Li 2024-01-16 21:31 ` Frank Li 2024-01-17 6:45 ` Krzysztof Kozlowski 2024-01-17 6:45 ` Krzysztof Kozlowski 2024-01-10 17:52 ` [PATCH v2 3/7] Documentation: i3c: Add I3C target mode controller and function Frank Li 2024-01-10 17:52 ` Frank Li 2024-01-11 23:45 ` kernel test robot 2024-01-11 23:45 ` kernel test robot 2024-01-10 17:52 ` [PATCH v2 4/7] i3c: target: add svc target controller support Frank Li 2024-01-10 17:52 ` Frank Li 2024-01-11 10:01 ` kernel test robot 2024-01-11 10:01 ` kernel test robot 2024-01-11 13:49 ` kernel test robot 2024-01-11 13:49 ` kernel test robot 2024-01-10 17:52 ` [PATCH v2 5/7] i3c: target: func: add tty driver Frank Li 2024-01-10 17:52 ` Frank Li 2024-01-10 17:52 ` [PATCH v2 6/7] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li 2024-01-10 17:52 ` Frank Li 2024-01-10 17:52 ` [PATCH v2 7/7] tty: i3c: add TTY over I3C master support Frank Li 2024-01-10 17:52 ` Frank Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3c0be658-e7a6-4231-b206-86ffb47e0cb2@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=Frank.Li@nxp.com \ --cc=alexandre.belloni@bootlin.com \ --cc=conor.culhane@silvaco.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=imx@lists.linux.dev \ --cc=jirislaby@kernel.org \ --cc=joe@perches.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ --cc=robh@kernel.org \ --cc=zbigniew.lukwinski@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.