From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Conor Dooley <conor@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
robh@kernel.org, alexandre.belloni@bootlin.com,
conor.culhane@silvaco.com, gregkh@linuxfoundation.org,
imx@lists.linux.dev, jirislaby@kernel.org, joe@perches.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, miquel.raynal@bootlin.com,
zbigniew.lukwinski@linux.intel.com, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-target-v1
Date: Wed, 17 Jan 2024 07:45:12 +0100 [thread overview]
Message-ID: <afc98dd0-b83f-44e4-bcb0-961155c73113@linaro.org> (raw)
In-Reply-To: <Zab1qj3+6daX8QH0@lizhi-Precision-Tower-5810>
On 16/01/2024 22:31, Frank Li wrote:
>>>>>>>
>>>>>>> Is it okay for 'silvaco,i3c-target-imx93'?
>>>>
>>>> No, because imx93 is product of NXP, not Silvaco.
>>>>
>>>> You need regular SoC-block compatibles, just like we have for all other
>>>> snps, dwc and cdns.
>>>
>>> "nxp,imx93-svc-i3c-target" ?
>>
>> Could be, now please point me to patch adding such code to DTS. I would
>> like to see the real use case for it.
>
> This part have not sent to review yet. basically in imx93evk.dts add
>
> &i3c1 {
> compatible = "silvaco,i3c-target-v1";
> pinctrl-names = "default", "sleep";
> pinctrl-0 = <&pinctrl_i3c1>;
> pinctrl-1 = <&pinctrl_i3c1>;
> status = "okay"
> }
Overriding compatible is not desired. It also supports here the
statement that this is the same hardware.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Conor Dooley <conor@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
robh@kernel.org, alexandre.belloni@bootlin.com,
conor.culhane@silvaco.com, gregkh@linuxfoundation.org,
imx@lists.linux.dev, jirislaby@kernel.org, joe@perches.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, miquel.raynal@bootlin.com,
zbigniew.lukwinski@linux.intel.com, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-target-v1
Date: Wed, 17 Jan 2024 07:45:12 +0100 [thread overview]
Message-ID: <afc98dd0-b83f-44e4-bcb0-961155c73113@linaro.org> (raw)
In-Reply-To: <Zab1qj3+6daX8QH0@lizhi-Precision-Tower-5810>
On 16/01/2024 22:31, Frank Li wrote:
>>>>>>>
>>>>>>> Is it okay for 'silvaco,i3c-target-imx93'?
>>>>
>>>> No, because imx93 is product of NXP, not Silvaco.
>>>>
>>>> You need regular SoC-block compatibles, just like we have for all other
>>>> snps, dwc and cdns.
>>>
>>> "nxp,imx93-svc-i3c-target" ?
>>
>> Could be, now please point me to patch adding such code to DTS. I would
>> like to see the real use case for it.
>
> This part have not sent to review yet. basically in imx93evk.dts add
>
> &i3c1 {
> compatible = "silvaco,i3c-target-v1";
> pinctrl-names = "default", "sleep";
> pinctrl-0 = <&pinctrl_i3c1>;
> pinctrl-1 = <&pinctrl_i3c1>;
> status = "okay"
> }
Overriding compatible is not desired. It also supports here the
statement that this is the same hardware.
Best regards,
Krzysztof
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2024-01-17 6:45 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 17:52 [PATCH v2 0/7] I3C target mode support Frank Li
2024-01-10 17:52 ` Frank Li
2024-01-10 17:52 ` [PATCH v2 1/7] i3c: add " Frank Li
2024-01-10 17:52 ` Frank Li
2024-01-10 17:52 ` [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-target-v1 Frank Li
2024-01-10 17:52 ` Frank Li
2024-01-12 7:38 ` Krzysztof Kozlowski
2024-01-12 7:38 ` Krzysztof Kozlowski
2024-01-12 15:31 ` Frank Li
2024-01-12 15:31 ` Frank Li
2024-01-12 15:50 ` Krzysztof Kozlowski
2024-01-12 15:50 ` Krzysztof Kozlowski
2024-01-12 16:00 ` Krzysztof Kozlowski
2024-01-12 16:00 ` Krzysztof Kozlowski
2024-01-12 16:06 ` Frank Li
2024-01-12 16:06 ` Frank Li
2024-01-15 19:44 ` Frank Li
2024-01-15 19:44 ` Frank Li
2024-01-15 20:38 ` Krzysztof Kozlowski
2024-01-15 20:38 ` Krzysztof Kozlowski
2024-01-16 2:29 ` Frank Li
2024-01-16 2:29 ` Frank Li
2024-01-16 7:24 ` Krzysztof Kozlowski
2024-01-16 7:24 ` Krzysztof Kozlowski
2024-01-16 9:30 ` Conor Dooley
2024-01-16 9:30 ` Conor Dooley
2024-01-16 9:33 ` Krzysztof Kozlowski
2024-01-16 9:33 ` Krzysztof Kozlowski
2024-01-16 9:48 ` Conor Dooley
2024-01-16 9:48 ` Conor Dooley
2024-01-16 17:35 ` Frank Li
2024-01-16 17:35 ` Frank Li
2024-01-16 18:23 ` Conor Dooley
2024-01-16 18:23 ` Conor Dooley
2024-01-16 19:13 ` Frank Li
2024-01-16 19:13 ` Frank Li
2024-01-16 20:30 ` Krzysztof Kozlowski
2024-01-16 20:30 ` Krzysztof Kozlowski
2024-01-16 20:44 ` Frank Li
2024-01-16 20:44 ` Frank Li
2024-01-16 20:56 ` Krzysztof Kozlowski
2024-01-16 20:56 ` Krzysztof Kozlowski
2024-01-16 21:01 ` Krzysztof Kozlowski
2024-01-16 21:01 ` Krzysztof Kozlowski
2024-01-16 22:25 ` Frank Li
2024-01-16 22:25 ` Frank Li
2024-01-17 6:50 ` Krzysztof Kozlowski
2024-01-17 6:50 ` Krzysztof Kozlowski
2024-01-17 16:19 ` Frank Li
2024-01-17 16:19 ` Frank Li
2024-01-17 17:15 ` Krzysztof Kozlowski
2024-01-17 17:15 ` Krzysztof Kozlowski
2024-01-17 18:06 ` Frank Li
2024-01-17 18:06 ` Frank Li
2024-01-19 17:13 ` Frank Li
2024-01-19 17:13 ` Frank Li
2024-01-16 21:31 ` Frank Li
2024-01-16 21:31 ` Frank Li
2024-01-17 6:45 ` Krzysztof Kozlowski [this message]
2024-01-17 6:45 ` Krzysztof Kozlowski
2024-01-10 17:52 ` [PATCH v2 3/7] Documentation: i3c: Add I3C target mode controller and function Frank Li
2024-01-10 17:52 ` Frank Li
2024-01-11 23:45 ` kernel test robot
2024-01-11 23:45 ` kernel test robot
2024-01-10 17:52 ` [PATCH v2 4/7] i3c: target: add svc target controller support Frank Li
2024-01-10 17:52 ` Frank Li
2024-01-11 10:01 ` kernel test robot
2024-01-11 10:01 ` kernel test robot
2024-01-11 13:49 ` kernel test robot
2024-01-11 13:49 ` kernel test robot
2024-01-10 17:52 ` [PATCH v2 5/7] i3c: target: func: add tty driver Frank Li
2024-01-10 17:52 ` Frank Li
2024-01-10 17:52 ` [PATCH v2 6/7] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li
2024-01-10 17:52 ` Frank Li
2024-01-10 17:52 ` [PATCH v2 7/7] tty: i3c: add TTY over I3C master support Frank Li
2024-01-10 17:52 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afc98dd0-b83f-44e4-bcb0-961155c73113@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=joe@perches.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=robh@kernel.org \
--cc=zbigniew.lukwinski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.