From: Jocelyn Falempe <jfalempe@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, michel@daenzer.net, tzimmermann@suse.de,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/mgag200: Fix PLL setup for g200wb and g200ew
Date: Tue, 8 Mar 2022 18:36:31 +0100 [thread overview]
Message-ID: <45beb705-57f2-8574-32b2-7ffe8300d990@redhat.com> (raw)
In-Reply-To: <YieS530V0nGYydGa@kroah.com>
On 08/03/2022 18:31, Greg KH wrote:
> On Tue, Mar 08, 2022 at 06:11:11PM +0100, Jocelyn Falempe wrote:
>> commit f86c3ed55920ca1d874758cc290890902a6cffc4 ("drm/mgag200: Split PLL
>> setup into compute and update functions") introduced a regression for
>> g200wb and g200ew.
>
> No need for all those digits in the sha1, see below:
>
>> The PLLs are not set up properly, and VGA screen stays
>> black, or displays "out of range" message.
>>
>> MGA1064_WB_PIX_PLLC_N/M/P was mistakenly replaced with
>> MGA1064_PIX_PLLC_N/M/P which have different addresses.
>>
>> Patch tested on a Dell T310 with g200wb
>>
>> Fixes: f86c3ed55920ca1d874758cc290890902a6cffc4
>
> As per the documentation that line should read:
>
> Fixes: f86c3ed55920 ("drm/mgag200: Split PLL setup into compute and update functions")
Sorry, I will send a v2 shortly.
>
> thanks,
>
> greg k-h
>
WARNING: multiple messages have this Message-ID (diff)
From: Jocelyn Falempe <jfalempe@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: dri-devel@lists.freedesktop.org, michel@daenzer.net,
tzimmermann@suse.de, stable@vger.kernel.org
Subject: Re: [PATCH] drm/mgag200: Fix PLL setup for g200wb and g200ew
Date: Tue, 8 Mar 2022 18:36:31 +0100 [thread overview]
Message-ID: <45beb705-57f2-8574-32b2-7ffe8300d990@redhat.com> (raw)
In-Reply-To: <YieS530V0nGYydGa@kroah.com>
On 08/03/2022 18:31, Greg KH wrote:
> On Tue, Mar 08, 2022 at 06:11:11PM +0100, Jocelyn Falempe wrote:
>> commit f86c3ed55920ca1d874758cc290890902a6cffc4 ("drm/mgag200: Split PLL
>> setup into compute and update functions") introduced a regression for
>> g200wb and g200ew.
>
> No need for all those digits in the sha1, see below:
>
>> The PLLs are not set up properly, and VGA screen stays
>> black, or displays "out of range" message.
>>
>> MGA1064_WB_PIX_PLLC_N/M/P was mistakenly replaced with
>> MGA1064_PIX_PLLC_N/M/P which have different addresses.
>>
>> Patch tested on a Dell T310 with g200wb
>>
>> Fixes: f86c3ed55920ca1d874758cc290890902a6cffc4
>
> As per the documentation that line should read:
>
> Fixes: f86c3ed55920 ("drm/mgag200: Split PLL setup into compute and update functions")
Sorry, I will send a v2 shortly.
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2022-03-08 17:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 17:11 [PATCH] drm/mgag200: Fix PLL setup for g200wb and g200ew Jocelyn Falempe
2022-03-08 17:11 ` Jocelyn Falempe
2022-03-08 17:31 ` Greg KH
2022-03-08 17:31 ` Greg KH
2022-03-08 17:36 ` Jocelyn Falempe [this message]
2022-03-08 17:36 ` Jocelyn Falempe
2022-03-08 17:43 ` [PATCH v2] " Jocelyn Falempe
2022-03-08 17:43 ` Jocelyn Falempe
2022-03-13 19:39 ` Thomas Zimmermann
2022-03-13 19:39 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45beb705-57f2-8574-32b2-7ffe8300d990@redhat.com \
--to=jfalempe@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=michel@daenzer.net \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.