From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Inochi Amaoto <inochiama@outlook.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen Wang <unicorn_wang@outlook.com>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu> Cc: Jisheng Zhang <jszhang@kernel.org>, Liu Gui <kenneth.liu@sophgo.com>, Jingbao Qiu <qiujingbao.dlmu@gmail.com>, dlan@gentoo.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v5 1/3] dt-bindings: dmaengine: Add dmamux for CV18XX/SG200X series SoC Date: Tue, 26 Mar 2024 09:53:09 +0100 [thread overview] Message-ID: <473528ac-dce2-41e3-a6d7-28f8c53a89ef@linaro.org> (raw) In-Reply-To: <IA1PR20MB4953EDEEFC3128741F8E152EBB352@IA1PR20MB4953.namprd20.prod.outlook.com> On 26/03/2024 08:35, Inochi Amaoto wrote: >>> + >>> +required: >>> + - '#dma-cells' >>> + - dma-masters >>> + >> >> >> I don't understand what happened here. Previously you had a child and I >> proposed to properly describe it with $ref. >> >> Now, all children are gone. Binding is supposed to be complete. Based on >> your cover letter, this is not complete, but why? What is missing and >> why it cannot be added? >> > > The binding of syscon is removed due to a usb phy subdevices, which needs > sometime to figure out the actual property. This is why the syscon binding > is removed. > > I think it is better to use the origianl syscon series to evolve after > the usb phy binding is submitted. The subdevices of syscon may need > much reverse engineering to know its parameters. So at least for now, > the syscon binding is hard to be complete. Some explanation why dma-router is gone would be useful, but fine. > >> >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + dma-router { >>> + compatible = "sophgo,cv1800-dmamux"; >>> + #dma-cells = <2>; >>> + dma-masters = <&dmac>; >>> + dma-requests = <8>; >>> + }; >>> diff --git a/include/dt-bindings/dma/cv1800-dma.h b/include/dt-bindings/dma/cv1800-dma.h >>> new file mode 100644 >>> index 000000000000..3ce9dac25259 >>> --- /dev/null >>> +++ b/include/dt-bindings/dma/cv1800-dma.h >> >> Filename should match bindings filename. >> > > Thanks. > >> >> Anyway, the problem is that it is a dead header. I don't see it being >> used, so it is not a binding. >> > > This header is not used because the dmamux node is not defined at now. In the driver? The binding header is supposed to be used in the driver, otherwise it is not a binding. > And considering the limitation of this dmamux, maybe only devices that > require dma as a must can have the dma assigned. > Due to the fact, I think it may be a long time to wait for this header > to be used as the binding header. I don't understand. You did not provide a single reason why this is a binding. Reason is: mapping IDs between DTS and driver. Where is this reason? Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Inochi Amaoto <inochiama@outlook.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen Wang <unicorn_wang@outlook.com>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu> Cc: Jisheng Zhang <jszhang@kernel.org>, Liu Gui <kenneth.liu@sophgo.com>, Jingbao Qiu <qiujingbao.dlmu@gmail.com>, dlan@gentoo.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v5 1/3] dt-bindings: dmaengine: Add dmamux for CV18XX/SG200X series SoC Date: Tue, 26 Mar 2024 09:53:09 +0100 [thread overview] Message-ID: <473528ac-dce2-41e3-a6d7-28f8c53a89ef@linaro.org> (raw) In-Reply-To: <IA1PR20MB4953EDEEFC3128741F8E152EBB352@IA1PR20MB4953.namprd20.prod.outlook.com> On 26/03/2024 08:35, Inochi Amaoto wrote: >>> + >>> +required: >>> + - '#dma-cells' >>> + - dma-masters >>> + >> >> >> I don't understand what happened here. Previously you had a child and I >> proposed to properly describe it with $ref. >> >> Now, all children are gone. Binding is supposed to be complete. Based on >> your cover letter, this is not complete, but why? What is missing and >> why it cannot be added? >> > > The binding of syscon is removed due to a usb phy subdevices, which needs > sometime to figure out the actual property. This is why the syscon binding > is removed. > > I think it is better to use the origianl syscon series to evolve after > the usb phy binding is submitted. The subdevices of syscon may need > much reverse engineering to know its parameters. So at least for now, > the syscon binding is hard to be complete. Some explanation why dma-router is gone would be useful, but fine. > >> >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + dma-router { >>> + compatible = "sophgo,cv1800-dmamux"; >>> + #dma-cells = <2>; >>> + dma-masters = <&dmac>; >>> + dma-requests = <8>; >>> + }; >>> diff --git a/include/dt-bindings/dma/cv1800-dma.h b/include/dt-bindings/dma/cv1800-dma.h >>> new file mode 100644 >>> index 000000000000..3ce9dac25259 >>> --- /dev/null >>> +++ b/include/dt-bindings/dma/cv1800-dma.h >> >> Filename should match bindings filename. >> > > Thanks. > >> >> Anyway, the problem is that it is a dead header. I don't see it being >> used, so it is not a binding. >> > > This header is not used because the dmamux node is not defined at now. In the driver? The binding header is supposed to be used in the driver, otherwise it is not a binding. > And considering the limitation of this dmamux, maybe only devices that > require dma as a must can have the dma assigned. > Due to the fact, I think it may be a long time to wait for this header > to be used as the binding header. I don't understand. You did not provide a single reason why this is a binding. Reason is: mapping IDs between DTS and driver. Where is this reason? Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-03-26 8:53 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-26 1:44 [PATCH v5 0/3] riscv: sophgo: add dmamux support for Sophgo CV1800/SG2000 SoCs Inochi Amaoto 2024-03-26 1:44 ` Inochi Amaoto 2024-03-26 1:47 ` [PATCH v5 1/3] dt-bindings: dmaengine: Add dmamux for CV18XX/SG200X series SoC Inochi Amaoto 2024-03-26 1:47 ` Inochi Amaoto 2024-03-26 3:37 ` Frank Li 2024-03-26 3:37 ` Frank Li 2024-03-26 3:49 ` Inochi Amaoto 2024-03-26 3:49 ` Inochi Amaoto 2024-03-26 6:50 ` Krzysztof Kozlowski 2024-03-26 6:50 ` Krzysztof Kozlowski 2024-03-26 6:51 ` Krzysztof Kozlowski 2024-03-26 6:51 ` Krzysztof Kozlowski 2024-03-26 6:57 ` Krzysztof Kozlowski 2024-03-26 6:57 ` Krzysztof Kozlowski 2024-03-26 7:35 ` Inochi Amaoto 2024-03-26 7:35 ` Inochi Amaoto 2024-03-26 8:53 ` Krzysztof Kozlowski [this message] 2024-03-26 8:53 ` Krzysztof Kozlowski 2024-03-26 11:15 ` Inochi Amaoto 2024-03-26 11:15 ` Inochi Amaoto 2024-03-26 11:31 ` Krzysztof Kozlowski 2024-03-26 11:31 ` Krzysztof Kozlowski 2024-03-26 11:41 ` Inochi Amaoto 2024-03-26 11:41 ` Inochi Amaoto 2024-03-26 11:50 ` Krzysztof Kozlowski 2024-03-26 11:50 ` Krzysztof Kozlowski 2024-03-26 12:06 ` Inochi Amaoto 2024-03-26 12:06 ` Inochi Amaoto 2024-03-26 12:14 ` Krzysztof Kozlowski 2024-03-26 12:14 ` Krzysztof Kozlowski 2024-03-26 12:19 ` Inochi Amaoto 2024-03-26 12:19 ` Inochi Amaoto 2024-03-26 1:47 ` [PATCH v5 2/3] soc/sophgo: add top sysctrl layout file for CV18XX/SG200X Inochi Amaoto 2024-03-26 1:47 ` Inochi Amaoto 2024-03-26 1:47 ` [PATCH v5 3/3] dmaengine: add driver for Sophgo CV18XX/SG200X dmamux Inochi Amaoto 2024-03-26 1:47 ` Inochi Amaoto
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=473528ac-dce2-41e3-a6d7-28f8c53a89ef@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=aou@eecs.berkeley.edu \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dlan@gentoo.org \ --cc=dmaengine@vger.kernel.org \ --cc=inochiama@outlook.com \ --cc=jszhang@kernel.org \ --cc=kenneth.liu@sophgo.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=qiujingbao.dlmu@gmail.com \ --cc=robh@kernel.org \ --cc=unicorn_wang@outlook.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.