Re: [RFC] allow multi-core guests: introduce cores= option to -cpu

From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Andre Przywara <andre.przywara@amd.com>,
	anthony@codemonkey.ws, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
Subject: Re: [RFC] allow multi-core guests: introduce cores= option to -cpu
Date: Sun, 05 Jul 2009 17:53:17 +0300	[thread overview]
Message-ID: <4A50BE5D.5010005@redhat.com> (raw)
In-Reply-To: <DB13E24C-654D-4752-884E-D951A42D4CB5@suse.de>

On 07/05/2009 04:23 PM, Alexander Graf wrote:
>> I thought of using -smp [processors=]2,cores=4,threads=2 (for a total 
>> of 16 threads), but I think it makes more sense with -cpu.
>
>
> I actually think putting this in -smp makes more sense. -cpu really 
> shouldn't need to be touched by normal users and as long as you can 
> either -cpu host or -cpu safe that should be enough.

Maybe.  But in that case -cpu core2duo should imply cores=2 and -smp 2 
-cpu core2duo will bring up 4 cores spread across two sockets.

> But then again maybe we should replace -smp with something more useful 
> like -numa where you'd then specify #CPUs, #cores, mem-cpu connection, 
> etc.

I'd prefer -numa to specify the memory topology (and connections of 
sockets to memory nodes), and -smp or -cpu to specify the intra-socket 
topology.

-- 
error compiling committee.c: too many arguments to function