Re: [RFC] allow multi-core guests: introduce cores= option to -cpu

From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Gleb Natapov <gleb@redhat.com>,
	Andre Przywara <andre.przywara@amd.com>,
	anthony@codemonkey.ws, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
Subject: Re: [RFC] allow multi-core guests: introduce cores= option to -cpu
Date: Sun, 05 Jul 2009 18:17:13 +0300	[thread overview]
Message-ID: <4A50C3F9.3000908@redhat.com> (raw)
In-Reply-To: <319A05B3-654C-478B-994F-12A56294CEFE@suse.de>

On 07/05/2009 06:11 PM, Alexander Graf wrote:
>
> On 05.07.2009, at 17:11, Avi Kivity wrote:
>
>> On 07/05/2009 06:04 PM, Gleb Natapov wrote:
>>> core2duo does not imply 2 cores. OSes use cpuid to discover this
>>> information.
>>>
>>
>> It does.  "Core 2" is the name of the core.  "Core 2 Duo" is a 2-core 
>> package containing (a pair) this core.  "Core 2 Solo" is a 
>> single-core package containing the core.
>
> Well, then let's better make it -cpu core2, no?

Maybe have all three.  But I agree -cpu core2 is better than -cpu core2duo.

> The only problem I see is how to generate the description string. 
> Model number and the likes should be identical to a Core2Solo, right?

I think so.

-- 
error compiling committee.c: too many arguments to function