From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Mike Leach <mike.leach@linaro.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Leo Yan <leo.yan@linaro.org>
Subject: Re: [PATCH v4 17/19] coresight: core: Add support for dedicated percpu sinks
Date: Mon, 22 Mar 2021 16:57:45 +0000 [thread overview]
Message-ID: <4fe2cce5-74b5-7ced-1a16-1dde90b920e2@arm.com> (raw)
In-Reply-To: <CAJ9a7VgWop-ifXgEoofGOJrKUWuSSK2VxD+6nchQiBxOOg3m3Q@mail.gmail.com>
Hi Mike
On 08/03/2021 17:26, Mike Leach wrote:
> Hi,
>
> On Thu, 25 Feb 2021 at 19:36, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>>
>> From: Anshuman Khandual <anshuman.khandual@arm.com>
>>
>> Add support for dedicated sinks that are bound to individual CPUs. (e.g,
>> TRBE). To allow quicker access to the sink for a given CPU bound source,
>> keep a percpu array of the sink devices. Also, add support for building
>> a path to the CPU local sink from the ETM.
>>
>> This adds a new percpu sink type CORESIGHT_DEV_SUBTYPE_SINK_PERCPU_SYSMEM.
>> This new sink type is exclusively available and can only work with percpu
>> source type device CORESIGHT_DEV_SUBTYPE_SOURCE_PROC.
>>
>
> Minor nit: FEAT_TRBE architecturally guarantees a compatible
> architectural FEAT_ETE source.
> However _all_ CPU sources have CORESIGHT_DEV_SUBTYPE_SOURCE_PROC set,
> ETMv3.x, PTM, ETM4.x and ETE alike.
> In the code that follows - coresight_is_percpu_source() checks it is
> any type of CPU source, not the FEAT_ETE type, which is fine as we
> then check the cpu and if it has TRBE.
Agreed. But we would like to keep this CoreSight generic code away from
the specifics of underlying "source", which is why we used the generic
notion of a per-CPU source.
> So the simplifications to the code from the first couple of patch sets
> make this explanation slightly misleading. Could do to adjust if
> re-spinning set.
>
> Reviewed-by: Mike Leach <mike.leach@linaro.org>
Thanks
Suzuki
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Mike Leach <mike.leach@linaro.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Leo Yan <leo.yan@linaro.org>
Subject: Re: [PATCH v4 17/19] coresight: core: Add support for dedicated percpu sinks
Date: Mon, 22 Mar 2021 16:57:45 +0000 [thread overview]
Message-ID: <4fe2cce5-74b5-7ced-1a16-1dde90b920e2@arm.com> (raw)
In-Reply-To: <CAJ9a7VgWop-ifXgEoofGOJrKUWuSSK2VxD+6nchQiBxOOg3m3Q@mail.gmail.com>
Hi Mike
On 08/03/2021 17:26, Mike Leach wrote:
> Hi,
>
> On Thu, 25 Feb 2021 at 19:36, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>>
>> From: Anshuman Khandual <anshuman.khandual@arm.com>
>>
>> Add support for dedicated sinks that are bound to individual CPUs. (e.g,
>> TRBE). To allow quicker access to the sink for a given CPU bound source,
>> keep a percpu array of the sink devices. Also, add support for building
>> a path to the CPU local sink from the ETM.
>>
>> This adds a new percpu sink type CORESIGHT_DEV_SUBTYPE_SINK_PERCPU_SYSMEM.
>> This new sink type is exclusively available and can only work with percpu
>> source type device CORESIGHT_DEV_SUBTYPE_SOURCE_PROC.
>>
>
> Minor nit: FEAT_TRBE architecturally guarantees a compatible
> architectural FEAT_ETE source.
> However _all_ CPU sources have CORESIGHT_DEV_SUBTYPE_SOURCE_PROC set,
> ETMv3.x, PTM, ETM4.x and ETE alike.
> In the code that follows - coresight_is_percpu_source() checks it is
> any type of CPU source, not the FEAT_ETE type, which is fine as we
> then check the cpu and if it has TRBE.
Agreed. But we would like to keep this CoreSight generic code away from
the specifics of underlying "source", which is why we used the generic
notion of a per-CPU source.
> So the simplifications to the code from the first couple of patch sets
> make this explanation slightly misleading. Could do to adjust if
> re-spinning set.
>
> Reviewed-by: Mike Leach <mike.leach@linaro.org>
Thanks
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-22 16:58 UTC|newest]
Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 19:35 [PATCH v4 00/19] arm64: coresight: Add support for ETE and TRBE Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 01/19] perf: aux: Add flags for the buffer format Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 02/19] perf: aux: Add CoreSight PMU buffer formats Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-16 17:04 ` Mathieu Poirier
2021-03-16 17:04 ` Mathieu Poirier
2021-03-22 12:29 ` Suzuki K Poulose
2021-03-22 12:29 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 03/19] kvm: arm64: Hide system instruction access to Trace registers Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-22 22:21 ` Suzuki K Poulose
2021-03-22 22:21 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 04/19] kvm: arm64: nvhe: Save the SPE context early Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-01 16:32 ` Alexandru Elisei
2021-03-01 16:32 ` Alexandru Elisei
2021-03-02 10:01 ` Suzuki K Poulose
2021-03-02 10:01 ` Suzuki K Poulose
2021-03-02 10:13 ` Marc Zyngier
2021-03-02 10:13 ` Marc Zyngier
2021-03-02 11:00 ` Alexandru Elisei
2021-03-02 11:00 ` Alexandru Elisei
2021-02-25 19:35 ` [PATCH v4 05/19] kvm: arm64: Disable guest access to trace filter controls Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-22 22:24 ` Suzuki K Poulose
2021-03-22 22:24 ` Suzuki K Poulose
2021-03-23 9:16 ` Marc Zyngier
2021-03-23 9:16 ` Marc Zyngier
2021-03-23 9:44 ` Suzuki K Poulose
2021-03-23 9:44 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 06/19] arm64: Add support for trace synchronization barrier Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 07/19] arm64: Add TRBE definitions Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-16 17:46 ` Mathieu Poirier
2021-03-16 17:46 ` Mathieu Poirier
2021-02-25 19:35 ` [PATCH v4 08/19] arm64: kvm: Enable access to TRBE support for host Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-16 17:49 ` Mathieu Poirier
2021-03-16 17:49 ` Mathieu Poirier
2021-02-25 19:35 ` [PATCH v4 09/19] coresight: etm4x: Move ETM to prohibited region for disable Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-08 17:25 ` Mike Leach
2021-03-08 17:25 ` Mike Leach
2021-03-16 19:30 ` Mathieu Poirier
2021-03-16 19:30 ` Mathieu Poirier
2021-03-17 10:44 ` Suzuki K Poulose
2021-03-17 10:44 ` Suzuki K Poulose
2021-03-17 17:09 ` Mathieu Poirier
2021-03-17 17:09 ` Mathieu Poirier
2021-03-22 21:28 ` Mathieu Poirier
2021-03-22 21:28 ` Mathieu Poirier
2021-02-25 19:35 ` [PATCH v4 10/19] coresight: etm-perf: Allow an event to use different sinks Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-08 17:25 ` Mike Leach
2021-03-08 17:25 ` Mike Leach
2021-03-16 20:23 ` Mathieu Poirier
2021-03-16 20:23 ` Mathieu Poirier
2021-03-17 10:47 ` Suzuki K Poulose
2021-03-17 10:47 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 11/19] coresight: Do not scan for graph if none is present Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 12/19] coresight: etm4x: Add support for PE OS lock Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 13/19] coresight: ete: Add support for ETE sysreg access Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-02-25 22:33 ` kernel test robot
2021-02-25 22:33 ` kernel test robot
2021-02-25 22:33 ` kernel test robot
2021-02-26 6:25 ` kernel test robot
2021-02-26 6:25 ` kernel test robot
2021-02-25 19:35 ` [PATCH v4 14/19] coresight: ete: Add support for ETE tracing Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 15/19] dts: bindings: Document device tree bindings for ETE Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-06 21:06 ` Rob Herring
2021-03-06 21:06 ` Rob Herring
2021-03-08 17:25 ` Mike Leach
2021-03-08 17:25 ` Mike Leach
2021-03-22 16:53 ` Suzuki K Poulose
2021-03-22 16:53 ` Suzuki K Poulose
2021-03-22 17:28 ` Rob Herring
2021-03-22 17:28 ` Rob Herring
2021-03-22 22:49 ` Suzuki K Poulose
2021-03-22 22:49 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 16/19] coresight: etm-perf: Handle stale output handles Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-02-25 19:35 ` [PATCH v4 17/19] coresight: core: Add support for dedicated percpu sinks Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-02-26 6:34 ` kernel test robot
2021-02-26 6:34 ` kernel test robot
2021-02-26 6:34 ` kernel test robot
2021-03-01 13:54 ` Suzuki K Poulose
2021-03-01 13:54 ` Suzuki K Poulose
2021-03-01 13:54 ` Suzuki K Poulose
2021-03-02 10:21 ` Anshuman Khandual
2021-03-02 10:21 ` Anshuman Khandual
2021-03-02 10:21 ` Anshuman Khandual
2021-03-01 14:08 ` [PATCH v4.1 " Suzuki K Poulose
2021-03-01 14:08 ` Suzuki K Poulose
2021-03-08 17:26 ` [PATCH v4 " Mike Leach
2021-03-08 17:26 ` Mike Leach
2021-03-22 16:57 ` Suzuki K Poulose [this message]
2021-03-22 16:57 ` Suzuki K Poulose
2021-03-17 19:31 ` Mathieu Poirier
2021-03-17 19:31 ` Mathieu Poirier
2021-02-25 19:35 ` [PATCH v4 18/19] coresight: sink: Add TRBE driver Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
2021-03-08 17:26 ` Mike Leach
2021-03-08 17:26 ` Mike Leach
2021-03-19 10:30 ` Suzuki K Poulose
2021-03-19 10:30 ` Suzuki K Poulose
2021-03-19 11:55 ` Mike Leach
2021-03-19 11:55 ` Mike Leach
2021-03-22 21:24 ` Mathieu Poirier
2021-03-22 21:24 ` Mathieu Poirier
2021-03-22 23:00 ` Suzuki K Poulose
2021-03-22 23:00 ` Suzuki K Poulose
2021-03-18 18:08 ` Mathieu Poirier
2021-03-18 18:08 ` Mathieu Poirier
2021-03-19 10:34 ` Suzuki K Poulose
2021-03-19 10:34 ` Suzuki K Poulose
2021-03-19 14:47 ` Mathieu Poirier
2021-03-19 14:47 ` Mathieu Poirier
2021-03-19 17:58 ` Mathieu Poirier
2021-03-19 17:58 ` Mathieu Poirier
2021-03-22 21:20 ` Mathieu Poirier
2021-03-22 21:20 ` Mathieu Poirier
2021-02-25 19:35 ` [PATCH v4 19/19] dts: bindings: Document device tree bindings for Arm TRBE Suzuki K Poulose
2021-02-25 19:35 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe2cce5-74b5-7ced-1a16-1dde90b920e2@arm.com \
--to=suzuki.poulose@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.