From: Chanwoo Choi <cw00.choi@samsung.com> To: Lukasz Luba <l.luba@partner.samsung.com>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Cc: tjakobi@math.uni-bielefeld.de, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, gregkh@linuxfoundation.org, keescook@chromium.org, anton@enomsg.org, ccross@android.com, tony.luck@intel.com, robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org, krzk@kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH 5/6] drivers: power: suspend: call devfreq suspend/resume Date: Thu, 22 Nov 2018 12:08:56 +0900 [thread overview] Message-ID: <5BF61DC8.7010809@samsung.com> (raw) In-Reply-To: <1542823301-23563-6-git-send-email-l.luba@partner.samsung.com> Hi, On 2018년 11월 22일 03:01, Lukasz Luba wrote: > Devfreq framework supports suspend of its devices. > Call the the devfreq interface and allow devfreq devices preserve/restore > their states during suspend/resume. > > The patch draws on Tobias Jakobi's work posted ~2 years ago, who tried to > solve issue with devfreq device's frequency during suspend/resume. > During the discussion on LKML some corner cases and comments appeared > related to the design. This patch address them keeping in mind suggestions > from Chanwoo Choi. Please remove the duplicate information about patch history because you already explained it on cover-letter. Looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> > --- > drivers/base/power/main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > index a690fd4..0992e67 100644 > --- a/drivers/base/power/main.c > +++ b/drivers/base/power/main.c > @@ -32,6 +32,7 @@ > #include <trace/events/power.h> > #include <linux/cpufreq.h> > #include <linux/cpuidle.h> > +#include <linux/devfreq.h> > #include <linux/timer.h> > > #include "../base.h" > @@ -1078,6 +1079,7 @@ void dpm_resume(pm_message_t state) > dpm_show_time(starttime, state, 0, NULL); > > cpufreq_resume(); > + devfreq_resume(); > trace_suspend_resume(TPS("dpm_resume"), state.event, false); > } > > @@ -1852,6 +1854,7 @@ int dpm_suspend(pm_message_t state) > trace_suspend_resume(TPS("dpm_suspend"), state.event, true); > might_sleep(); > > + devfreq_suspend(); > cpufreq_suspend(); > > mutex_lock(&dpm_list_mtx); > -- Best Regards, Chanwoo Choi Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/6] drivers: power: suspend: call devfreq suspend/resume Date: Thu, 22 Nov 2018 12:08:56 +0900 [thread overview] Message-ID: <5BF61DC8.7010809@samsung.com> (raw) In-Reply-To: <1542823301-23563-6-git-send-email-l.luba@partner.samsung.com> Hi, On 2018? 11? 22? 03:01, Lukasz Luba wrote: > Devfreq framework supports suspend of its devices. > Call the the devfreq interface and allow devfreq devices preserve/restore > their states during suspend/resume. > > The patch draws on Tobias Jakobi's work posted ~2 years ago, who tried to > solve issue with devfreq device's frequency during suspend/resume. > During the discussion on LKML some corner cases and comments appeared > related to the design. This patch address them keeping in mind suggestions > from Chanwoo Choi. Please remove the duplicate information about patch history because you already explained it on cover-letter. Looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> > --- > drivers/base/power/main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > index a690fd4..0992e67 100644 > --- a/drivers/base/power/main.c > +++ b/drivers/base/power/main.c > @@ -32,6 +32,7 @@ > #include <trace/events/power.h> > #include <linux/cpufreq.h> > #include <linux/cpuidle.h> > +#include <linux/devfreq.h> > #include <linux/timer.h> > > #include "../base.h" > @@ -1078,6 +1079,7 @@ void dpm_resume(pm_message_t state) > dpm_show_time(starttime, state, 0, NULL); > > cpufreq_resume(); > + devfreq_resume(); > trace_suspend_resume(TPS("dpm_resume"), state.event, false); > } > > @@ -1852,6 +1854,7 @@ int dpm_suspend(pm_message_t state) > trace_suspend_resume(TPS("dpm_suspend"), state.event, true); > might_sleep(); > > + devfreq_suspend(); > cpufreq_suspend(); > > mutex_lock(&dpm_list_mtx); > -- Best Regards, Chanwoo Choi Samsung Electronics
next prev parent reply other threads:[~2018-11-22 3:09 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20181121180156eucas1p225af7f4341a039264ff26f2a9ad9bb12@eucas1p2.samsung.com> 2018-11-21 18:01 ` [PATCH 0/6] devfreq: handle suspend/resume Lukasz Luba 2018-11-21 18:01 ` Lukasz Luba [not found] ` <CGME20181121180201eucas1p1f1f96941c3d16a96722e65d5c21bfe80@eucas1p1.samsung.com> 2018-11-21 18:01 ` [PATCH 1/6] devfreq: add basic fileds supporting suspend functionality Lukasz Luba 2018-11-21 18:01 ` Lukasz Luba 2018-11-22 2:37 ` Chanwoo Choi 2018-11-22 2:37 ` Chanwoo Choi [not found] ` <CGME20181121180202eucas1p27d3aa58411abeae03181c38b91fc67de@eucas1p2.samsung.com> 2018-11-21 18:01 ` [PATCH 2/6] devfreq: refactor set_target frequency function Lukasz Luba 2018-11-21 18:01 ` Lukasz Luba 2018-11-22 2:52 ` Chanwoo Choi 2018-11-22 2:52 ` Chanwoo Choi 2018-11-22 2:54 ` Chanwoo Choi 2018-11-22 2:54 ` Chanwoo Choi 2018-11-22 10:40 ` Lukasz Luba 2018-11-22 10:40 ` Lukasz Luba 2018-11-22 23:45 ` Chanwoo Choi 2018-11-22 23:45 ` Chanwoo Choi 2018-11-23 9:58 ` Lukasz Luba 2018-11-23 9:58 ` Lukasz Luba [not found] ` <CGME20181121180204eucas1p1c5891d498aa59c0e10dd3ba4727a4382@eucas1p1.samsung.com> 2018-11-21 18:01 ` [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device Lukasz Luba 2018-11-21 18:01 ` Lukasz Luba 2018-11-21 18:01 ` Lukasz Luba 2018-11-22 2:58 ` Chanwoo Choi 2018-11-22 2:58 ` Chanwoo Choi 2018-11-22 11:00 ` Lukasz Luba 2018-11-22 11:00 ` Lukasz Luba 2018-11-22 23:54 ` Chanwoo Choi 2018-11-22 23:54 ` Chanwoo Choi 2018-11-23 10:01 ` Lukasz Luba 2018-11-23 10:01 ` Lukasz Luba 2018-11-26 0:19 ` Chanwoo Choi 2018-11-26 0:19 ` Chanwoo Choi 2018-12-03 14:05 ` Lukasz Luba 2018-12-03 14:05 ` Lukasz Luba [not found] ` <CGME20181121180205eucas1p1dc52369476400cd07058d232bd8dbcd7@eucas1p1.samsung.com> 2018-11-21 18:01 ` [PATCH 4/6] devfreq: add devfreq_suspend/resume() functions Lukasz Luba 2018-11-21 18:01 ` Lukasz Luba 2018-11-22 3:07 ` Chanwoo Choi 2018-11-22 3:07 ` Chanwoo Choi 2018-11-22 11:02 ` Lukasz Luba 2018-11-22 11:02 ` Lukasz Luba [not found] ` <CGME20181121180206eucas1p265865226e3938a28e842e8367233dc2e@eucas1p2.samsung.com> 2018-11-21 18:01 ` [PATCH 5/6] drivers: power: suspend: call devfreq suspend/resume Lukasz Luba 2018-11-21 18:01 ` Lukasz Luba 2018-11-22 3:08 ` Chanwoo Choi [this message] 2018-11-22 3:08 ` Chanwoo Choi [not found] ` <CGME20181121180208eucas1p11482a783ab1b1bceb8c9f6a1f50682c3@eucas1p1.samsung.com> 2018-11-21 18:01 ` [PATCH 6/6] arm: dts: exynos4: set opp-suspend for DMC and leftbus Lukasz Luba 2018-11-21 18:01 ` Lukasz Luba 2018-11-22 3:09 ` Chanwoo Choi 2018-11-22 3:09 ` Chanwoo Choi 2018-11-22 11:04 ` Lukasz Luba 2018-11-22 11:04 ` Lukasz Luba 2018-11-22 17:24 ` [PATCH 0/6] devfreq: handle suspend/resume Tobias Jakobi 2018-11-22 17:24 ` Tobias Jakobi 2018-11-22 17:44 ` Lukasz Luba 2018-11-22 17:44 ` Lukasz Luba [not found] ` <CGME20181121180201eucas1p1f1f96941c3d16a96722e65d5c21bfe80@epcms1p8> 2018-11-26 8:14 ` [PATCH 1/6] devfreq: add basic fileds supporting suspend functionality MyungJoo Ham 2018-11-26 8:14 ` MyungJoo Ham 2018-11-26 8:14 ` MyungJoo Ham 2018-12-03 14:03 ` Lukasz Luba 2018-12-03 14:03 ` Lukasz Luba 2018-12-03 14:03 ` Lukasz Luba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5BF61DC8.7010809@samsung.com \ --to=cw00.choi@samsung.com \ --cc=anton@enomsg.org \ --cc=b.zolnierkie@samsung.com \ --cc=ccross@android.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=keescook@chromium.org \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=l.luba@partner.samsung.com \ --cc=len.brown@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mark.rutland@arm.com \ --cc=myungjoo.ham@samsung.com \ --cc=pavel@ucw.cz \ --cc=rjw@rjwysocki.net \ --cc=robh+dt@kernel.org \ --cc=tjakobi@math.uni-bielefeld.de \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.