From: Lukasz Luba <l.luba@partner.samsung.com>
To: myungjoo.ham@samsung.com,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "tjakobi@math.uni-bielefeld.de" <tjakobi@math.uni-bielefeld.de>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"len.brown@intel.com" <len.brown@intel.com>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"anton@enomsg.org" <anton@enomsg.org>,
"ccross@android.com" <ccross@android.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"kgene@kernel.org" <kgene@kernel.org>,
"krzk@kernel.org" <krzk@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 1/6] devfreq: add basic fileds supporting suspend functionality
Date: Mon, 3 Dec 2018 15:03:33 +0100 [thread overview]
Message-ID: <9af62c00-0bf5-4dfd-f7fb-f6de1ce42717@partner.samsung.com> (raw)
In-Reply-To: <20181126081427epcms1p8801d251017da40b59d7e8391ee247fdb@epcms1p8>
Hi MyungJoo,
On 11/26/18 9:14 AM, MyungJoo Ham wrote:
>> The patch prepares devfreq device for handling suspend/resume functionality.
>> The new fields will store needed information during this process.
>> Devfreq framework handles opp-suspend DT entry and there is no need of
>> modyfications in the drivers code.
>>
>> The patch draws on Tobias Jakobi's work posted ~2 years ago, who tried to
>> solve issue with devfreq device's frequency during suspend/resume.
>> During the discussion on LKML some corner cases and comments appeared
>> related to the design. This patch address them keeping in mind suggestions
>>from Chanwoo Choi.
>>
>> Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> Suggested-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>
> When you add new elements in a common struct (i.e., struct devfreq),
> please describe kindly in the doxygen entries so that developers
> may understand before reading all places where the new elements are
> used.
>
> You have added three new elements and there is no explanations on them.
You are right, thank you for the review.
I will fix it in the next patch set version.
Regards,
Lukasz
>
>
> Cheers,
> MyungJoo
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Luba <l.luba@partner.samsung.com>
To: myungjoo.ham@samsung.com,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"len.brown@intel.com" <len.brown@intel.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"keescook@chromium.org" <keescook@chromium.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"anton@enomsg.org" <anton@enomsg.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"krzk@kernel.org" <krzk@kernel.org>,
"tjakobi@math.uni-bielefeld.de" <tjakobi@math.uni-bielefeld.de>,
Kyungmin Park <kyungmin.park@samsung.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"kgene@kernel.org" <kgene@kernel.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"ccross@android.com" <ccross@android.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/6] devfreq: add basic fileds supporting suspend functionality
Date: Mon, 3 Dec 2018 15:03:33 +0100 [thread overview]
Message-ID: <9af62c00-0bf5-4dfd-f7fb-f6de1ce42717@partner.samsung.com> (raw)
In-Reply-To: <20181126081427epcms1p8801d251017da40b59d7e8391ee247fdb@epcms1p8>
Hi MyungJoo,
On 11/26/18 9:14 AM, MyungJoo Ham wrote:
>> The patch prepares devfreq device for handling suspend/resume functionality.
>> The new fields will store needed information during this process.
>> Devfreq framework handles opp-suspend DT entry and there is no need of
>> modyfications in the drivers code.
>>
>> The patch draws on Tobias Jakobi's work posted ~2 years ago, who tried to
>> solve issue with devfreq device's frequency during suspend/resume.
>> During the discussion on LKML some corner cases and comments appeared
>> related to the design. This patch address them keeping in mind suggestions
>>from Chanwoo Choi.
>>
>> Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> Suggested-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>
> When you add new elements in a common struct (i.e., struct devfreq),
> please describe kindly in the doxygen entries so that developers
> may understand before reading all places where the new elements are
> used.
>
> You have added three new elements and there is no explanations on them.
You are right, thank you for the review.
I will fix it in the next patch set version.
Regards,
Lukasz
>
>
> Cheers,
> MyungJoo
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-03 14:03 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181121180156eucas1p225af7f4341a039264ff26f2a9ad9bb12@eucas1p2.samsung.com>
2018-11-21 18:01 ` [PATCH 0/6] devfreq: handle suspend/resume Lukasz Luba
2018-11-21 18:01 ` Lukasz Luba
[not found] ` <CGME20181121180201eucas1p1f1f96941c3d16a96722e65d5c21bfe80@eucas1p1.samsung.com>
2018-11-21 18:01 ` [PATCH 1/6] devfreq: add basic fileds supporting suspend functionality Lukasz Luba
2018-11-21 18:01 ` Lukasz Luba
2018-11-22 2:37 ` Chanwoo Choi
2018-11-22 2:37 ` Chanwoo Choi
[not found] ` <CGME20181121180202eucas1p27d3aa58411abeae03181c38b91fc67de@eucas1p2.samsung.com>
2018-11-21 18:01 ` [PATCH 2/6] devfreq: refactor set_target frequency function Lukasz Luba
2018-11-21 18:01 ` Lukasz Luba
2018-11-22 2:52 ` Chanwoo Choi
2018-11-22 2:52 ` Chanwoo Choi
2018-11-22 2:54 ` Chanwoo Choi
2018-11-22 2:54 ` Chanwoo Choi
2018-11-22 10:40 ` Lukasz Luba
2018-11-22 10:40 ` Lukasz Luba
2018-11-22 23:45 ` Chanwoo Choi
2018-11-22 23:45 ` Chanwoo Choi
2018-11-23 9:58 ` Lukasz Luba
2018-11-23 9:58 ` Lukasz Luba
[not found] ` <CGME20181121180204eucas1p1c5891d498aa59c0e10dd3ba4727a4382@eucas1p1.samsung.com>
2018-11-21 18:01 ` [PATCH 3/6] devfreq: add support for suspend/resume of a devfreq device Lukasz Luba
2018-11-21 18:01 ` Lukasz Luba
2018-11-21 18:01 ` Lukasz Luba
2018-11-22 2:58 ` Chanwoo Choi
2018-11-22 2:58 ` Chanwoo Choi
2018-11-22 11:00 ` Lukasz Luba
2018-11-22 11:00 ` Lukasz Luba
2018-11-22 23:54 ` Chanwoo Choi
2018-11-22 23:54 ` Chanwoo Choi
2018-11-23 10:01 ` Lukasz Luba
2018-11-23 10:01 ` Lukasz Luba
2018-11-26 0:19 ` Chanwoo Choi
2018-11-26 0:19 ` Chanwoo Choi
2018-12-03 14:05 ` Lukasz Luba
2018-12-03 14:05 ` Lukasz Luba
[not found] ` <CGME20181121180205eucas1p1dc52369476400cd07058d232bd8dbcd7@eucas1p1.samsung.com>
2018-11-21 18:01 ` [PATCH 4/6] devfreq: add devfreq_suspend/resume() functions Lukasz Luba
2018-11-21 18:01 ` Lukasz Luba
2018-11-22 3:07 ` Chanwoo Choi
2018-11-22 3:07 ` Chanwoo Choi
2018-11-22 11:02 ` Lukasz Luba
2018-11-22 11:02 ` Lukasz Luba
[not found] ` <CGME20181121180206eucas1p265865226e3938a28e842e8367233dc2e@eucas1p2.samsung.com>
2018-11-21 18:01 ` [PATCH 5/6] drivers: power: suspend: call devfreq suspend/resume Lukasz Luba
2018-11-21 18:01 ` Lukasz Luba
2018-11-22 3:08 ` Chanwoo Choi
2018-11-22 3:08 ` Chanwoo Choi
[not found] ` <CGME20181121180208eucas1p11482a783ab1b1bceb8c9f6a1f50682c3@eucas1p1.samsung.com>
2018-11-21 18:01 ` [PATCH 6/6] arm: dts: exynos4: set opp-suspend for DMC and leftbus Lukasz Luba
2018-11-21 18:01 ` Lukasz Luba
2018-11-22 3:09 ` Chanwoo Choi
2018-11-22 3:09 ` Chanwoo Choi
2018-11-22 11:04 ` Lukasz Luba
2018-11-22 11:04 ` Lukasz Luba
2018-11-22 17:24 ` [PATCH 0/6] devfreq: handle suspend/resume Tobias Jakobi
2018-11-22 17:24 ` Tobias Jakobi
2018-11-22 17:44 ` Lukasz Luba
2018-11-22 17:44 ` Lukasz Luba
[not found] ` <CGME20181121180201eucas1p1f1f96941c3d16a96722e65d5c21bfe80@epcms1p8>
2018-11-26 8:14 ` [PATCH 1/6] devfreq: add basic fileds supporting suspend functionality MyungJoo Ham
2018-11-26 8:14 ` MyungJoo Ham
2018-11-26 8:14 ` MyungJoo Ham
2018-12-03 14:03 ` Lukasz Luba [this message]
2018-12-03 14:03 ` Lukasz Luba
2018-12-03 14:03 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9af62c00-0bf5-4dfd-f7fb-f6de1ce42717@partner.samsung.com \
--to=l.luba@partner.samsung.com \
--cc=anton@enomsg.org \
--cc=b.zolnierkie@samsung.com \
--cc=ccross@android.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.